| Message ID | 20241003133904.69244-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] dt-bindings: display: bridge: tc358768: switch to bus-width | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 03/10/2024 15:39, Krzysztof Kozlowski wrote: > "data-lines" property is way too similar to "data-lanes". It is also > duplicating "bus-width" from video-interfaces.yaml schema. "data-lines" > was deprecated in the bindings and "bus-width" is preferred, so parse it > instead while keeping things backwards compatible. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/gpu/drm/bridge/tc358768.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c > index 0e8813278a2f..fc96fa5aab54 100644 > --- a/drivers/gpu/drm/bridge/tc358768.c > +++ b/drivers/gpu/drm/bridge/tc358768.c > @@ -443,7 +443,9 @@ static int tc358768_dsi_host_attach(struct mipi_dsi_host *host, > ret = -EINVAL; > ep = of_graph_get_endpoint_by_regs(host->dev->of_node, 0, 0); > if (ep) { > - ret = of_property_read_u32(ep, "data-lines", &priv->pd_lines); > + ret = of_property_read_u32(ep, "bus-width", &priv->pd_lines); > + if (ret) > + ret = of_property_read_u32(ep, "data-lines", &priv->pd_lines); > > of_node_put(ep); > } Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 03/10/2024 15:39, Krzysztof Kozlowski wrote: > "data-lines" property is way too similar to "data-lanes". It is also > duplicating "bus-width" from video-interfaces.yaml schema. Deprecate > "data-lines" and use the common property. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > index 779d8c57f854..bb5d3b543800 100644 > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > @@ -60,6 +60,10 @@ properties: > data-lines: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [ 16, 18, 24 ] > + deprecated: true > + > + bus-width: > + enum: [ 16, 18, 24 ] > > port@1: > $ref: /schemas/graph.yaml#/properties/port Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Thu, 03 Oct 2024 15:39:03 +0200, Krzysztof Kozlowski wrote: > "data-lines" property is way too similar to "data-lanes". It is also > duplicating "bus-width" from video-interfaces.yaml schema. Deprecate > "data-lines" and use the common property. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Hi, On Thu, 03 Oct 2024 15:39:03 +0200, Krzysztof Kozlowski wrote: > "data-lines" property is way too similar to "data-lanes". It is also > duplicating "bus-width" from video-interfaces.yaml schema. Deprecate > "data-lines" and use the common property. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/2] dt-bindings: display: bridge: tc358768: switch to bus-width https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d704a2fe530caa7023949b513b8d1c364b5832fb [2/2] drm/bridge: tc358768: switch to bus-width https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/bf7c079902c34f8b16ea3484de080a7bb4ad0367
diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml index 779d8c57f854..bb5d3b543800 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -60,6 +60,10 @@ properties: data-lines: $ref: /schemas/types.yaml#/definitions/uint32 enum: [ 16, 18, 24 ] + deprecated: true + + bus-width: + enum: [ 16, 18, 24 ] port@1: $ref: /schemas/graph.yaml#/properties/port
"data-lines" property is way too similar to "data-lanes". It is also duplicating "bus-width" from video-interfaces.yaml schema. Deprecate "data-lines" and use the common property. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 4 ++++ 1 file changed, 4 insertions(+)