| Message ID | cover.1739555984.git.Ryan.Wanner@microchip.com |
|---|---|
| Headers | show |
| Series | Add System Components for Microchip SAMA7D65 SoC | expand |
Hi, Ryan, On 14.02.2025 20:08, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > Add DMAs to the SAMA7D65 SoC device tree. > > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > --- > arch/arm/boot/dts/microchip/sama7d65.dtsi | 32 +++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi > index d06a51972d363..b472a7d929ee4 100644 > --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi > +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi > @@ -9,6 +9,7 @@ > */ > > #include <dt-bindings/clock/at91.h> > +#include <dt-bindings/dma/at91.h> > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/interrupt-controller/irq.h> > @@ -95,6 +96,17 @@ chipid@e0020000 { > reg = <0xe0020000 0x8>; > }; > > + dma2: dma-controller@e1200000 { > + compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma"; > + reg = <0xe1200000 0x1000>; > + interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>; > + #dma-cells = <1>; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 23>; > + clock-names = "dma_clk"; > + dma-requests = <0>; > + status = "disabled"; > + }; > + > sdmmc1: mmc@e1208000 { > compatible = "microchip,sama7d65-sdhci", "microchip,sam9x60-sdhci"; > reg = <0xe1208000 0x400>; > @@ -107,6 +119,26 @@ sdmmc1: mmc@e1208000 { > status = "disabled"; > }; > > + dma0: dma-controller@e1610000 { > + compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma"; > + reg = < 0xe1610000 0x1000>; There is an extra space b/w < and 0x. I can adjust while applying. > + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>; > + #dma-cells = <1>; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 21>; > + clock-names = "dma_clk"; > + status = "disabled"; > + }; > + > + dma1: dma-controller@e1614000 { > + compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma"; > + reg = <0xe1614000 0x1000>; > + interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>; > + #dma-cells = <1>; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 22>; > + clock-names = "dma_clk"; > + status = "disabled"; > + }; > + > pit64b0: timer@e1800000 { > compatible = "microchip,sama7d65-pit64b", "microchip,sam9x60-pit64b"; > reg = <0xe1800000 0x100>;
Hi, Ryan, On 14.02.2025 20:08, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > This patch set adds support for the following systems in the SAMA7D65 > SoC: > - DMAs > - Chip ID > - Dual watchdog timer. > > Ryan Wanner (8): > dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID > dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt > dt-bindings: dma: atmel: add microchip,sama7d65-dma > ARM: at91: Add Support in SoC driver for SAMA7D65 > ARM: dts: microchip: sama7d65: Add chipID for sama7d65 > ARM: dts: microchip: sama7d65: Add watchdog for sama7d65 > ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC > ARM: dts: microchip: sama7d65: Enable DMAs Series looks good to me. I'm waiting to see if there are comments on bindings before applying the DT part. Thank you, Claudiu
On Fri, 14 Feb 2025 11:08:13 -0700, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > This patch set adds support for the following systems in the SAMA7D65 > SoC: > - DMAs > - Chip ID > - Dual watchdog timer. > > Ryan Wanner (8): > dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID > dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt > dt-bindings: dma: atmel: add microchip,sama7d65-dma > ARM: at91: Add Support in SoC driver for SAMA7D65 > ARM: dts: microchip: sama7d65: Add chipID for sama7d65 > ARM: dts: microchip: sama7d65: Add watchdog for sama7d65 > ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC > ARM: dts: microchip: sama7d65: Enable DMAs > > .../devicetree/bindings/arm/atmel-sysregs.txt | 1 + > .../bindings/dma/atmel,sama5d4-dma.yaml | 3 ++ > .../bindings/watchdog/atmel,sama5d4-wdt.yaml | 3 ++ > .../dts/microchip/at91-sama7d65_curiosity.dts | 12 +++++ > arch/arm/boot/dts/microchip/sama7d65.dtsi | 44 +++++++++++++++++++ > drivers/soc/atmel/soc.c | 5 +++ > drivers/soc/atmel/soc.h | 3 ++ > 7 files changed, 71 insertions(+) > > -- > 2.43.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/microchip/' for cover.1739555984.git.Ryan.Wanner@microchip.com: arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: watchdog@e001d180: Unevaluated properties are not allowed ('clocks' was unexpected) from schema $id: http://devicetree.org/schemas/watchdog/atmel,sama5d4-wdt.yaml# arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/chipid@e0020000: failed to match any schema with compatible: ['microchip,sama7d65-chipid']
Hi, Ryan, On 14.02.2025 20:08, Ryan.Wanner@microchip.com wrote: > + ps_wdt: watchdog@e001d180 { > + compatible = "microchip,sama7d65-wdt", "microchip,sama7g5-wdt"; > + reg = <0xe001d000 0x30>; The node address and the one specified in reg don't match. I will skip applying this. Also, please sort the nodes by their addresses. Thank you, Claudiu > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk32k 0>; > + }; > +
On 14.02.2025 20:08, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > Ryan Wanner (8): > dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID > ARM: at91: Add Support in SoC driver for SAMA7D65 Applied to at91-soc, thanks! > ARM: dts: microchip: sama7d65: Add chipID for sama7d65 > ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC > ARM: dts: microchip: sama7d65: Enable DMAs Applied to at91-dt, thanks!
On Fri, 14 Feb 2025 11:08:13 -0700, Ryan.Wanner@microchip.com wrote: > This patch set adds support for the following systems in the SAMA7D65 > SoC: > - DMAs > - Chip ID > - Dual watchdog timer. > > Ryan Wanner (8): > dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID > dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt > dt-bindings: dma: atmel: add microchip,sama7d65-dma > ARM: at91: Add Support in SoC driver for SAMA7D65 > ARM: dts: microchip: sama7d65: Add chipID for sama7d65 > ARM: dts: microchip: sama7d65: Add watchdog for sama7d65 > ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC > ARM: dts: microchip: sama7d65: Enable DMAs > > [...] Applied, thanks! [3/8] dt-bindings: dma: atmel: add microchip,sama7d65-dma commit: e19ba02eeb8e98086708ee11ca1b123d17ec1977 Best regards,
From: Ryan Wanner <Ryan.Wanner@microchip.com> This patch set adds support for the following systems in the SAMA7D65 SoC: - DMAs - Chip ID - Dual watchdog timer. Ryan Wanner (8): dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt dt-bindings: dma: atmel: add microchip,sama7d65-dma ARM: at91: Add Support in SoC driver for SAMA7D65 ARM: dts: microchip: sama7d65: Add chipID for sama7d65 ARM: dts: microchip: sama7d65: Add watchdog for sama7d65 ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC ARM: dts: microchip: sama7d65: Enable DMAs .../devicetree/bindings/arm/atmel-sysregs.txt | 1 + .../bindings/dma/atmel,sama5d4-dma.yaml | 3 ++ .../bindings/watchdog/atmel,sama5d4-wdt.yaml | 3 ++ .../dts/microchip/at91-sama7d65_curiosity.dts | 12 +++++ arch/arm/boot/dts/microchip/sama7d65.dtsi | 44 +++++++++++++++++++ drivers/soc/atmel/soc.c | 5 +++ drivers/soc/atmel/soc.h | 3 ++ 7 files changed, 71 insertions(+)