| Message ID | 20250107160850.120537-1-Ryan.Wanner@microchip.com |
|---|---|
| Headers | show |
| Series | Add support for SAMA7D65 | expand |
On Tue, 07 Jan 2025 09:07:22 -0700, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > This series adds support for the SAMA7D65 SoC. > > V2 of this series [1]. > V3 of this series [2]. > V4 of this series [4]. > > For the pinctrl and pit64 timers those will have DTB warnings due to > those bindings not being in the .yaml format. > > Changes v1->v2: > - V1 set was sent incorrectly as multiple seprate patches v2 took all > those patches and put them in 1 thread. > > Changes v2->v3: > - Correct the patch order to follow correct practice. > - Correct flexcom dt-binding commit messge to reflect the changes in the > coding style. > - Add missing SoB tags to patches. > - Moved export clocks to DT patch to be included with the clock binding > patch. > - Separate Kconfig changes and defconfig changes into different patches > and removed unused Kconfig params. > - Correct confusing SoB and Co-developed chain. > - Removed unsued nodes in DTSI file and sorted includes > alphanumerically. > - Fix incorrect dts formatting. > - Separate dts and pinmux changes into two patches. > - Combine PLL and MCK changes into core clock driver patch. > - Correct formatting in main clock driver. > - MMC dt-binding changes are applied for next so have been removed from > the set [3]. > > Changes v3->v4: > - Collect all tags from maintainers. > - Correct compile error on 11/13 and correct location of vendor specific > properties. > - Add USB and UTMI selections to 12/13 to prevent compile errors due to > functions in the clock driver that use the USB clock system. > - Add "microchip,sama7g5-pinctrl" compatible string as a fall back in > 9/13. > - Add missing kfree() to 8/13 to correctly handle error case. > - Replace bad spacing with correct tab formatting on 7/13. > > Changes from v4->v5: > - Remove patches that have been applied [5]. > - Update pinctrl dt-binding to use fallback formatting. > > Note: > - For the SDHCI DTB error that patch has been removed do to it being > applied see [3]. > - There are DTB errors on microchip,sama7d65-pit64b and > microchip,sama7d65-pinctrl, this is due to those bindings being .txt > files. > > 1) https://lore.kernel.org/linux-arm-kernel/cover.1732030972.git.Ryan.Wanner@microchip.com/T/#m9691b4d58b62f36f6cbac1d06883c985766c2c0d > 2) https://lore.kernel.org/linux-arm-kernel/cover.1733505542.git.Ryan.Wanner@microchip.com/T/#m3b52978236907198f727424e69ef21c8898e95c8 > 3) https://lore.kernel.org/linux-arm-kernel/cover.1732030972.git.Ryan.Wanner@microchip.com/T/#mccf6521c07e74e1c7dc61b09ae0ebdbbdde73a28 > 4) https://lore.kernel.org/linux-arm-kernel/70d429086fd8e858d79ca2824ad8cc4a09e3fe5d.1734723585.git.Ryan.Wanner@microchip.com/T/#m918b8db23c8d30981263846a02dafc085e17de14 > 5) https://lore.kernel.org/linux-arm-kernel/70d429086fd8e858d79ca2824ad8cc4a09e3fe5d.1734723585.git.Ryan.Wanner@microchip.com/T/#m69b8f11536e3b0ca3d69d125d0670c90412d4317 > > > > Dharma Balasubiramani (2): > dt-bindings: serial: atmel,at91-usart: add microchip,sama7d65-usart > dt-bindings: pinctrl: at91-pio4: add microchip,sama7d65-pinctrl > > Romain Sioen (2): > dt-bindings: ARM: at91: Document Microchip SAMA7D65 Curiosity > ARM: dts: microchip: add support for sama7d65_curiosity board > > Ryan Wanner (1): > ARM: dts: microchip: add sama7d65 SoC DT > > .../devicetree/bindings/arm/atmel-at91.yaml | 7 + > .../pinctrl/atmel,at91-pio4-pinctrl.txt | 3 +- > .../bindings/serial/atmel,at91-usart.yaml | 1 + > arch/arm/boot/dts/microchip/Makefile | 3 + > .../dts/microchip/at91-sama7d65_curiosity.dts | 89 +++++++++++ > arch/arm/boot/dts/microchip/sama7d65.dtsi | 145 ++++++++++++++++++ > 6 files changed, 247 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts > create mode 100644 arch/arm/boot/dts/microchip/sama7d65.dtsi > > -- > 2.43.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y microchip/at91-sama7d65_curiosity.dtb' for 20250107160850.120537-1-Ryan.Wanner@microchip.com: arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/pinctrl@e0014000: failed to match any schema with compatible: ['microchip,sama7d65-pinctrl', 'microchip,sama7g5-pinctrl'] arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/pinctrl@e0014000: failed to match any schema with compatible: ['microchip,sama7d65-pinctrl', 'microchip,sama7g5-pinctrl'] arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/timer@e1800000: failed to match any schema with compatible: ['microchip,sama7d65-pit64b', 'microchip,sam9x60-pit64b'] arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/timer@e1800000: failed to match any schema with compatible: ['microchip,sama7d65-pit64b', 'microchip,sam9x60-pit64b'] arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/timer@e1804000: failed to match any schema with compatible: ['microchip,sama7d65-pit64b', 'microchip,sam9x60-pit64b'] arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/timer@e1804000: failed to match any schema with compatible: ['microchip,sama7d65-pit64b', 'microchip,sam9x60-pit64b'] arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: flexcom@e2020000: compatible: 'oneOf' conditional failed, one must be fixed: ['microchip,sama7d65-flexcom', 'atmel,sama5d2-flexcom'] is too long 'atmel,sama5d2-flexcom' was expected 'microchip,sam9x7-flexcom' was expected 'microchip,sama7g5-flexcom' was expected from schema $id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml# arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/flexcom@e2020000: failed to match any schema with compatible: ['microchip,sama7d65-flexcom', 'atmel,sama5d2-flexcom']
Hi, Ryan, On 07.01.2025 18:07, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > Add Device Tree for sama7d65 SoC. > > Co-developed-by: Dharma Balasubiramani <dharma.b@microchip.com> > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > Co-developed-by: Romain Sioen <romain.sioen@microchip.com> > Signed-off-by: Romain Sioen <romain.sioen@microchip.com> > Co-developed-by: Varshini Rajendran <varshini.rajendran@microchip.com> > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev> > --- > arch/arm/boot/dts/microchip/sama7d65.dtsi | 145 ++++++++++++++++++++++ > 1 file changed, 145 insertions(+) > create mode 100644 arch/arm/boot/dts/microchip/sama7d65.dtsi > > diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi > new file mode 100644 > index 000000000000..03e1adfdcd34 > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi > @@ -0,0 +1,145 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * sama7d65.dtsi - Device Tree Include file for SAMA7D65 SoC > + * > + * Copyright (C) 2024 Microchip Technology, Inc. and its subsidiaries I presume the , in "Microchip Technology, Inc." it a typo. I already removed it while applied this. Just please let me know if all good with it. > + * > + * Author: Ryan Wanner <Ryan.Wanner@microchip.com> > + * > + */ > + > +#include <dt-bindings/clock/at91.h> > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/mfd/at91-usart.h> > + > +/ { > + model = "Microchip SAMA7D65 family SoC"; > + compatible = "microchip,sama7d65"; > + #address-cells = <1>; > + #size-cells = <1>; > + interrupt-parent = <&gic>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu0: cpu@0 { > + compatible = "arm,cortex-a7"; > + reg = <0x0>; > + device_type = "cpu"; > + clocks = <&pmc PMC_TYPE_CORE PMC_CPUPLL>; > + clock-names = "cpu"; > + }; > + }; > + > + clocks { > + main_xtal: clock-mainxtal { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; > + > + slow_xtal: clock-slowxtal { There is an extra space in front of slow_xtal. I removed it while applying. > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; > + There is an empty line here. I removed it while applying. Everything else look good to me. Thank you, Claudiu
Hi, Ryan, On 07.01.2025 18:07, Ryan.Wanner@microchip.com wrote: > From: Romain Sioen <romain.sioen@microchip.com> > > Add device tree support for the SAMA7D65 Curiosity board. > Update the Makefile to include the new device tree file. > > uart6 is related to flexcom6, hence not sorted in alphabetical order. > > Signed-off-by: Romain Sioen <romain.sioen@microchip.com> > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > --- > arch/arm/boot/dts/microchip/Makefile | 3 + > .../dts/microchip/at91-sama7d65_curiosity.dts | 89 +++++++++++++++++++ > 2 files changed, 92 insertions(+) > create mode 100644 arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts > > diff --git a/arch/arm/boot/dts/microchip/Makefile b/arch/arm/boot/dts/microchip/Makefile > index 470fe46433a9..79cd38fdc7da 100644 > --- a/arch/arm/boot/dts/microchip/Makefile > +++ b/arch/arm/boot/dts/microchip/Makefile > @@ -12,6 +12,7 @@ DTC_FLAGS_at91-sama5d2_xplained := -@ > DTC_FLAGS_at91-sama5d3_eds := -@ > DTC_FLAGS_at91-sama5d3_xplained := -@ > DTC_FLAGS_at91-sama5d4_xplained := -@ > +DTC_FLAGS_at91-sama7d65_curiosity := -@ > DTC_FLAGS_at91-sama7g54_curiosity := -@ > DTC_FLAGS_at91-sama7g5ek := -@ > dtb-$(CONFIG_SOC_AT91RM9200) += \ > @@ -90,6 +91,8 @@ dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-sama5d4_xplained.dtb \ > at91-sama5d4ek.dtb \ > at91-vinco.dtb > +dtb-$(CONFIG_SOC_SAMA7D65) += \ > + at91-sama7d65_curiosity.dtb > dtb-$(CONFIG_SOC_SAMA7G5) += \ > at91-sama7g54_curiosity.dtb \ > at91-sama7g5ek.dtb > diff --git a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts > new file mode 100644 > index 000000000000..ef6a56db8acb > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts > @@ -0,0 +1,89 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sama7d65_curiosity.dts - Device Tree file for SAMA7D65 Curiosity board > + * > + * Copyright (c) 2024 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Romain Sioen <romain.sioen@microchip.com> > + * > + */ > +/dts-v1/; > +#include "sama7d65-pinfunc.h" > +#include "sama7d65.dtsi" > +#include <dt-bindings/mfd/atmel-flexcom.h> > +#include <dt-bindings/pinctrl/at91.h> > + > +/ { > + model = "Microchip SAMA7D65 Curiosity"; > + compatible = "microchip,sama7d65-curiosity", "microchip,sama7d65", > + "microchip,sama7d6", "microchip,sama7"; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + aliases { > + serial0 = &uart6; > + }; While applying this, I switched chosen and aliases to have it alphanumerically sorted. > + > + memory@60000000 { > + device_type = "memory"; > + reg = <0x60000000 0x40000000>; > + }; > +}; > + > +&flx6 { > + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>; > + status = "okay"; > +}; > + > +&uart6 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart6_default>; > + status = "okay"; > +}; > + > +&main_xtal { > + clock-frequency = <24000000>; > +}; > + > +&pioa { > + pinctrl_sdmmc1_default: sdmmc1-default { > + cmd-data { > + pinmux = <PIN_PB22__SDMMC1_CMD>, > + <PIN_PB24__SDMMC1_DAT0>, > + <PIN_PB25__SDMMC1_DAT1>, > + <PIN_PB26__SDMMC1_DAT2>, > + <PIN_PB27__SDMMC1_DAT3>; > + slew-rate = <0>; > + bias-disable; > + }; > + > + ck-cd-rstn-vddsel { > + pinmux = <PIN_PB23__SDMMC1_CK>, > + <PIN_PB21__SDMMC1_RSTN>, > + <PIN_PB30__SDMMC1_1V8SEL>, > + <PIN_PB29__SDMMC1_CD>, > + <PIN_PB28__SDMMC1_WP>; > + slew-rate = <0>; > + bias-disable; > + }; > + }; > + > + pinctrl_uart6_default: uart6-default { > + pinmux = <PIN_PD18__FLEXCOM6_IO0>, > + <PIN_PD19__FLEXCOM6_IO1>; Missing a space here ^. I already added it while applying. Thank you, Claudiu
On 07.01.2025 18:07, Ryan.Wanner@microchip.com wrote: > Romain Sioen (2): > dt-bindings: ARM: at91: Document Microchip SAMA7D65 Curiosity It was already applied from the previous version. > ARM: dts: microchip: add support for sama7d65_curiosity board Applied to at91-dt, thanks! > > Ryan Wanner (1): > ARM: dts: microchip: add sama7d65 SoC DT Applied to at91-dt, thanks! BTW, if I'm not wrong you lost the MFD patch on this version.
From: Ryan Wanner <Ryan.Wanner@microchip.com> This series adds support for the SAMA7D65 SoC. V2 of this series [1]. V3 of this series [2]. V4 of this series [4]. For the pinctrl and pit64 timers those will have DTB warnings due to those bindings not being in the .yaml format. Changes v1->v2: - V1 set was sent incorrectly as multiple seprate patches v2 took all those patches and put them in 1 thread. Changes v2->v3: - Correct the patch order to follow correct practice. - Correct flexcom dt-binding commit messge to reflect the changes in the coding style. - Add missing SoB tags to patches. - Moved export clocks to DT patch to be included with the clock binding patch. - Separate Kconfig changes and defconfig changes into different patches and removed unused Kconfig params. - Correct confusing SoB and Co-developed chain. - Removed unsued nodes in DTSI file and sorted includes alphanumerically. - Fix incorrect dts formatting. - Separate dts and pinmux changes into two patches. - Combine PLL and MCK changes into core clock driver patch. - Correct formatting in main clock driver. - MMC dt-binding changes are applied for next so have been removed from the set [3]. Changes v3->v4: - Collect all tags from maintainers. - Correct compile error on 11/13 and correct location of vendor specific properties. - Add USB and UTMI selections to 12/13 to prevent compile errors due to functions in the clock driver that use the USB clock system. - Add "microchip,sama7g5-pinctrl" compatible string as a fall back in 9/13. - Add missing kfree() to 8/13 to correctly handle error case. - Replace bad spacing with correct tab formatting on 7/13. Changes from v4->v5: - Remove patches that have been applied [5]. - Update pinctrl dt-binding to use fallback formatting. Note: - For the SDHCI DTB error that patch has been removed do to it being applied see [3]. - There are DTB errors on microchip,sama7d65-pit64b and microchip,sama7d65-pinctrl, this is due to those bindings being .txt files. 1) https://lore.kernel.org/linux-arm-kernel/cover.1732030972.git.Ryan.Wanner@microchip.com/T/#m9691b4d58b62f36f6cbac1d06883c985766c2c0d 2) https://lore.kernel.org/linux-arm-kernel/cover.1733505542.git.Ryan.Wanner@microchip.com/T/#m3b52978236907198f727424e69ef21c8898e95c8 3) https://lore.kernel.org/linux-arm-kernel/cover.1732030972.git.Ryan.Wanner@microchip.com/T/#mccf6521c07e74e1c7dc61b09ae0ebdbbdde73a28 4) https://lore.kernel.org/linux-arm-kernel/70d429086fd8e858d79ca2824ad8cc4a09e3fe5d.1734723585.git.Ryan.Wanner@microchip.com/T/#m918b8db23c8d30981263846a02dafc085e17de14 5) https://lore.kernel.org/linux-arm-kernel/70d429086fd8e858d79ca2824ad8cc4a09e3fe5d.1734723585.git.Ryan.Wanner@microchip.com/T/#m69b8f11536e3b0ca3d69d125d0670c90412d4317 Dharma Balasubiramani (2): dt-bindings: serial: atmel,at91-usart: add microchip,sama7d65-usart dt-bindings: pinctrl: at91-pio4: add microchip,sama7d65-pinctrl Romain Sioen (2): dt-bindings: ARM: at91: Document Microchip SAMA7D65 Curiosity ARM: dts: microchip: add support for sama7d65_curiosity board Ryan Wanner (1): ARM: dts: microchip: add sama7d65 SoC DT .../devicetree/bindings/arm/atmel-at91.yaml | 7 + .../pinctrl/atmel,at91-pio4-pinctrl.txt | 3 +- .../bindings/serial/atmel,at91-usart.yaml | 1 + arch/arm/boot/dts/microchip/Makefile | 3 + .../dts/microchip/at91-sama7d65_curiosity.dts | 89 +++++++++++ arch/arm/boot/dts/microchip/sama7d65.dtsi | 145 ++++++++++++++++++ 6 files changed, 247 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts create mode 100644 arch/arm/boot/dts/microchip/sama7d65.dtsi