| Message ID | 20241217064856.2772305-1-quic_wasimn@quicinc.com |
|---|---|
| Headers | show |
| Series | arm64: qcom: Add support for QCS9075 boards | expand |
On 17/12/2024 07:48, Wasim Nazir wrote: > From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> > > Enable cpu idle injection framework and thermal cpu idle cooling device > to throttle the cpu by injecting idle cycle during high thermal condition. I know what they do, but why do we need it in the defconfig? This is not a product defconfig, just in case you mirrored downstream patches. Best regards, Krzysztof
On Tue, 17 Dec 2024 12:18:49 +0530, Wasim Nazir wrote: > This series: > > Add support for Qualcomm's rb8, ride/ride-r3 boards using QCS9075 SoC. > > QCS9075 is compatible IoT-industrial grade variant of SA8775p SoC. > Unlike QCS9100, it doesn't have safety monitoring feature of > Safety-Island(SAIL) subsystem, which affects thermal management. > > In QCS9100 SoC, the safety subsystem monitors all thermal sensors and > does corrective action for each subsystem based on sensor violation > to comply safety standards. But as QCS9075 is non-safe SoC it requires > conventional thermal mitigation for thermal management. > > Difference between Ride & ride-r3 boards is ethernet phy, > ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > This series depends on [1] for thermal functionality to work. > > [1]: https://lore.kernel.org/all/20241112-sa8775p_cpuidle-v1-1-66ff3ba72464@quicinc.com/ > > --- > Changelog: > > v4: > - Replace dts to dtsi in Ride/Ride-r3 platform files > - Add thermal patch to differentiate between 9100 vs 9075 > - Add proper abbreviation and update commit for 9100 vs 9075 > - v3: https://lore.kernel.org/all/20241119174954.1219002-1-quic_wasimn@quicinc.com/ > > v3: > - Fix RB8 board compatible string > - v2: https://lore.kernel.org/all/20241115225152.3264396-1-quic_wasimn@quicinc.com/ > > v2: > - Remove unused dp nodes & update commit for ride vs ride-r3. > - v1: https://lore.kernel.org/all/20241110145339.3635437-1-quic_wasimn@quicinc.com/ > > Manaf Meethalavalappu Pallikunhi (2): > arm64: defconfig: enable cpu idle injection and cpu idle cooling > device > arm64: dts: qcom: Enable cpu cooling devices for QCS9075 platforms > > Wasim Nazir (5): > dt-bindings: arm: qcom,ids: add SoC ID for QCS9075 > soc: qcom: socinfo: add QCS9075 SoC ID > dt-bindings: arm: qcom: Document rb8/ride/ride-r3 on QCS9075 > arm64: dts: qcom: Add support for QCS9075 RB8 > arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3 > > .../devicetree/bindings/arm/qcom.yaml | 9 + > arch/arm64/boot/dts/qcom/Makefile | 3 + > arch/arm64/boot/dts/qcom/qcs9075-rb8.dts | 282 +++++++++++++++++ > arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 47 +++ > arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 47 +++ > arch/arm64/boot/dts/qcom/qcs9075-thermal.dtsi | 287 ++++++++++++++++++ > arch/arm64/configs/defconfig | 3 + > drivers/soc/qcom/socinfo.c | 1 + > include/dt-bindings/arm/qcom,ids.h | 1 + > 9 files changed, 680 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-rb8.dts > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-thermal.dtsi > > > base-commit: 4176cf5c5651c33769de83bb61b0287f4ec7719f > -- > 2.47.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/qcs9075-rb8.dtb qcom/qcs9075-ride-r3.dtb qcom/qcs9075-ride.dtb' for 20241217064856.2772305-1-quic_wasimn@quicinc.com: arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: bluetooth: 'vddwlcx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: bluetooth: 'vddwlmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: bluetooth: 'vddrfa1p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: bluetooth: 'vddwlcx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: bluetooth: 'vddwlmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: bluetooth: 'vddrfa1p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: qcom,gpi-dma@900000: $nodename:0: 'qcom,gpi-dma@900000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: qcom,gpi-dma@900000: $nodename:0: 'qcom,gpi-dma@900000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: qcom,gpi-dma@900000: $nodename:0: 'qcom,gpi-dma@900000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: qcom,gpi-dma@a00000: $nodename:0: 'qcom,gpi-dma@a00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: qcom,gpi-dma@a00000: $nodename:0: 'qcom,gpi-dma@a00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: qcom,gpi-dma@a00000: $nodename:0: 'qcom,gpi-dma@a00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: qcom,gpi-dma@b00000: $nodename:0: 'qcom,gpi-dma@b00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: qcom,gpi-dma@b00000: $nodename:0: 'qcom,gpi-dma@b00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: qcom,gpi-dma@b00000: $nodename:0: 'qcom,gpi-dma@b00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sa8775p-qce', 'qcom,qce'] is too long ['qcom,sa8775p-qce', 'qcom,qce'] is too short 'qcom,crypto-v5.1' was expected 'qcom,crypto-v5.4' was expected 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] 'qcom,sa8775p-qce' is not one of ['qcom,ipq6018-qce', 'qcom,ipq8074-qce', 'qcom,ipq9574-qce', 'qcom,msm8996-qce', 'qcom,qcm2290-qce', 'qcom,sdm845-qce', 'qcom,sm6115-qce'] 'qcom,ipq4019-qce' was expected 'qcom,sm8150-qce' was expected from schema $id: http://devicetree.org/schemas/crypto/qcom-qce.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sa8775p-qce', 'qcom,qce'] is too long ['qcom,sa8775p-qce', 'qcom,qce'] is too short 'qcom,crypto-v5.1' was expected 'qcom,crypto-v5.4' was expected 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] 'qcom,sa8775p-qce' is not one of ['qcom,ipq6018-qce', 'qcom,ipq8074-qce', 'qcom,ipq9574-qce', 'qcom,msm8996-qce', 'qcom,qcm2290-qce', 'qcom,sdm845-qce', 'qcom,sm6115-qce'] 'qcom,ipq4019-qce' was expected 'qcom,sm8150-qce' was expected from schema $id: http://devicetree.org/schemas/crypto/qcom-qce.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sa8775p-qce', 'qcom,qce'] is too long ['qcom,sa8775p-qce', 'qcom,qce'] is too short 'qcom,crypto-v5.1' was expected 'qcom,crypto-v5.4' was expected 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] 'qcom,sa8775p-qce' is not one of ['qcom,ipq6018-qce', 'qcom,ipq8074-qce', 'qcom,ipq9574-qce', 'qcom,msm8996-qce', 'qcom,qcm2290-qce', 'qcom,sdm845-qce', 'qcom,sm6115-qce'] 'qcom,ipq4019-qce' was expected 'qcom,sm8150-qce' was expected from schema $id: http://devicetree.org/schemas/crypto/qcom-qce.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: rsc@18200000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: rsc@18200000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: rsc@18200000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: ethernet@23000000: tx-queues-config: 'snps,tx-sched-sp' does not match any of the regexes: '^queue[0-9]$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: ethernet@23000000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects', 'phy-handle', 'phy-mode', 'power-domains', 'rx-fifo-depth', 'rx-queues-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,pbl', 'snps,ps-speed', 'snps,tso', 'tx-fifo-depth', 'tx-queues-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: ethernet@23000000: tx-queues-config: 'snps,tx-sched-sp' does not match any of the regexes: '^queue[0-9]$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: ethernet@23000000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects', 'phy-handle', 'phy-mode', 'power-domains', 'rx-fifo-depth', 'rx-queues-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,pbl', 'snps,ps-speed', 'snps,tso', 'tx-fifo-depth', 'tx-queues-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: ethernet@23040000: tx-queues-config: 'snps,tx-sched-sp' does not match any of the regexes: '^queue[0-9]$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: ethernet@23040000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects', 'mdio', 'phy-handle', 'phy-mode', 'power-domains', 'rx-fifo-depth', 'rx-queues-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,pbl', 'snps,ps-speed', 'snps,tso', 'tx-fifo-depth', 'tx-queues-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: ethernet@23040000: tx-queues-config: 'snps,tx-sched-sp' does not match any of the regexes: '^queue[0-9]$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: ethernet@23040000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects', 'mdio', 'phy-handle', 'phy-mode', 'power-domains', 'rx-fifo-depth', 'rx-queues-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,pbl', 'snps,ps-speed', 'snps,tso', 'tx-fifo-depth', 'tx-queues-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: wcn6855-pmu: 'vddpmumx-supply' is a required property from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: wcn6855-pmu: 'vddpmucx-supply' is a required property from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: wcn6855-pmu: 'vddpmumx-supply' is a required property from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: wcn6855-pmu: 'vddpmucx-supply' is a required property from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml#
Hi Krzysztof, Thank you for reviewing this patch. On 12/18/2024 1:32 PM, Krzysztof Kozlowski wrote: > On 17/12/2024 07:48, Wasim Nazir wrote: >> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> >> Enable cpu idle injection framework and thermal cpu idle cooling device >> to throttle the cpu by injecting idle cycle during high thermal condition. > I know what they do, but why do we need it in the defconfig? This is not > a product defconfig, just in case you mirrored downstream patches. We believe these defconfigs serve as a generic framework rather than being tied to specific product features. Therefore, we have enabled them in the defconfig to ensure the end-to-end feature is available in the pristine upstream build. However, if you think this would introduce overhead for other products, we will exclude this patch in the next revision. Best regards, Manaf > Best regards, > Krzysztofthe
On 20/12/2024 12:38, Manaf Meethalavalappu Pallikunhi wrote: > > Hi Krzysztof, > > Thank you for reviewing this patch. > > On 12/18/2024 1:32 PM, Krzysztof Kozlowski wrote: >> On 17/12/2024 07:48, Wasim Nazir wrote: >>> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >>> >>> Enable cpu idle injection framework and thermal cpu idle cooling device >>> to throttle the cpu by injecting idle cycle during high thermal condition. >> I know what they do, but why do we need it in the defconfig? This is not >> a product defconfig, just in case you mirrored downstream patches. > > We believe these defconfigs serve as a generic framework rather than No... > being tied to specific product features. Therefore, we have enabled them They are tied to specific products. > in the defconfig to ensure the end-to-end feature is available in the > pristine upstream build. However, if you think this would introduce Why would we care about this end-to-end feature? > overhead for other products, we will exclude this patch in the next > revision. I just did not see here any explanation why this should be added. I don't need to come with extensive disagreement, because by default we do not enable everything. We enable only some things because of some reason. And that's why you have commit msg... Best regards, Krzysztof
This series: Add support for Qualcomm's rb8, ride/ride-r3 boards using QCS9075 SoC. QCS9075 is compatible IoT-industrial grade variant of SA8775p SoC. Unlike QCS9100, it doesn't have safety monitoring feature of Safety-Island(SAIL) subsystem, which affects thermal management. In QCS9100 SoC, the safety subsystem monitors all thermal sensors and does corrective action for each subsystem based on sensor violation to comply safety standards. But as QCS9075 is non-safe SoC it requires conventional thermal mitigation for thermal management. Difference between Ride & ride-r3 boards is ethernet phy, ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. This series depends on [1] for thermal functionality to work. [1]: https://lore.kernel.org/all/20241112-sa8775p_cpuidle-v1-1-66ff3ba72464@quicinc.com/ --- Changelog: v4: - Replace dts to dtsi in Ride/Ride-r3 platform files - Add thermal patch to differentiate between 9100 vs 9075 - Add proper abbreviation and update commit for 9100 vs 9075 - v3: https://lore.kernel.org/all/20241119174954.1219002-1-quic_wasimn@quicinc.com/ v3: - Fix RB8 board compatible string - v2: https://lore.kernel.org/all/20241115225152.3264396-1-quic_wasimn@quicinc.com/ v2: - Remove unused dp nodes & update commit for ride vs ride-r3. - v1: https://lore.kernel.org/all/20241110145339.3635437-1-quic_wasimn@quicinc.com/ Manaf Meethalavalappu Pallikunhi (2): arm64: defconfig: enable cpu idle injection and cpu idle cooling device arm64: dts: qcom: Enable cpu cooling devices for QCS9075 platforms Wasim Nazir (5): dt-bindings: arm: qcom,ids: add SoC ID for QCS9075 soc: qcom: socinfo: add QCS9075 SoC ID dt-bindings: arm: qcom: Document rb8/ride/ride-r3 on QCS9075 arm64: dts: qcom: Add support for QCS9075 RB8 arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3 .../devicetree/bindings/arm/qcom.yaml | 9 + arch/arm64/boot/dts/qcom/Makefile | 3 + arch/arm64/boot/dts/qcom/qcs9075-rb8.dts | 282 +++++++++++++++++ arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 47 +++ arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 47 +++ arch/arm64/boot/dts/qcom/qcs9075-thermal.dtsi | 287 ++++++++++++++++++ arch/arm64/configs/defconfig | 3 + drivers/soc/qcom/socinfo.c | 1 + include/dt-bindings/arm/qcom,ids.h | 1 + 9 files changed, 680 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-rb8.dts create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-thermal.dtsi base-commit: 4176cf5c5651c33769de83bb61b0287f4ec7719f -- 2.47.0