Message ID | 20241205-genio700-audio-output-v1-0-0e955c78c29e@collabora.com |
---|---|
Headers | show |
Series | Enable audio output for Genio 700 EVK board | expand |
Il 05/12/24 13:13, Nícolas F. R. A. Prado ha scritto: > MT6359 provides digital audio interfaces. Add a #sound-dai-cells > property for it to allow pointing to it from dai-link nodes. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 05/12/24 13:13, Nícolas F. R. A. Prado ha scritto: > Describe all the components to get sound output working on the two audio > jacks, Earphone and Speaker, present on the Genio 700 EVK board with the > audio DSP enabled. > > Co-developed-by: Aary Patil <aary.patil@mediatek.com> > Signed-off-by: Aary Patil <aary.patil@mediatek.com> > Co-developed-by: Suhrid Subramaniam <suhrid.subramaniam@mediatek.com> > Signed-off-by: Suhrid Subramaniam <suhrid.subramaniam@mediatek.com> > Co-developed-by: parkeryang <Parker.Yang@mediatek.com> > Signed-off-by: parkeryang <Parker.Yang@mediatek.com> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > .../boot/dts/mediatek/mt8390-genio-700-evk.dts | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts b/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts > index bb68665f0b2da80397b833db0241a06648a322a0..2fded39078773e81d8e0313d6b118b3064be308d 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts > @@ -92,6 +92,24 @@ vpu_mem: memory@57000000 { > compatible = "shared-dma-pool"; > reg = <0 0x57000000 0 0x1400000>; /* 20 MB */ > }; > + > + adsp_mem: memory@60000000 { > + compatible = "shared-dma-pool"; > + reg = <0 0x60000000 0 0xf00000>; > + no-map; > + }; > + > + afe_dma_mem: memory@60f00000 { > + compatible = "shared-dma-pool"; > + reg = <0 0x60f00000 0 0x100000>; > + no-map; > + }; > + > + adsp_dma_mem: memory@61000000 { > + compatible = "shared-dma-pool"; > + reg = <0 0x61000000 0 0x100000>; > + no-map; > + }; > }; > > common_fixed_5v: regulator-0 { > @@ -209,6 +227,16 @@ usb_p2_vbus: regulator-9 { > }; > }; > > +&adsp { > + memory-region = <&adsp_dma_mem>, <&adsp_mem>; > + status = "okay"; > +}; > + > +&afe { > + memory-region = <&afe_dma_mem>; > + status = "okay"; > +}; > + > &gpu { > mali-supply = <&mt6359_vproc2_buck_reg>; > status = "okay"; > @@ -912,6 +940,28 @@ &scp { > status = "okay"; > }; > > +&sound { > + compatible = "mediatek,mt8390-mt6359-evk", "mediatek,mt8188-mt6359-evb"; > + model = "mt8390-evk"; > + pinctrl-names = "default"; > + pinctrl-0 = <&audio_default_pins>; > + audio-routing = > + "Headphone", "Headphone L", > + "Headphone", "Headphone R"; > + mediatek,adsp = <&adsp>; > + mediatek,dai-link = "DL_SRC_BE", "UL_SRC_BE", "AFE_SOF_DL2", > + "AFE_SOF_DL3", "AFE_SOF_UL4", "AFE_SOF_UL5"; Are you really, really, really, extremely sure that you need mediatek,dai-link? I say you don't... :-) Cheers, Angelo
On Thu, 05 Dec 2024 09:13:53 -0300, Nícolas F. R. A. Prado wrote: > This series enables audio output support for the Genio 700 EVK board. > Patches 1-4 do the required binding and DT changes, and patch 5 > describes the audio DT nodes to get audio output working on the two > audio jacks, Earphone and Speaker, present on the board. > > The standalone fix in [1] is required in addition to this series in > order to get the sound card probing. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [2/5] ASoC: dt-bindings: mediatek,mt8188-mt6359: Add compatible for mt8390 evk commit: 8e22ea5fb8498c52fcc20bbe2070c3aef1a3dff2 [4/5] ASoC: dt-bindings: mediatek,mt8188-mt6359: Allow DL_SRC/UL_SRC dai-links commit: 5a56323a54b7febcfe82cc5eda840a176647b7cd All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
This series enables audio output support for the Genio 700 EVK board. Patches 1-4 do the required binding and DT changes, and patch 5 describes the audio DT nodes to get audio output working on the two audio jacks, Earphone and Speaker, present on the board. The standalone fix in [1] is required in addition to this series in order to get the sound card probing. [1] https://lore.kernel.org/all/20241203-mt8188-6359-unhardcode-dmic-v1-1-346e3e5cbe6d@collabora.com Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Nícolas F. R. A. Prado (5): arm64: dts: mt6359: Add #sound-dai-cells property ASoC: dt-bindings: mediatek,mt8188-mt6359: Add compatible for mt8390 evk ASoC: dt-bindings: mediatek,mt8188-mt6359: Add DSP properties ASoC: dt-bindings: mediatek,mt8188-mt6359: Allow DL_SRC/UL_SRC dai-links arm64: dts: mediatek: mt8390-genio-700-evk: Add sound output support .../bindings/sound/mediatek,mt8188-mt6359.yaml | 26 ++++++++--- arch/arm64/boot/dts/mediatek/mt6359.dtsi | 1 + .../boot/dts/mediatek/mt8390-genio-700-evk.dts | 50 ++++++++++++++++++++++ 3 files changed, 72 insertions(+), 5 deletions(-) --- base-commit: b852e1e7a0389ed6168ef1d38eb0bad71a6b11e8 change-id: 20241204-genio700-audio-output-fba8f2ebad10 Best regards,