| Message ID | 20241119174954.1219002-1-quic_wasimn@quicinc.com |
|---|---|
| Headers | show |
| Series | arm64: qcom: Add support for QCS9075 boards | expand |
On Tue, Nov 19, 2024 at 11:19:53PM +0530, Wasim Nazir wrote: > Add initial device tree support for the RB8 board > based on Qualcomm's QCS9075. > > Basic changes are supported for boot to shell. > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/qcs9075-rb8.dts | 281 +++++++++++++++++++++++ > 2 files changed, 282 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-rb8.dts > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Tue, Nov 19, 2024 at 11:19:54PM +0530, Wasim Nazir wrote: > Add device tree support for QCS9075 Ride & Ride-r3 boards. > QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > boards but without safety monitoring feature of SAfety-IsLand > subsystem. > > Difference between ride and ride-r3 is the ethernet phy. > Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > --- Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Tue, 19 Nov 2024 23:19:49 +0530, Wasim Nazir wrote: > This series: > > Add support for Qualcomm's rb8, ride/ride-r3 boards using QCS9075 SoC. > > QCS9075 is compatible IoT-industrial grade variant of SA8775p SoC > without safety monitorng feature of SAfetyIsLand subsystem. > This subsystem continues to supports other features like built-in > self-test, error-detection, reset-handling, etc. > > Changelog: > > v2: > - Remove unused dp nodes & update commit for ride vs ride-r3. > > v1: https://lore.kernel.org/all/20241110145339.3635437-1-quic_wasimn@quicinc.com/ > > Wasim Nazir (5): > dt-bindings: arm: qcom,ids: add SoC ID for QCS9075 > soc: qcom: socinfo: add QCS9075 SoC ID > dt-bindings: arm: qcom: Document rb8/ride/ride-r3 on QCS9075 > arm64: dts: qcom: Add support for QCS9075 RB8 > arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3 > > .../devicetree/bindings/arm/qcom.yaml | 9 + > arch/arm64/boot/dts/qcom/Makefile | 3 + > arch/arm64/boot/dts/qcom/qcs9075-rb8.dts | 281 ++++++++++++++++++ > arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 + > arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 + > drivers/soc/qcom/socinfo.c | 1 + > include/dt-bindings/arm/qcom,ids.h | 1 + > 7 files changed, 319 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-rb8.dts > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > > base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a > -- > 2.47.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/qcs9075-rb8.dtb qcom/qcs9075-ride-r3.dtb qcom/qcs9075-ride.dtb' for 20241119174954.1219002-1-quic_wasimn@quicinc.com: arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: bluetooth: 'vddwlcx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: bluetooth: 'vddwlmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: bluetooth: 'vddrfa1p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: bluetooth: 'vddwlcx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: bluetooth: 'vddwlmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: bluetooth: 'vddrfa1p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: qcom,gpi-dma@900000: $nodename:0: 'qcom,gpi-dma@900000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: qcom,gpi-dma@900000: $nodename:0: 'qcom,gpi-dma@900000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: qcom,gpi-dma@900000: $nodename:0: 'qcom,gpi-dma@900000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: qcom,gpi-dma@a00000: $nodename:0: 'qcom,gpi-dma@a00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: qcom,gpi-dma@a00000: $nodename:0: 'qcom,gpi-dma@a00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: qcom,gpi-dma@a00000: $nodename:0: 'qcom,gpi-dma@a00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: qcom,gpi-dma@b00000: $nodename:0: 'qcom,gpi-dma@b00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: qcom,gpi-dma@b00000: $nodename:0: 'qcom,gpi-dma@b00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: qcom,gpi-dma@b00000: $nodename:0: 'qcom,gpi-dma@b00000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sa8775p-qce', 'qcom,qce'] is too long ['qcom,sa8775p-qce', 'qcom,qce'] is too short 'qcom,crypto-v5.1' was expected 'qcom,crypto-v5.4' was expected 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] 'qcom,sa8775p-qce' is not one of ['qcom,ipq6018-qce', 'qcom,ipq8074-qce', 'qcom,ipq9574-qce', 'qcom,msm8996-qce', 'qcom,qcm2290-qce', 'qcom,sdm845-qce', 'qcom,sm6115-qce'] 'qcom,ipq4019-qce' was expected 'qcom,sm8150-qce' was expected from schema $id: http://devicetree.org/schemas/crypto/qcom-qce.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sa8775p-qce', 'qcom,qce'] is too long ['qcom,sa8775p-qce', 'qcom,qce'] is too short 'qcom,crypto-v5.1' was expected 'qcom,crypto-v5.4' was expected 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] 'qcom,sa8775p-qce' is not one of ['qcom,ipq6018-qce', 'qcom,ipq8074-qce', 'qcom,ipq9574-qce', 'qcom,msm8996-qce', 'qcom,qcm2290-qce', 'qcom,sdm845-qce', 'qcom,sm6115-qce'] 'qcom,ipq4019-qce' was expected 'qcom,sm8150-qce' was expected from schema $id: http://devicetree.org/schemas/crypto/qcom-qce.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sa8775p-qce', 'qcom,qce'] is too long ['qcom,sa8775p-qce', 'qcom,qce'] is too short 'qcom,crypto-v5.1' was expected 'qcom,crypto-v5.4' was expected 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] 'qcom,sa8775p-qce' is not one of ['qcom,ipq6018-qce', 'qcom,ipq8074-qce', 'qcom,ipq9574-qce', 'qcom,msm8996-qce', 'qcom,qcm2290-qce', 'qcom,sdm845-qce', 'qcom,sm6115-qce'] 'qcom,ipq4019-qce' was expected 'qcom,sm8150-qce' was expected from schema $id: http://devicetree.org/schemas/crypto/qcom-qce.yaml# arch/arm64/boot/dts/qcom/qcs9075-rb8.dtb: rsc@18200000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: rsc@18200000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: rsc@18200000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: ethernet@23000000: tx-queues-config: 'snps,tx-sched-sp' does not match any of the regexes: '^queue[0-9]$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: ethernet@23000000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects', 'phy-handle', 'phy-mode', 'power-domains', 'rx-fifo-depth', 'rx-queues-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,pbl', 'snps,ps-speed', 'snps,tso', 'tx-fifo-depth', 'tx-queues-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: ethernet@23040000: tx-queues-config: 'snps,tx-sched-sp' does not match any of the regexes: '^queue[0-9]$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: ethernet@23040000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects', 'mdio', 'phy-handle', 'phy-mode', 'power-domains', 'rx-fifo-depth', 'rx-queues-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,pbl', 'snps,ps-speed', 'snps,tso', 'tx-fifo-depth', 'tx-queues-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: ethernet@23000000: tx-queues-config: 'snps,tx-sched-sp' does not match any of the regexes: '^queue[0-9]$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: ethernet@23000000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects', 'phy-handle', 'phy-mode', 'power-domains', 'rx-fifo-depth', 'rx-queues-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,pbl', 'snps,ps-speed', 'snps,tso', 'tx-fifo-depth', 'tx-queues-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: ethernet@23040000: tx-queues-config: 'snps,tx-sched-sp' does not match any of the regexes: '^queue[0-9]$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: ethernet@23040000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects', 'mdio', 'phy-handle', 'phy-mode', 'power-domains', 'rx-fifo-depth', 'rx-queues-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,pbl', 'snps,ps-speed', 'snps,tso', 'tx-fifo-depth', 'tx-queues-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: wcn6855-pmu: 'vddpmumx-supply' is a required property from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dtb: wcn6855-pmu: 'vddpmucx-supply' is a required property from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: wcn6855-pmu: 'vddpmumx-supply' is a required property from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml# arch/arm64/boot/dts/qcom/qcs9075-ride.dtb: wcn6855-pmu: 'vddpmucx-supply' is a required property from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml#
On 19/11/2024 18:49, Wasim Nazir wrote: > This series: > > Add support for Qualcomm's rb8, ride/ride-r3 boards using QCS9075 SoC. > > QCS9075 is compatible IoT-industrial grade variant of SA8775p SoC How does it relate to qcs9100? Why this is not compatible with the other? It looks like you duplicate here a lot without trying to make these built on top of each other. Best regards, Krzysztof
On 19/11/2024 18:49, Wasim Nazir wrote: > Add device tree support for QCS9075 Ride & Ride-r3 boards. > QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > boards but without safety monitoring feature of SAfety-IsLand > subsystem. > > Difference between ride and ride-r3 is the ethernet phy. > Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 2 ++ > arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ > arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ > 3 files changed, 26 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 5d9847119f2e..91c811aca2ca 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > new file mode 100644 > index 000000000000..a04c8d1fa258 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > +/dts-v1/; > + > +#include "sa8775p-ride-r3.dts" No guys, you are making these things up. This is EXACTLY the same as qcs9100. NAK Best regards, Krzysztof
On Wed, Nov 20, 2024 at 05:41:39PM +0100, Krzysztof Kozlowski wrote: > On 19/11/2024 18:49, Wasim Nazir wrote: > > This series: > > > > Add support for Qualcomm's rb8, ride/ride-r3 boards using QCS9075 SoC. > > > > QCS9075 is compatible IoT-industrial grade variant of SA8775p SoC > How does it relate to qcs9100? Why this is not compatible with the > other? It looks like you duplicate here a lot without trying to make > these built on top of each other. > QCS9075 is non-safe while QCS9100 is safe. Reference: https://docs.qualcomm.com/bundle/publicresource/87-83840-1_REV_A_Qualcomm_IQ9_Series_Product_Brief.pdf Separate board files are needed as thermal mitigation changes are required for non-safe variant only. > Best regards, > Krzysztof Thanks & Regards, Wasim
On Wed, Nov 20, 2024 at 05:44:11PM +0100, Krzysztof Kozlowski wrote: > On 19/11/2024 18:49, Wasim Nazir wrote: > > Add device tree support for QCS9075 Ride & Ride-r3 boards. > > QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > > boards but without safety monitoring feature of SAfety-IsLand > > subsystem. > > > > Difference between ride and ride-r3 is the ethernet phy. > > Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/Makefile | 2 ++ > > arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ > > arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ > > 3 files changed, 26 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > index 5d9847119f2e..91c811aca2ca 100644 > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > new file mode 100644 > > index 000000000000..a04c8d1fa258 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > @@ -0,0 +1,12 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > > + */ > > +/dts-v1/; > > + > > +#include "sa8775p-ride-r3.dts" > No guys, you are making these things up. This is EXACTLY the same as > qcs9100. 9100 & 9075 are different from “safe” perspective. They differ in changes related to thermal which will be added later in devicetree. > > NAK > > > > Best regards, > Krzysztof Thanks & Regards, Wasim
On 6.12.2024 12:04 PM, Wasim Nazir wrote: > On Wed, Nov 20, 2024 at 05:44:11PM +0100, Krzysztof Kozlowski wrote: >> On 19/11/2024 18:49, Wasim Nazir wrote: >>> Add device tree support for QCS9075 Ride & Ride-r3 boards. >>> QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 >>> boards but without safety monitoring feature of SAfety-IsLand >>> subsystem. >>> >>> Difference between ride and ride-r3 is the ethernet phy. >>> Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. >>> >>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 2 ++ >>> arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ >>> arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ >>> 3 files changed, 26 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index 5d9847119f2e..91c811aca2ca 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>> new file mode 100644 >>> index 000000000000..a04c8d1fa258 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>> @@ -0,0 +1,12 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> +/dts-v1/; >>> + >>> +#include "sa8775p-ride-r3.dts" >> No guys, you are making these things up. This is EXACTLY the same as >> qcs9100. > > 9100 & 9075 are different from “safe” perspective. They differ in > changes related to thermal which will be added later in devicetree. Since this can't be inferred from just looking at the changes, please make sure to add that to the commit message Konrad
On 06/12/2024 13:14, Konrad Dybcio wrote: >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>>> new file mode 100644 >>>> index 000000000000..a04c8d1fa258 >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>>> @@ -0,0 +1,12 @@ >>>> +// SPDX-License-Identifier: BSD-3-Clause >>>> +/* >>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. >>>> + */ >>>> +/dts-v1/; >>>> + >>>> +#include "sa8775p-ride-r3.dts" >>> No guys, you are making these things up. This is EXACTLY the same as >>> qcs9100. >> >> 9100 & 9075 are different from “safe” perspective. They differ in >> changes related to thermal which will be added later in devicetree. > > Since this can't be inferred from just looking at the changes, please > make sure to add that to the commit message Any include of other DTS is clear sign something is odd here. Including multiple times without any added nodes is showing these are not real products/boards . Best regards, Krzysztof
On Fri, Dec 06, 2024 at 04:13:45PM +0530, Wasim Nazir wrote: > On Wed, Nov 20, 2024 at 05:41:39PM +0100, Krzysztof Kozlowski wrote: > > On 19/11/2024 18:49, Wasim Nazir wrote: > > > This series: > > > > > > Add support for Qualcomm's rb8, ride/ride-r3 boards using QCS9075 SoC. > > > > > > QCS9075 is compatible IoT-industrial grade variant of SA8775p SoC > > How does it relate to qcs9100? Why this is not compatible with the > > other? It looks like you duplicate here a lot without trying to make > > these built on top of each other. > > > > QCS9075 is non-safe while QCS9100 is safe. > Reference: https://docs.qualcomm.com/bundle/publicresource/87-83840-1_REV_A_Qualcomm_IQ9_Series_Product_Brief.pdf > > Separate board files are needed as thermal mitigation changes are > required for non-safe variant only. To reduce possible questions, please include those in the initial submission.
On Sun, Dec 08, 2024 at 07:46:55PM +0200, Dmitry Baryshkov wrote: > On Fri, Dec 06, 2024 at 04:13:45PM +0530, Wasim Nazir wrote: > > On Wed, Nov 20, 2024 at 05:41:39PM +0100, Krzysztof Kozlowski wrote: > > > On 19/11/2024 18:49, Wasim Nazir wrote: > > > > This series: > > > > > > > > Add support for Qualcomm's rb8, ride/ride-r3 boards using QCS9075 SoC. > > > > > > > > QCS9075 is compatible IoT-industrial grade variant of SA8775p SoC > > > How does it relate to qcs9100? Why this is not compatible with the > > > other? It looks like you duplicate here a lot without trying to make > > > these built on top of each other. > > > > > > > QCS9075 is non-safe while QCS9100 is safe. > > Reference: https://docs.qualcomm.com/bundle/publicresource/87-83840-1_REV_A_Qualcomm_IQ9_Series_Product_Brief.pdf > > > > Separate board files are needed as thermal mitigation changes are > > required for non-safe variant only. > > To reduce possible questions, please include those in the initial > submission. > Sure, will add the differences in next patch version. > -- > With best wishes > Dmitry Thanks & Regards, Wasim
On Fri, Dec 06, 2024 at 01:14:26PM +0100, Konrad Dybcio wrote: > On 6.12.2024 12:04 PM, Wasim Nazir wrote: > > On Wed, Nov 20, 2024 at 05:44:11PM +0100, Krzysztof Kozlowski wrote: > >> On 19/11/2024 18:49, Wasim Nazir wrote: > >>> Add device tree support for QCS9075 Ride & Ride-r3 boards. > >>> QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > >>> boards but without safety monitoring feature of SAfety-IsLand > >>> subsystem. > >>> > >>> Difference between ride and ride-r3 is the ethernet phy. > >>> Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > >>> > >>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > >>> --- > >>> arch/arm64/boot/dts/qcom/Makefile | 2 ++ > >>> arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ > >>> arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ > >>> 3 files changed, 26 insertions(+) > >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > >>> > >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > >>> index 5d9847119f2e..91c811aca2ca 100644 > >>> --- a/arch/arm64/boot/dts/qcom/Makefile > >>> +++ b/arch/arm64/boot/dts/qcom/Makefile > >>> @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > >>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> new file mode 100644 > >>> index 000000000000..a04c8d1fa258 > >>> --- /dev/null > >>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> @@ -0,0 +1,12 @@ > >>> +// SPDX-License-Identifier: BSD-3-Clause > >>> +/* > >>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > >>> + */ > >>> +/dts-v1/; > >>> + > >>> +#include "sa8775p-ride-r3.dts" > >> No guys, you are making these things up. This is EXACTLY the same as > >> qcs9100. > > > > 9100 & 9075 are different from “safe” perspective. They differ in > > changes related to thermal which will be added later in devicetree. > > Since this can't be inferred from just looking at the changes, please > make sure to add that to the commit message > Sure, will add more details in next patch series. > Konrad Thanks & Regards, Wasim
On Fri, Dec 06, 2024 at 01:49:51PM +0100, Krzysztof Kozlowski wrote: > On 06/12/2024 13:14, Konrad Dybcio wrote: > >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>> new file mode 100644 > >>>> index 000000000000..a04c8d1fa258 > >>>> --- /dev/null > >>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>> @@ -0,0 +1,12 @@ > >>>> +// SPDX-License-Identifier: BSD-3-Clause > >>>> +/* > >>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > >>>> + */ > >>>> +/dts-v1/; > >>>> + > >>>> +#include "sa8775p-ride-r3.dts" > >>> No guys, you are making these things up. This is EXACTLY the same as > >>> qcs9100. > >> > >> 9100 & 9075 are different from “safe” perspective. They differ in > >> changes related to thermal which will be added later in devicetree. > > > > Since this can't be inferred from just looking at the changes, please > > make sure to add that to the commit message > > Any include of other DTS is clear sign something is odd here. Including > multiple times without any added nodes is showing these are not real > products/boards . We're adding DTS to reuse the common board changes, with plans to include the differences in upcoming patches. To provide more clarity, I will include patches in this series to highlight the differences between the 9100 and 9075 boards. > Best regards, > Krzysztof Thanks & Regards, Wasim
On 09/12/2024 19:58, Wasim Nazir wrote: > On Fri, Dec 06, 2024 at 01:49:51PM +0100, Krzysztof Kozlowski wrote: >> On 06/12/2024 13:14, Konrad Dybcio wrote: >>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>>>>> new file mode 100644 >>>>>> index 000000000000..a04c8d1fa258 >>>>>> --- /dev/null >>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts >>>>>> @@ -0,0 +1,12 @@ >>>>>> +// SPDX-License-Identifier: BSD-3-Clause >>>>>> +/* >>>>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. >>>>>> + */ >>>>>> +/dts-v1/; >>>>>> + >>>>>> +#include "sa8775p-ride-r3.dts" >>>>> No guys, you are making these things up. This is EXACTLY the same as >>>>> qcs9100. >>>> >>>> 9100 & 9075 are different from “safe” perspective. They differ in >>>> changes related to thermal which will be added later in devicetree. >>> >>> Since this can't be inferred from just looking at the changes, please >>> make sure to add that to the commit message >> >> Any include of other DTS is clear sign something is odd here. Including >> multiple times without any added nodes is showing these are not real >> products/boards . > > We're adding DTS to reuse the common board changes, with plans to > include the differences in upcoming patches. To provide more clarity, I > will include patches in this series to highlight the differences between > the 9100 and 9075 boards. Sure, still do not include DTS. Just like C files don't include C files. Best regards, Krzysztof
On Mon, Dec 09, 2024 at 08:30:07PM +0100, Krzysztof Kozlowski wrote: > On 09/12/2024 19:58, Wasim Nazir wrote: > > On Fri, Dec 06, 2024 at 01:49:51PM +0100, Krzysztof Kozlowski wrote: > >> On 06/12/2024 13:14, Konrad Dybcio wrote: > >>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>>>> new file mode 100644 > >>>>>> index 000000000000..a04c8d1fa258 > >>>>>> --- /dev/null > >>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>>>>> @@ -0,0 +1,12 @@ > >>>>>> +// SPDX-License-Identifier: BSD-3-Clause > >>>>>> +/* > >>>>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > >>>>>> + */ > >>>>>> +/dts-v1/; > >>>>>> + > >>>>>> +#include "sa8775p-ride-r3.dts" > >>>>> No guys, you are making these things up. This is EXACTLY the same as > >>>>> qcs9100. > >>>> > >>>> 9100 & 9075 are different from “safe” perspective. They differ in > >>>> changes related to thermal which will be added later in devicetree. > >>> > >>> Since this can't be inferred from just looking at the changes, please > >>> make sure to add that to the commit message > >> > >> Any include of other DTS is clear sign something is odd here. Including > >> multiple times without any added nodes is showing these are not real > >> products/boards . > > > > We're adding DTS to reuse the common board changes, with plans to > > include the differences in upcoming patches. To provide more clarity, I > > will include patches in this series to highlight the differences between > > the 9100 and 9075 boards. > > Sure, still do not include DTS. Just like C files don't include C files. So, is the solution simple, rename .dts to .dtsi and include it from both .dts files?
On 10/12/2024 00:25, Dmitry Baryshkov wrote: >>>>>> 9100 & 9075 are different from “safe” perspective. They differ in >>>>>> changes related to thermal which will be added later in devicetree. >>>>> >>>>> Since this can't be inferred from just looking at the changes, please >>>>> make sure to add that to the commit message >>>> >>>> Any include of other DTS is clear sign something is odd here. Including >>>> multiple times without any added nodes is showing these are not real >>>> products/boards . >>> >>> We're adding DTS to reuse the common board changes, with plans to >>> include the differences in upcoming patches. To provide more clarity, I >>> will include patches in this series to highlight the differences between >>> the 9100 and 9075 boards. >> >> Sure, still do not include DTS. Just like C files don't include C files. > > So, is the solution simple, rename .dts to .dtsi and include it from > both .dts files? For example. This leads to more questions - what is common here? We do not create shared DTSI files just because someone wants, but to really note shared components or shared designs. Best regards, Krzysztof
On Tue, Dec 10, 2024 at 08:25:34AM +0100, Krzysztof Kozlowski wrote: > On 10/12/2024 00:25, Dmitry Baryshkov wrote: > >>>>>> 9100 & 9075 are different from “safe” perspective. They differ in > >>>>>> changes related to thermal which will be added later in devicetree. > >>>>> > >>>>> Since this can't be inferred from just looking at the changes, please > >>>>> make sure to add that to the commit message > >>>> > >>>> Any include of other DTS is clear sign something is odd here. Including > >>>> multiple times without any added nodes is showing these are not real > >>>> products/boards . > >>> > >>> We're adding DTS to reuse the common board changes, with plans to > >>> include the differences in upcoming patches. To provide more clarity, I > >>> will include patches in this series to highlight the differences between > >>> the 9100 and 9075 boards. > >> > >> Sure, still do not include DTS. Just like C files don't include C files. > > > > So, is the solution simple, rename .dts to .dtsi and include it from > > both .dts files? > > For example. This leads to more questions - what is common here? We do > not create shared DTSI files just because someone wants, but to really > note shared components or shared designs. > We can reuse the common dtsi for ride boards, i.e., sa8775p-ride.dtsi, and then add board-specific changes in the corresponding files. If this approach is acceptable, I can proceed with sending the next patch series. I hope this will help clarify things further. > Best regards, > Krzysztof Thanks & Regards, Wasim
On 10/12/2024 10:24, Wasim Nazir wrote: > On Tue, Dec 10, 2024 at 08:25:34AM +0100, Krzysztof Kozlowski wrote: >> On 10/12/2024 00:25, Dmitry Baryshkov wrote: >>>>>>>> 9100 & 9075 are different from “safe” perspective. They differ in >>>>>>>> changes related to thermal which will be added later in devicetree. >>>>>>> >>>>>>> Since this can't be inferred from just looking at the changes, please >>>>>>> make sure to add that to the commit message >>>>>> >>>>>> Any include of other DTS is clear sign something is odd here. Including >>>>>> multiple times without any added nodes is showing these are not real >>>>>> products/boards . >>>>> >>>>> We're adding DTS to reuse the common board changes, with plans to >>>>> include the differences in upcoming patches. To provide more clarity, I >>>>> will include patches in this series to highlight the differences between >>>>> the 9100 and 9075 boards. >>>> >>>> Sure, still do not include DTS. Just like C files don't include C files. >>> >>> So, is the solution simple, rename .dts to .dtsi and include it from >>> both .dts files? >> >> For example. This leads to more questions - what is common here? We do >> not create shared DTSI files just because someone wants, but to really >> note shared components or shared designs. >> > > We can reuse the common dtsi for ride boards, i.e., sa8775p-ride.dtsi, > and then add board-specific changes in the corresponding files. So you will create shared DTSI because "someone wants"? Did you read the question above and valid reasons/answers to it? > > If this approach is acceptable, I can proceed with sending the > next patch series. I hope this will help clarify things further. Best regards, Krzysztof
On Tue, Dec 10, 2024 at 12:50:51PM +0100, Krzysztof Kozlowski wrote: > On 10/12/2024 10:24, Wasim Nazir wrote: > > On Tue, Dec 10, 2024 at 08:25:34AM +0100, Krzysztof Kozlowski wrote: > >> On 10/12/2024 00:25, Dmitry Baryshkov wrote: > >>>>>>>> 9100 & 9075 are different from “safe” perspective. They differ in > >>>>>>>> changes related to thermal which will be added later in devicetree. > >>>>>>> > >>>>>>> Since this can't be inferred from just looking at the changes, please > >>>>>>> make sure to add that to the commit message > >>>>>> > >>>>>> Any include of other DTS is clear sign something is odd here. Including > >>>>>> multiple times without any added nodes is showing these are not real > >>>>>> products/boards . > >>>>> > >>>>> We're adding DTS to reuse the common board changes, with plans to > >>>>> include the differences in upcoming patches. To provide more clarity, I > >>>>> will include patches in this series to highlight the differences between > >>>>> the 9100 and 9075 boards. > >>>> > >>>> Sure, still do not include DTS. Just like C files don't include C files. > >>> > >>> So, is the solution simple, rename .dts to .dtsi and include it from > >>> both .dts files? > >> > >> For example. This leads to more questions - what is common here? We do > >> not create shared DTSI files just because someone wants, but to really > >> note shared components or shared designs. > >> > > > > We can reuse the common dtsi for ride boards, i.e., sa8775p-ride.dtsi, > > and then add board-specific changes in the corresponding files. > > > So you will create shared DTSI because "someone wants"? Did you read the > question above and valid reasons/answers to it? > Sorry, if I couldn't able to answer your question. We will not be creating any new DTSI files. Since QCS9075 is derived from SA8775P, we will be reusing the existing common DTSI files for the ride boards of the SA8775P and its derivative SoCs. Here is the change reference for common ride dtsi: https://lore.kernel.org/all/20240627114212.25400-3-brgl@bgdev.pl/ Please let me know if I missed anything. > > > > > If this approach is acceptable, I can proceed with sending the > > next patch series. I hope this will help clarify things further. > > Best regards, > Krzysztof Thanks & Regards, Wasim
On 19.11.2024 6:49 PM, Wasim Nazir wrote: > Add initial device tree support for the RB8 board > based on Qualcomm's QCS9075. > > Basic changes are supported for boot to shell. > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad