| Message ID | 20241122-psplash_options-v1-1-b142ac91f53c@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | package/psplash: add support for two configure options | expand |
Bringing this back up. Could we consider this simple patch? On 11/22/24 19:21, Olivier Benjamin via buildroot wrote: > Add support for two configure options: > --disable-progress-bar, via BR2_PACKAGE_PSPLAH_PROGRESS_BAR > --disable-startup-msg, via BR2_PACKAGE_PSPLASH_STARTUP_MSG > > Both buildroot options will default to 'y' to be compatible with > the previous behaviour, since those were enable by default by > not specifying the disable config flag. > > Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> > --- > package/psplash/Config.in | 12 ++++++++++++ > package/psplash/psplash.mk | 12 ++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/package/psplash/Config.in b/package/psplash/Config.in > index da99b264e0458766f3c5840568acd7980d0ef313..6379c5537fa18612a3dda862995a9f9a857da121 100644 > --- a/package/psplash/Config.in > +++ b/package/psplash/Config.in > @@ -35,6 +35,18 @@ config BR2_PACKAGE_PSPLASH_IMAGE > Use a personalized png image as boot splash. > Let it empty if you want to keep the psplash default image. > > +config BR2_PACKAGE_PSPLASH_PROGRESS_BAR > + bool "enable progress bar" > + default y > + help > + Enable management of the progress bar via the "PROGRESS" command. > + > +config BR2_PACKAGE_PSPLASH_STARTUP_MSG > + bool "enable startup message" > + default y > + help > + Enable text banner output on startup. > + > endif > > comment "psplash needs a toolchain w/ wchar" > diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk > index 69f9bf386da0a6b3463a30b7b8a7b09ad9017819..f13f92d5875775aff0eafa8a4f11dc6c68bd0ce4 100644 > --- a/package/psplash/psplash.mk > +++ b/package/psplash/psplash.mk > @@ -19,6 +19,18 @@ else > PSPLASH_CONF_OPTS += --without-systemd > endif > > +ifeq ($(BR2_PACKAGE_PSPLASH_PROGRESS_BAR), y) > +PSPLASH_CONF_OPTS += > +else > +PSPLASH_CONF_OPTS += --disable-progress-bar > +endif > + > +ifeq ($(BR2_PACKAGE_PSPLASH_STARTUP_MSG), y) > +PSPLASH_CONF_OPTS += > +else > +PSPLASH_CONF_OPTS += --disable-startup-msg > +endif > + > PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE)) > > ifneq ($(PSPLASH_IMAGE),) > > --- > base-commit: 175dbdf3fc67775486ddf121b6deb651e2bf7c06 > change-id: 20241122-psplash_options-f8ef9770390d > > Best regards,
diff --git a/package/psplash/Config.in b/package/psplash/Config.in index da99b264e0458766f3c5840568acd7980d0ef313..6379c5537fa18612a3dda862995a9f9a857da121 100644 --- a/package/psplash/Config.in +++ b/package/psplash/Config.in @@ -35,6 +35,18 @@ config BR2_PACKAGE_PSPLASH_IMAGE Use a personalized png image as boot splash. Let it empty if you want to keep the psplash default image. +config BR2_PACKAGE_PSPLASH_PROGRESS_BAR + bool "enable progress bar" + default y + help + Enable management of the progress bar via the "PROGRESS" command. + +config BR2_PACKAGE_PSPLASH_STARTUP_MSG + bool "enable startup message" + default y + help + Enable text banner output on startup. + endif comment "psplash needs a toolchain w/ wchar" diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk index 69f9bf386da0a6b3463a30b7b8a7b09ad9017819..f13f92d5875775aff0eafa8a4f11dc6c68bd0ce4 100644 --- a/package/psplash/psplash.mk +++ b/package/psplash/psplash.mk @@ -19,6 +19,18 @@ else PSPLASH_CONF_OPTS += --without-systemd endif +ifeq ($(BR2_PACKAGE_PSPLASH_PROGRESS_BAR), y) +PSPLASH_CONF_OPTS += +else +PSPLASH_CONF_OPTS += --disable-progress-bar +endif + +ifeq ($(BR2_PACKAGE_PSPLASH_STARTUP_MSG), y) +PSPLASH_CONF_OPTS += +else +PSPLASH_CONF_OPTS += --disable-startup-msg +endif + PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE)) ifneq ($(PSPLASH_IMAGE),)
Add support for two configure options: --disable-progress-bar, via BR2_PACKAGE_PSPLAH_PROGRESS_BAR --disable-startup-msg, via BR2_PACKAGE_PSPLASH_STARTUP_MSG Both buildroot options will default to 'y' to be compatible with the previous behaviour, since those were enable by default by not specifying the disable config flag. Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> --- package/psplash/Config.in | 12 ++++++++++++ package/psplash/psplash.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+) --- base-commit: 175dbdf3fc67775486ddf121b6deb651e2bf7c06 change-id: 20241122-psplash_options-f8ef9770390d Best regards,