| Message ID | 20241118232420.3166108-1-ju.o@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/skopeo: select BR2_PACKAGE_HOST_GO | expand |
Julien, All, On 2024-11-19 00:24 +0100, Julien Olivain spake thusly: > host-skopeo fail to build, using the commands: > > echo BR2_PACKAGE_HOST_SKOPEO=y >.config > make olddefconfig > make host-skopeo > > This commit fixes the issue by selecting BR2_PACKAGE_HOST_GO > in the Config.in file. > > Fixes: > > make: *** No rule to make target 'host-', needed by '/buildroot/output/build/host-go-1.23.2/.stamp_configured'. Stop. For host-skopeo, that indeed fixes the issue, but there is still the case that prompt-less host package written in go are still broken in the same way. I have already sent a related patch to fix that issue: https://patchwork.ozlabs.org/project/buildroot/patch/cf517426f7868af6c3e80e5016ac23759bf75290.1726556733.git.yann.morin@orange.com/ Of course, I did not notice the issue your patch is fixing, because I had that patch of mine above already applied, sorry for the mess... > Signed-off-by: Julien Olivain <ju.o@free.fr> This select was missing in my initila host-skopeo submission,m because it was made before 7b2a164b7460 (package/go/go-bin: new host-go provider) was applied, when it was not needed to select the host-go package. Reviewed-by: Yann E. MORIN <yann.morin@orange.com> Regards, Yann E. MORIN. > --- > package/skopeo/Config.in.host | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/skopeo/Config.in.host b/package/skopeo/Config.in.host > index 334a12b6fc..1c1c8f3ebe 100644 > --- a/package/skopeo/Config.in.host > +++ b/package/skopeo/Config.in.host > @@ -2,6 +2,7 @@ config BR2_PACKAGE_HOST_SKOPEO > bool "host skopeo" > depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS > depends on BR2_PACKAGE_HOST_GO_HOST_CGO_LINKING_SUPPORTS > + select BR2_PACKAGE_HOST_GO > help > skopeo is a command line utility that performs various > operations on container images and image repositories. > -- > 2.47.0 >
Hi Yann, On 19/11/2024 06:35, yann.morin@orange.com wrote: > Julien, All, > > On 2024-11-19 00:24 +0100, Julien Olivain spake thusly: >> host-skopeo fail to build, using the commands: >> >> echo BR2_PACKAGE_HOST_SKOPEO=y >.config >> make olddefconfig >> make host-skopeo >> >> This commit fixes the issue by selecting BR2_PACKAGE_HOST_GO >> in the Config.in file. >> >> Fixes: >> >> make: *** No rule to make target 'host-', needed by >> '/buildroot/output/build/host-go-1.23.2/.stamp_configured'. Stop. > > For host-skopeo, that indeed fixes the issue, but there is still the > case that prompt-less host package written in go are still broken in > the > same way. > > I have already sent a related patch to fix that issue: > > https://patchwork.ozlabs.org/project/buildroot/patch/cf517426f7868af6c3e80e5016ac23759bf75290.1726556733.git.yann.morin@orange.com/ > > Of course, I did not notice the issue your patch is fixing, because I > had that patch of mine above already applied, sorry for the mess... Thanks for the clarification, I'll have a look to this other fix. >> Signed-off-by: Julien Olivain <ju.o@free.fr> > > This select was missing in my initila host-skopeo submission,m because > it was made before 7b2a164b7460 (package/go/go-bin: new host-go > provider) was applied, when it was not needed to select the host-go > package. > > Reviewed-by: Yann E. MORIN <yann.morin@orange.com> Applied to master, thanks for the review! > Regards, > Yann E. MORIN. Best regards, Julien.
diff --git a/package/skopeo/Config.in.host b/package/skopeo/Config.in.host index 334a12b6fc..1c1c8f3ebe 100644 --- a/package/skopeo/Config.in.host +++ b/package/skopeo/Config.in.host @@ -2,6 +2,7 @@ config BR2_PACKAGE_HOST_SKOPEO bool "host skopeo" depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS depends on BR2_PACKAGE_HOST_GO_HOST_CGO_LINKING_SUPPORTS + select BR2_PACKAGE_HOST_GO help skopeo is a command line utility that performs various operations on container images and image repositories.
host-skopeo fail to build, using the commands: echo BR2_PACKAGE_HOST_SKOPEO=y >.config make olddefconfig make host-skopeo This commit fixes the issue by selecting BR2_PACKAGE_HOST_GO in the Config.in file. Fixes: make: *** No rule to make target 'host-', needed by '/buildroot/output/build/host-go-1.23.2/.stamp_configured'. Stop. Signed-off-by: Julien Olivain <ju.o@free.fr> --- package/skopeo/Config.in.host | 1 + 1 file changed, 1 insertion(+)