diff mbox series

[next,1/1] boot/grub2: update _SITE to use BR2_GNU_MIRROR

Message ID 20241117131342.551472-1-ju.o@free.fr
State Accepted
Headers show
Series [next,1/1] boot/grub2: update _SITE to use BR2_GNU_MIRROR | expand

Commit Message

Julien Olivain Nov. 17, 2024, 1:13 p.m. UTC
The grub2 package is distributed on the GNU project servers. See [1]
and [2]. Buildroot has the BR2_GNU_MIRROR configuration which can
be used for that purpose. See [3].

For consistency with all other GNU packages, this commit updates
the _SITE to use BR2_GNU_MIRROR.

Note: Commit [4] introduced the grub2 package using BR2_GNU_MIRROR.
Commit [5] changed it to use "http://ftp.gnu.org/gnu/grub" without
providing a justification for that change.

[1] https://www.gnu.org/software/grub/grub-download.html
[2] https://www.gnu.org/prep/ftp.html
[3] https://gitlab.com/buildroot.org/buildroot/-/blob/2024.08.2/Config.in#L286
[4] https://gitlab.com/buildroot.org/buildroot/-/commit/c24fdb3680019d18f0cb7c02a90975ee9fe9613c
[5] https://gitlab.com/buildroot.org/buildroot/-/commit/5ffafd2353f5d67dc74c7f3784dfe48d4080435e

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 boot/grub2/grub2.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Romain Naour Dec. 11, 2024, 2:07 p.m. UTC | #1
Hello Julien,

Le 17/11/2024 à 14:13, Julien Olivain a écrit :
> The grub2 package is distributed on the GNU project servers. See [1]
> and [2]. Buildroot has the BR2_GNU_MIRROR configuration which can
> be used for that purpose. See [3].
> 
> For consistency with all other GNU packages, this commit updates
> the _SITE to use BR2_GNU_MIRROR.
> 
> Note: Commit [4] introduced the grub2 package using BR2_GNU_MIRROR.
> Commit [5] changed it to use "http://ftp.gnu.org/gnu/grub" without
> providing a justification for that change.
> 
> [1] https://www.gnu.org/software/grub/grub-download.html
> [2] https://www.gnu.org/prep/ftp.html
> [3] https://gitlab.com/buildroot.org/buildroot/-/blob/2024.08.2/Config.in#L286
> [4] https://gitlab.com/buildroot.org/buildroot/-/commit/c24fdb3680019d18f0cb7c02a90975ee9fe9613c
> [5] https://gitlab.com/buildroot.org/buildroot/-/commit/5ffafd2353f5d67dc74c7f3784dfe48d4080435e
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>

Applied to master, thanks.

Best regards,
Romain


> ---
>  boot/grub2/grub2.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/boot/grub2/grub2.mk b/boot/grub2/grub2.mk
> index 4df12774a3..0896029322 100644
> --- a/boot/grub2/grub2.mk
> +++ b/boot/grub2/grub2.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
>  
>  GRUB2_VERSION = 2.12
> -GRUB2_SITE = http://ftp.gnu.org/gnu/grub
> +GRUB2_SITE = $(BR2_GNU_MIRROR)/grub
>  GRUB2_SOURCE = grub-$(GRUB2_VERSION).tar.xz
>  GRUB2_LICENSE = GPL-3.0+
>  GRUB2_LICENSE_FILES = COPYING
Peter Korsgaard Dec. 13, 2024, 10:39 p.m. UTC | #2
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > The grub2 package is distributed on the GNU project servers. See [1]
 > and [2]. Buildroot has the BR2_GNU_MIRROR configuration which can
 > be used for that purpose. See [3].

 > For consistency with all other GNU packages, this commit updates
 > the _SITE to use BR2_GNU_MIRROR.

 > Note: Commit [4] introduced the grub2 package using BR2_GNU_MIRROR.
 > Commit [5] changed it to use "http://ftp.gnu.org/gnu/grub" without
 > providing a justification for that change.

 > [1] https://www.gnu.org/software/grub/grub-download.html
 > [2] https://www.gnu.org/prep/ftp.html
 > [3] https://gitlab.com/buildroot.org/buildroot/-/blob/2024.08.2/Config.in#L286
 > [4] https://gitlab.com/buildroot.org/buildroot/-/commit/c24fdb3680019d18f0cb7c02a90975ee9fe9613c
 > [5] https://gitlab.com/buildroot.org/buildroot/-/commit/5ffafd2353f5d67dc74c7f3784dfe48d4080435e

 > Signed-off-by: Julien Olivain <ju.o@free.fr>

Committed to 2024.02.x and 2024.11.x, thanks.
diff mbox series

Patch

diff --git a/boot/grub2/grub2.mk b/boot/grub2/grub2.mk
index 4df12774a3..0896029322 100644
--- a/boot/grub2/grub2.mk
+++ b/boot/grub2/grub2.mk
@@ -5,7 +5,7 @@ 
 ################################################################################
 
 GRUB2_VERSION = 2.12
-GRUB2_SITE = http://ftp.gnu.org/gnu/grub
+GRUB2_SITE = $(BR2_GNU_MIRROR)/grub
 GRUB2_SOURCE = grub-$(GRUB2_VERSION).tar.xz
 GRUB2_LICENSE = GPL-3.0+
 GRUB2_LICENSE_FILES = COPYING