| Message ID | 20241117123839.536725-1-ju.o@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [next,1/1] package/octave: update _SITE to use BR2_GNU_MIRROR | expand |
Hello Julien, All, Le 17/11/2024 à 13:38, Julien Olivain a écrit : > The octave package is distributed on the GNU project servers. See [1] > and [2]. Buildroot has the BR2_GNU_MIRROR configuration which can > be used for that purpose. See [3]. > > For consistency with all other GNU packages, this commit updates > the _SITE to use BR2_GNU_MIRROR. > > [1] https://www.octave.org/download > [2] https://www.gnu.org/prep/ftp.html > [3] https://gitlab.com/buildroot.org/buildroot/-/blob/2024.08.2/Config.in#L286 > > Signed-off-by: Julien Olivain <ju.o@free.fr> > --- > package/octave/octave.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/octave/octave.mk b/package/octave/octave.mk > index 2e2fe0f989..34d9288c75 100644 > --- a/package/octave/octave.mk > +++ b/package/octave/octave.mk > @@ -5,7 +5,7 @@ > ################################################################################ > > OCTAVE_VERSION = 9.2.0 > -OCTAVE_SITE = https://ftp.gnu.org/gnu/octave > +OCTAVE_SITE = $(BR2_GNU_MIRROR)/octave Actually our BR2_GNU_MIRROR default value uses http "http://ftpmirror.gnu.org". So, here you replace an https url by http one. Maybe it's time to update BR2_GNU_MIRROR to https? Best regards, Romain > OCTAVE_SOURCE = octave-$(OCTAVE_VERSION).tar.lz > OCTAVE_LICENSE = GPL-3.0+ > OCTAVE_LICENSE_FILES = COPYING
Le 11/12/2024 à 14:57, Romain Naour a écrit : > Hello Julien, All, > > Le 17/11/2024 à 13:38, Julien Olivain a écrit : >> The octave package is distributed on the GNU project servers. See [1] >> and [2]. Buildroot has the BR2_GNU_MIRROR configuration which can >> be used for that purpose. See [3]. >> >> For consistency with all other GNU packages, this commit updates >> the _SITE to use BR2_GNU_MIRROR. >> >> [1] https://www.octave.org/download >> [2] https://www.gnu.org/prep/ftp.html >> [3] https://gitlab.com/buildroot.org/buildroot/-/blob/2024.08.2/Config.in#L286 >> >> Signed-off-by: Julien Olivain <ju.o@free.fr> >> --- >> package/octave/octave.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/octave/octave.mk b/package/octave/octave.mk >> index 2e2fe0f989..34d9288c75 100644 >> --- a/package/octave/octave.mk >> +++ b/package/octave/octave.mk >> @@ -5,7 +5,7 @@ >> ################################################################################ >> >> OCTAVE_VERSION = 9.2.0 >> -OCTAVE_SITE = https://ftp.gnu.org/gnu/octave >> +OCTAVE_SITE = $(BR2_GNU_MIRROR)/octave > > Actually our BR2_GNU_MIRROR default value uses http "http://ftpmirror.gnu.org". > So, here you replace an https url by http one. > > Maybe it's time to update BR2_GNU_MIRROR to https? I merged your patch doing so [1] [1] https://gitlab.com/buildroot.org/buildroot/-/commit/0f9da3934b9fc1425db49526ab7735a601ac1edb Applied to master, thanks. Best regards, Romain > > Best regards, > Romain > > >> OCTAVE_SOURCE = octave-$(OCTAVE_VERSION).tar.lz >> OCTAVE_LICENSE = GPL-3.0+ >> OCTAVE_LICENSE_FILES = COPYING >
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes: > The octave package is distributed on the GNU project servers. See [1] > and [2]. Buildroot has the BR2_GNU_MIRROR configuration which can > be used for that purpose. See [3]. > For consistency with all other GNU packages, this commit updates > the _SITE to use BR2_GNU_MIRROR. > [1] https://www.octave.org/download > [2] https://www.gnu.org/prep/ftp.html > [3] https://gitlab.com/buildroot.org/buildroot/-/blob/2024.08.2/Config.in#L286 > Signed-off-by: Julien Olivain <ju.o@free.fr> Committed to 2024.02.x and 2024.11.x, thanks.
diff --git a/package/octave/octave.mk b/package/octave/octave.mk index 2e2fe0f989..34d9288c75 100644 --- a/package/octave/octave.mk +++ b/package/octave/octave.mk @@ -5,7 +5,7 @@ ################################################################################ OCTAVE_VERSION = 9.2.0 -OCTAVE_SITE = https://ftp.gnu.org/gnu/octave +OCTAVE_SITE = $(BR2_GNU_MIRROR)/octave OCTAVE_SOURCE = octave-$(OCTAVE_VERSION).tar.lz OCTAVE_LICENSE = GPL-3.0+ OCTAVE_LICENSE_FILES = COPYING
The octave package is distributed on the GNU project servers. See [1] and [2]. Buildroot has the BR2_GNU_MIRROR configuration which can be used for that purpose. See [3]. For consistency with all other GNU packages, this commit updates the _SITE to use BR2_GNU_MIRROR. [1] https://www.octave.org/download [2] https://www.gnu.org/prep/ftp.html [3] https://gitlab.com/buildroot.org/buildroot/-/blob/2024.08.2/Config.in#L286 Signed-off-by: Julien Olivain <ju.o@free.fr> --- package/octave/octave.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)