| Message ID | 20241022225457.568323-3-bryce@redpinelabs.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] package/arm-gnu-toolchain: Add support check for x86_64 and aarch64 | expand |
Hi Bryce! On October 22, 2024 thus sayeth Bryce Johnson: > To check for valid x86_64 or aarch64 configuration for arm32 toolchain > > Signed-off-by: Bryce Johnson <bryce@redpinelabs.com> > --- > boot/ti-k3-r5-loader/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/boot/ti-k3-r5-loader/Config.in b/boot/ti-k3-r5-loader/Config.in > index 8c7898ebf6..fe429bb8b4 100644 > --- a/boot/ti-k3-r5-loader/Config.in > +++ b/boot/ti-k3-r5-loader/Config.in > @@ -1,6 +1,7 @@ > config BR2_TARGET_TI_K3_R5_LOADER > bool "ti-k3-r5-loader" > depends on BR2_aarch64 > + depends on BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS This package is really only here for TI's K3 SoCs. Would it make sense to drop the BR2_aarch64 here for this or to keep BR2_aarch64? ~Bryan
Hey Bryan, Not sure on that one. I think the BR2_aarch64 is there since the am6* that use the ti-k3-r5-loader are all aarch64 application processors even though the R5 is 32bit? My guess is it probably isn't needed. Any reason someone would want to build the am62* as 32-bit, then there might be an issue with having that there. Bryce On Wed, Oct 30, 2024 at 4:09 PM Bryan Brattlof <bb@ti.com> wrote: > > Hi Bryce! > > On October 22, 2024 thus sayeth Bryce Johnson: > > To check for valid x86_64 or aarch64 configuration for arm32 toolchain > > > > Signed-off-by: Bryce Johnson <bryce@redpinelabs.com> > > --- > > boot/ti-k3-r5-loader/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/boot/ti-k3-r5-loader/Config.in b/boot/ti-k3-r5-loader/Config.in > > index 8c7898ebf6..fe429bb8b4 100644 > > --- a/boot/ti-k3-r5-loader/Config.in > > +++ b/boot/ti-k3-r5-loader/Config.in > > @@ -1,6 +1,7 @@ > > config BR2_TARGET_TI_K3_R5_LOADER > > bool "ti-k3-r5-loader" > > depends on BR2_aarch64 > > + depends on BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS > > This package is really only here for TI's K3 SoCs. Would it make sense > to drop the BR2_aarch64 here for this or to keep BR2_aarch64? > > ~Bryan
On Mon, Nov 4, 2024 at 9:52 AM Bryce Johnson <bryce@redpinelabs.com> wrote: > > Hey Bryan, > Not sure on that one. I think the BR2_aarch64 is there since the am6* > that use the ti-k3-r5-loader are all aarch64 application processors > even though the R5 is 32bit? My guess is it probably isn't needed. > Any reason someone would want to build the am62* as 32-bit, then there > might be an issue with having that there. > > Bryce > Oops, top posted by accident! Bryce
On November 4, 2024 thus sayeth Bryce Johnson: > On Mon, Nov 4, 2024 at 9:52 AM Bryce Johnson <bryce@redpinelabs.com> wrote: > > > > Hey Bryan, > > Not sure on that one. I think the BR2_aarch64 is there since the am6* > > that use the ti-k3-r5-loader are all aarch64 application processors > > even though the R5 is 32bit? My guess is it probably isn't needed. > > Any reason someone would want to build the am62* as 32-bit, then there > > might be an issue with having that there. > > Ah thanks! Yeah I didn't notice it until your patch. > > Oops, top posted by accident! no worries :) ~Bryan
diff --git a/boot/ti-k3-r5-loader/Config.in b/boot/ti-k3-r5-loader/Config.in index 8c7898ebf6..fe429bb8b4 100644 --- a/boot/ti-k3-r5-loader/Config.in +++ b/boot/ti-k3-r5-loader/Config.in @@ -1,6 +1,7 @@ config BR2_TARGET_TI_K3_R5_LOADER bool "ti-k3-r5-loader" depends on BR2_aarch64 + depends on BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_SUPPORTS select BR2_TARGET_TI_K3_BOOT_FIRMWARE # binman help Separate U-Boot SPL build for R5 core on TI's K3 processors.
To check for valid x86_64 or aarch64 configuration for arm32 toolchain Signed-off-by: Bryce Johnson <bryce@redpinelabs.com> --- boot/ti-k3-r5-loader/Config.in | 1 + 1 file changed, 1 insertion(+)