| Message ID | 20240729193242.1409148-2-mail@t-voltmer.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/1] package/espflash: add udev dependency | expand |
Hello, Thanks for the new iteration, which I have applied. Just one minor nit, see below! On Mon, 29 Jul 2024 21:32:43 +0200 Torben Voltmer <mail@t-voltmer.net> wrote: > Adding the dependency on udev, since espflash links libudev > (via the libudev-sys crate). > > Fixes: http://autobuild.buildroot.net/results/c61b6ed4b6fb4d18d503ac37add200f5e6ae3706 > > --- > Changes v1 -> v2: > - Added missing dependency in espflash.mk > - Added missing depends on in Config.in > - Verified that the updated patch fixes at least one autobuild failure > > Signed-off-by: Torben Voltmer <mail@t-voltmer.net> The Signed-off-by: line should be *before* the --- sign. Indeed, when git applies a patch, it drops from the commit log everything which is after the --- sign. This is why your changelog (Changes v1 -> v2) is at the right: we don't want this changelog to be part of the final commit message. However, we do want the Signed-off-by to be part of the commit message, so it should be before the --- sign. I fixed that up when applying. Thanks for your contribution! Thomas
diff --git a/package/espflash/Config.in b/package/espflash/Config.in index 2a7a0f6b38..a445101269 100644 --- a/package/espflash/Config.in +++ b/package/espflash/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_ESPFLASH bool "espflash" depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS + depends on BR2_PACKAGE_HAS_UDEV select BR2_PACKAGE_HOST_RUSTC help Serial flasher utilities for Espressif devices, based @@ -8,3 +9,7 @@ config BR2_PACKAGE_ESPFLASH ESP32-C2/C3/C6, ESP32-H2, ESP32-P4, and ESP32-S2/S3. https://github.com/esp-rs/espflash + +comment "espflash needs udev /dev management" + depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS + depends on !BR2_PACKAGE_HAS_UDEV diff --git a/package/espflash/espflash.mk b/package/espflash/espflash.mk index 43532de58c..ad2294e1bf 100644 --- a/package/espflash/espflash.mk +++ b/package/espflash/espflash.mk @@ -9,5 +9,6 @@ ESPFLASH_SITE = $(call github,esp-rs,espflash,v$(ESPFLASH_VERSION)) ESPFLASH_SUBDIR = espflash ESPFLASH_LICENSE = Apache-2.0 or MIT ESPFLASH_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT +ESPFLASH_DEPENDENCIES = udev $(eval $(cargo-package))
Adding the dependency on udev, since espflash links libudev (via the libudev-sys crate). Fixes: http://autobuild.buildroot.net/results/c61b6ed4b6fb4d18d503ac37add200f5e6ae3706 --- Changes v1 -> v2: - Added missing dependency in espflash.mk - Added missing depends on in Config.in - Verified that the updated patch fixes at least one autobuild failure Signed-off-by: Torben Voltmer <mail@t-voltmer.net> --- package/espflash/Config.in | 5 +++++ package/espflash/espflash.mk | 1 + 2 files changed, 6 insertions(+)