| Message ID | 20181009122326.12174-1-yegorslists@googlemail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | poco: disable fpenvironment for MIPS without FPU | expand |
Hello, On Tue, 9 Oct 2018 14:23:26 +0200, yegorslists@googlemail.com wrote: > From: Yegor Yefremov <yegorslists@googlemail.com> > > glibc fixed a bug, that defined FPU capabilities not This is a bit vague. Which bug? Which commit? Do you have some more details ? > available for MIPS without FPU. So add --no-fpenvironment > to the configuration options for this case. > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> > --- > package/poco/poco.mk | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/package/poco/poco.mk b/package/poco/poco.mk > index 018344d5c7..1f3eabd009 100644 > --- a/package/poco/poco.mk > +++ b/package/poco/poco.mk > @@ -42,6 +42,13 @@ ifeq ($(BR2_sh4a)$(BR2_nios2),y) > POCO_CONF_OPTS += --no-fpenvironment > endif > > +# MIPS without FPU > +ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y) > +ifeq ($(BR2_MIPS_SOFT_FLOAT),y) Perhaps: ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el):$(BR2_MIPS_SOFT_FLOAT),y:y) I'm wondering if we shouldn't introduce some global BR2_ARCH_IS_MIPS option, or something like that, because we have a lot of places where we repeat those mips/mipsel/mips64/mips64el conditions. But that is of course a completely separate discussion. Best regards, Thomas
diff --git a/package/poco/poco.mk b/package/poco/poco.mk index 018344d5c7..1f3eabd009 100644 --- a/package/poco/poco.mk +++ b/package/poco/poco.mk @@ -42,6 +42,13 @@ ifeq ($(BR2_sh4a)$(BR2_nios2),y) POCO_CONF_OPTS += --no-fpenvironment endif +# MIPS without FPU +ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y) +ifeq ($(BR2_MIPS_SOFT_FLOAT),y) +POCO_CONF_OPTS += --no-fpenvironment +endif +endif + ifeq ($(BR2_STATIC_LIBS),y) POCO_MAKE_TARGET = static_release else ifeq ($(BR2_SHARED_LIBS),y)