diff mbox

[2/2] GPIO: 74xx-mmio: Add DT bindings documentation

Message ID 1411112404-16040-3-git-send-email-shc_work@mail.ru
State Not Applicable, archived
Headers show

Commit Message

Alexander Shiyan Sept. 19, 2014, 7:40 a.m. UTC
This patch adds DT binding documentation for the 74xx-mmio GPIO driver.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 .../devicetree/bindings/gpio/gpio-74xx-mmio.txt    | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-74xx-mmio.txt

Comments

Geert Uytterhoeven Sept. 22, 2014, 11:39 a.m. UTC | #1
On Fri, Sep 19, 2014 at 9:40 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-74xx-mmio.txt
> @@ -0,0 +1,30 @@
> +* 74XX MMIO GPIO driver
> +
> +Required properties:
> +- compatible: Should contain one of the following:
> +   "ti,74ahc1g125": for 74AHC1G125 (1-bit Input),
> +   "ti,74auc1g174": for 74AUC1G74 (1-bit Output),
> +   "ti,74lvc2g125": for 74LVC2G125 (2-bit Input),
> +   "ti,74hc74":     for 74HC74 (2-bit Output),
> +   "ti,74hc125":    for 74HC125 (4-bit Input),
> +   "ti,74hc175":    for 74HC175 (4-bit Output),
> +   "ti,74hc365":    for 74HC365 (6-bit Input),
> +   "ti,74hc174":    for 74HC174 (6-bit Output),
> +   "ti,74hc244":    for 74HC244 (8-bit Input),
> +   "ti,74hc273":    for 74HC273 (8-bit Output),
> +   "ti,74ac1624":   for 74AC1624 (16-bit Input),
> +   "ti,74ac16374":  for 74AC16374 (16-bit Output).

As the actual implementation technology doesn't matter, I think you
should use the base name where appropriate.
E.g. "ti,7474" instead of "ti,74hc74".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexander Shiyan Sept. 23, 2014, 4:51 p.m. UTC | #2
Mon, 22 Sep 2014 13:39:26 +0200 от Geert Uytterhoeven <geert@linux-m68k.org>:
> On Fri, Sep 19, 2014 at 9:40 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-74xx-mmio.txt
> > @@ -0,0 +1,30 @@
> > +* 74XX MMIO GPIO driver
> > +
> > +Required properties:
> > +- compatible: Should contain one of the following:
> > +   "ti,74ahc1g125": for 74AHC1G125 (1-bit Input),
> > +   "ti,74auc1g174": for 74AUC1G74 (1-bit Output),
> > +   "ti,74lvc2g125": for 74LVC2G125 (2-bit Input),
> > +   "ti,74hc74":     for 74HC74 (2-bit Output),
> > +   "ti,74hc125":    for 74HC125 (4-bit Input),
> > +   "ti,74hc175":    for 74HC175 (4-bit Output),
> > +   "ti,74hc365":    for 74HC365 (6-bit Input),
> > +   "ti,74hc174":    for 74HC174 (6-bit Output),
> > +   "ti,74hc244":    for 74HC244 (8-bit Input),
> > +   "ti,74hc273":    for 74HC273 (8-bit Output),
> > +   "ti,74ac1624":   for 74AC1624 (16-bit Input),
> > +   "ti,74ac16374":  for 74AC16374 (16-bit Output).
> 
> As the actual implementation technology doesn't matter, I think you
> should use the base name where appropriate.
> E.g. "ti,7474" instead of "ti,74hc74".

Make sense.

Linus, what you think overall about this driver?

---
Linus Walleij Sept. 24, 2014, 11:26 a.m. UTC | #3
On Tue, Sep 23, 2014 at 6:51 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> Mon, 22 Sep 2014 13:39:26 +0200 от Geert Uytterhoeven <geert@linux-m68k.org>:
>> On Fri, Sep 19, 2014 at 9:40 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/gpio/gpio-74xx-mmio.txt
>> > @@ -0,0 +1,30 @@
>> > +* 74XX MMIO GPIO driver
>> > +
>> > +Required properties:
>> > +- compatible: Should contain one of the following:
>> > +   "ti,74ahc1g125": for 74AHC1G125 (1-bit Input),
>> > +   "ti,74auc1g174": for 74AUC1G74 (1-bit Output),
>> > +   "ti,74lvc2g125": for 74LVC2G125 (2-bit Input),
>> > +   "ti,74hc74":     for 74HC74 (2-bit Output),
>> > +   "ti,74hc125":    for 74HC125 (4-bit Input),
>> > +   "ti,74hc175":    for 74HC175 (4-bit Output),
>> > +   "ti,74hc365":    for 74HC365 (6-bit Input),
>> > +   "ti,74hc174":    for 74HC174 (6-bit Output),
>> > +   "ti,74hc244":    for 74HC244 (8-bit Input),
>> > +   "ti,74hc273":    for 74HC273 (8-bit Output),
>> > +   "ti,74ac1624":   for 74AC1624 (16-bit Input),
>> > +   "ti,74ac16374":  for 74AC16374 (16-bit Output).
>>
>> As the actual implementation technology doesn't matter, I think you
>> should use the base name where appropriate.
>> E.g. "ti,7474" instead of "ti,74hc74".
>
> Make sense.
>
> Linus, what you think overall about this driver?

That's a question about patch 1/2, and I haven't gotten to it
yet. High incoming patch rate.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/gpio/gpio-74xx-mmio.txt b/Documentation/devicetree/bindings/gpio/gpio-74xx-mmio.txt
new file mode 100644
index 0000000..202dce7
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-74xx-mmio.txt
@@ -0,0 +1,30 @@ 
+* 74XX MMIO GPIO driver
+
+Required properties:
+- compatible: Should contain one of the following:
+   "ti,74ahc1g125": for 74AHC1G125 (1-bit Input),
+   "ti,74auc1g174": for 74AUC1G74 (1-bit Output),
+   "ti,74lvc2g125": for 74LVC2G125 (2-bit Input),
+   "ti,74hc74":     for 74HC74 (2-bit Output),
+   "ti,74hc125":    for 74HC125 (4-bit Input),
+   "ti,74hc175":    for 74HC175 (4-bit Output),
+   "ti,74hc365":    for 74HC365 (6-bit Input),
+   "ti,74hc174":    for 74HC174 (6-bit Output),
+   "ti,74hc244":    for 74HC244 (8-bit Input),
+   "ti,74hc273":    for 74HC273 (8-bit Output),
+   "ti,74ac1624":   for 74AC1624 (16-bit Input),
+   "ti,74ac16374":  for 74AC16374 (16-bit Output).
+- reg: Physical base address and length where IC resides.
+- gpio-controller: Marks the device node as a gpio controller.
+- #gpio-cells: Should be two. The first cell is the pin number and
+   the second cell is used to specify the GPIO polarity:
+    0 = Active High,
+    1 = Active Low.
+
+Example:
+	ctrl: gpio@30008004 {
+		compatible = "ti,74hc174";
+		reg = <0x30008004 0x1>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};