| Message ID | cf202ebfe8a42e3f84646e7c2a4bfd6a7e6195bc.1403673509.git.sam.bobroff@au1.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Michael Ellerman |
| Headers | show |
On Wed, 2014-06-25 at 15:18 +1000, Sam Bobroff wrote: > This patch changes the name of a make variable (TARGETS) to prevent it > from colliding with a value set by the user on the command line (as > they are recommended to do by tools/testing/selftests/README.txt). > > Before this patch, "make -C tools/testing/selftests TARGETS=powerpc" > would fail. > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers
diff --git a/tools/testing/selftests/powerpc/Makefile b/tools/testing/selftests/powerpc/Makefile index 54833a7..84795c0 100644 --- a/tools/testing/selftests/powerpc/Makefile +++ b/tools/testing/selftests/powerpc/Makefile @@ -13,22 +13,22 @@ CFLAGS := -Wall -O2 -flto -Wall -Werror -DGIT_VERSION='"$(GIT_VERSION)"' -I$(CUR export CC CFLAGS -TARGETS = pmu copyloops mm tm +SUB_TARGETS = pmu copyloops mm tm endif all: - @for TARGET in $(TARGETS); do \ + @for TARGET in $(SUB_TARGETS); do \ $(MAKE) -C $$TARGET all; \ done; run_tests: all - @for TARGET in $(TARGETS); do \ + @for TARGET in $(SUB_TARGETS); do \ $(MAKE) -C $$TARGET run_tests; \ done; clean: - @for TARGET in $(TARGETS); do \ + @for TARGET in $(SUB_TARGETS); do \ $(MAKE) -C $$TARGET clean; \ done; rm -f tags
This patch changes the name of a make variable (TARGETS) to prevent it from colliding with a value set by the user on the command line (as they are recommended to do by tools/testing/selftests/README.txt). Before this patch, "make -C tools/testing/selftests TARGETS=powerpc" would fail. Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> --- tools/testing/selftests/powerpc/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)