| Message ID | 1400617498.4912.66.camel@x220 (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Paul Bolle <pebolle@tiscali.nl> writes: > Commit b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling > perf_event_do_pending") added a check for CONFIG_PMAC were a check for > CONFIG_PPC_PMAC was clearly intended. > > Fixes: b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending") > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Untested. Needs testing on 32 bit powermac, I guess. > > This typo was introduced in v2.6.36. No one noticed because very few > people still use 32 bit powermacs? How does that bug manifest itself? Andreas.
Andreas, On Wed, 2014-05-21 at 18:08 +0200, Andreas Schwab wrote: > Paul Bolle <pebolle@tiscali.nl> writes: > > > Commit b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling > > perf_event_do_pending") added a check for CONFIG_PMAC were a check for > > CONFIG_PPC_PMAC was clearly intended. > > > > Fixes: b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending") > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > --- > > Untested. Needs testing on 32 bit powermac, I guess. > > > > This typo was introduced in v2.6.36. No one noticed because very few > > people still use 32 bit powermacs? > > How does that bug manifest itself? Do you want to know how to test this patch on a 32 bit powermac? Ie, see if it has any effect, and whether that effect improves things or make things worse. I have no clue how to do that, sorry. Perhaps someone else has. Paul Bolle
Paul Bolle <pebolle@tiscali.nl> writes: > Do you want to know how to test this patch on a 32 bit powermac? Ie, see > if it has any effect, and whether that effect improves things or make > things worse. Yes. Andreas.
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c index 122a580f7322..bb3cfa10a4ea 100644 --- a/arch/powerpc/kernel/time.c +++ b/arch/powerpc/kernel/time.c @@ -551,7 +551,7 @@ void timer_interrupt(struct pt_regs * regs) may_hard_irq_enable(); -#if defined(CONFIG_PPC32) && defined(CONFIG_PMAC) +#if defined(CONFIG_PPC32) && defined(CONFIG_PPC_PMAC) if (atomic_read(&ppc_n_lost_interrupts) != 0) do_IRQ(regs); #endif
Commit b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending") added a check for CONFIG_PMAC were a check for CONFIG_PPC_PMAC was clearly intended. Fixes: b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending") Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Untested. Needs testing on 32 bit powermac, I guess. This typo was introduced in v2.6.36. No one noticed because very few people still use 32 bit powermacs? arch/powerpc/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)