| Message ID | 5343E516.3020103@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Apr 8, 2014 at 10:01 PM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: > Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not > need additional useless 'continue'. > Only in the case where the if-else is not followed by any code. Which is the case here. I found this sentance slightly confusing and TBH id just drop it or say something less codey like: "This if else has no code between it and the end of the enclosing while loop. This makes this continue redundant." > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> But patch is good: Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > --- > vl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/vl.c b/vl.c > index 9975e5a..7505002 100644 > --- a/vl.c > +++ b/vl.c > @@ -3034,7 +3034,6 @@ int main(int argc, char **argv, char **envp) > if (argv[optind][0] != '-') { > /* disk image */ > optind++; > - continue; > } else { > const QEMUOption *popt; > > -- > 1.7.9.5 >
On 04/15/2014 10:11 AM, Peter Crosthwaite wrote: > On Tue, Apr 8, 2014 at 10:01 PM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> > Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not >> > need additional useless 'continue'. >> > > Only in the case where the if-else is not followed by any code. Which > is the case here. I found this sentance slightly confusing and TBH id > just drop it or say something less codey like: > > "This if else has no code between it and the end of the enclosing > while loop. This makes this continue redundant." > >> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > But patch is good: > > Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > OK, thanks. Thanks.
Chen Gang <gang.chen.5i5j@gmail.com> writes: > Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not > need additional useless 'continue'. > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > vl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/vl.c b/vl.c > index 9975e5a..7505002 100644 > --- a/vl.c > +++ b/vl.c > @@ -3034,7 +3034,6 @@ int main(int argc, char **argv, char **envp) > if (argv[optind][0] != '-') { > /* disk image */ > optind++; > - continue; > } else { > const QEMUOption *popt; Reviewed-by: Markus Armbruster <armbru@redhat.com>
On 04/15/2014 04:50 PM, Markus Armbruster wrote: > Chen Gang <gang.chen.5i5j@gmail.com> writes: > >> Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not >> need additional useless 'continue'. >> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >> --- >> vl.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/vl.c b/vl.c >> index 9975e5a..7505002 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -3034,7 +3034,6 @@ int main(int argc, char **argv, char **envp) >> if (argv[optind][0] != '-') { >> /* disk image */ >> optind++; >> - continue; >> } else { >> const QEMUOption *popt; > > Reviewed-by: Markus Armbruster <armbru@redhat.com> > OK, thanks.
我怎样才能退订此邮件列表 How can I unsubscribe from this mailing list 2014-04-15 19:05 GMT+08:00 Chen Gang <gang.chen.5i5j@gmail.com>: > > > On 04/15/2014 04:50 PM, Markus Armbruster wrote: > > Chen Gang <gang.chen.5i5j@gmail.com> writes: > > > >> Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not > >> need additional useless 'continue'. > >> > >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > >> --- > >> vl.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/vl.c b/vl.c > >> index 9975e5a..7505002 100644 > >> --- a/vl.c > >> +++ b/vl.c > >> @@ -3034,7 +3034,6 @@ int main(int argc, char **argv, char **envp) > >> if (argv[optind][0] != '-') { > >> /* disk image */ > >> optind++; > >> - continue; > >> } else { > >> const QEMUOption *popt; > > > > Reviewed-by: Markus Armbruster <armbru@redhat.com> > > > > OK, thanks. > > -- > Chen Gang > > Open, share, and attitude like air, water, and life which God blessed > >
diff --git a/vl.c b/vl.c index 9975e5a..7505002 100644 --- a/vl.c +++ b/vl.c @@ -3034,7 +3034,6 @@ int main(int argc, char **argv, char **envp) if (argv[optind][0] != '-') { /* disk image */ optind++; - continue; } else { const QEMUOption *popt;
Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not need additional useless 'continue'. Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- vl.c | 1 - 1 file changed, 1 deletion(-)