diff mbox

lib: fwts_log: Add missing log field flags

Message ID 1395827907-26792-1-git-send-email-matt@console-pimps.org
State Accepted
Headers show

Commit Message

Matt Fleming March 26, 2014, 9:58 a.m. UTC
From: Matt Fleming <matt.fleming@intel.com>

There are fields in the output of --log-fields that do not currently
work with --log-filter. Add missing fields to fwts_log_str_to_field() so
that all of the fields can be used in filtering the log.

Signed-off-by: Matt Fleming <matt.fleming@intel.com>
---
 src/lib/src/fwts_log.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Colin Ian King March 26, 2014, 10:05 a.m. UTC | #1
On 26/03/14 09:58, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
> 
> There are fields in the output of --log-fields that do not currently
> work with --log-filter. Add missing fields to fwts_log_str_to_field() so
> that all of the fields can be used in filtering the log.
> 
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> ---
>  src/lib/src/fwts_log.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/lib/src/fwts_log.c b/src/lib/src/fwts_log.c
> index 8d9923e1153b..7eeda684db7c 100644
> --- a/src/lib/src/fwts_log.c
> +++ b/src/lib/src/fwts_log.c
> @@ -233,8 +233,14 @@ fwts_log_field fwts_log_str_to_field(const char *text)
>  		{ "INF", LOG_INFO },
>  		{ "SUM", LOG_SUMMARY },
>  		{ "SEP", LOG_SEPARATOR },
> +		{ "NLN", LOG_NEWLINE },
>  		{ "ADV", LOG_ADVICE },
>  		{ "HED", LOG_HEADING },
> +		{ "PAS", LOG_PASSED },
> +		{ "FAL", LOG_FAILED },
> +		{ "SKP", LOG_SKIPPED },
> +		{ "ABT", LOG_ABORTED },
> +		{ "INO", LOG_INFOONLY },
>  		{ "ALL", ~0 },
>  		{ NULL, 0 }
>  	};
> 

Thanks Matt,

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu March 27, 2014, 2 a.m. UTC | #2
On 03/26/2014 05:58 PM, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
>
> There are fields in the output of --log-fields that do not currently
> work with --log-filter. Add missing fields to fwts_log_str_to_field() so
> that all of the fields can be used in filtering the log.
>
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> ---
>   src/lib/src/fwts_log.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/src/lib/src/fwts_log.c b/src/lib/src/fwts_log.c
> index 8d9923e1153b..7eeda684db7c 100644
> --- a/src/lib/src/fwts_log.c
> +++ b/src/lib/src/fwts_log.c
> @@ -233,8 +233,14 @@ fwts_log_field fwts_log_str_to_field(const char *text)
>   		{ "INF", LOG_INFO },
>   		{ "SUM", LOG_SUMMARY },
>   		{ "SEP", LOG_SEPARATOR },
> +		{ "NLN", LOG_NEWLINE },
>   		{ "ADV", LOG_ADVICE },
>   		{ "HED", LOG_HEADING },
> +		{ "PAS", LOG_PASSED },
> +		{ "FAL", LOG_FAILED },
> +		{ "SKP", LOG_SKIPPED },
> +		{ "ABT", LOG_ABORTED },
> +		{ "INO", LOG_INFOONLY },
>   		{ "ALL", ~0 },
>   		{ NULL, 0 }
>   	};
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/lib/src/fwts_log.c b/src/lib/src/fwts_log.c
index 8d9923e1153b..7eeda684db7c 100644
--- a/src/lib/src/fwts_log.c
+++ b/src/lib/src/fwts_log.c
@@ -233,8 +233,14 @@  fwts_log_field fwts_log_str_to_field(const char *text)
 		{ "INF", LOG_INFO },
 		{ "SUM", LOG_SUMMARY },
 		{ "SEP", LOG_SEPARATOR },
+		{ "NLN", LOG_NEWLINE },
 		{ "ADV", LOG_ADVICE },
 		{ "HED", LOG_HEADING },
+		{ "PAS", LOG_PASSED },
+		{ "FAL", LOG_FAILED },
+		{ "SKP", LOG_SKIPPED },
+		{ "ABT", LOG_ABORTED },
+		{ "INO", LOG_INFOONLY },
 		{ "ALL", ~0 },
 		{ NULL, 0 }
 	};