| Message ID | 1382597614-8973-1-git-send-email-pl@kamp.de |
|---|---|
| State | New |
| Headers | show |
On 10/24/2013 07:53 AM, Peter Lieven wrote: > currently it is not possible to distinguish by exitcode if there > has been an error or if bdrv_check is not supported by the image > format. Change the exitcode from 1 to 63 for the latter case. > > Signed-off-by: Peter Lieven <pl@kamp.de> > --- > v1->v2: As Eric suggested changed the exitcode from 255 to 63. > > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Should the man page document this exit status? Then again, it doesn't document ANY exit status, so that could be a separate patch. Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/qemu-img.c b/qemu-img.c > index 926f0a0..bf3fb4f 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -607,7 +607,7 @@ static int img_check(int argc, char **argv) > if (output_format == OFORMAT_HUMAN) { > error_report("This image format does not support checks"); > } > - ret = 1; > + ret = 63; > goto fail; > } > >
Am 24.10.2013 um 09:00 hat Eric Blake geschrieben: > On 10/24/2013 07:53 AM, Peter Lieven wrote: > > currently it is not possible to distinguish by exitcode if there > > has been an error or if bdrv_check is not supported by the image > > format. Change the exitcode from 1 to 63 for the latter case. > > > > Signed-off-by: Peter Lieven <pl@kamp.de> > > --- > > v1->v2: As Eric suggested changed the exitcode from 255 to 63. > > > > qemu-img.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Should the man page document this exit status? Then again, it doesn't > document ANY exit status, so that could be a separate patch. > > Reviewed-by: Eric Blake <eblake@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/qemu-img.c b/qemu-img.c index 926f0a0..bf3fb4f 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -607,7 +607,7 @@ static int img_check(int argc, char **argv) if (output_format == OFORMAT_HUMAN) { error_report("This image format does not support checks"); } - ret = 1; + ret = 63; goto fail; }
currently it is not possible to distinguish by exitcode if there has been an error or if bdrv_check is not supported by the image format. Change the exitcode from 1 to 63 for the latter case. Signed-off-by: Peter Lieven <pl@kamp.de> --- v1->v2: As Eric suggested changed the exitcode from 255 to 63. qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)