| Message ID | 20130715193201.943.4913.stgit@localhost |
|---|---|
| State | New |
| Headers | show |
On Monday, July 15, 2013 03:32:01 PM Paul Moore wrote: > A previous commit, "seccomp: add the asynchronous I/O syscalls to the > whitelist", added several asynchronous I/O syscalls but left out the > io_submit() and io_cancel() syscalls. This patch corrects this by > adding the two missing asynchronous I/O syscalls. > > Signed-off-by: Paul Moore <pmoore@redhat.com> A gentle nudge so this fix doesn't get forgotten. > --- > qemu-seccomp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qemu-seccomp.c b/qemu-seccomp.c > index ca123bf..173d185 100644 > --- a/qemu-seccomp.c > +++ b/qemu-seccomp.c > @@ -33,6 +33,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] > = { { SCMP_SYS(socketcall), 250 }, > #endif > { SCMP_SYS(read), 249 }, > + { SCMP_SYS(io_submit), 249 }, > { SCMP_SYS(brk), 248 }, > { SCMP_SYS(clone), 247 }, > { SCMP_SYS(mmap), 247 }, > @@ -231,6 +232,7 @@ static const struct QemuSeccompSyscall > seccomp_whitelist[] = { { SCMP_SYS(recvmmsg), 241 }, > { SCMP_SYS(prlimit64), 241 }, > { SCMP_SYS(waitid), 241 }, > + { SCMP_SYS(io_cancel), 241 }, > { SCMP_SYS(io_setup), 241 }, > { SCMP_SYS(io_destroy), 241 } > };
On 07/23/2013 10:57 AM, Paul Moore wrote: > On Monday, July 15, 2013 03:32:01 PM Paul Moore wrote: >> A previous commit, "seccomp: add the asynchronous I/O syscalls to the >> whitelist", added several asynchronous I/O syscalls but left out the >> io_submit() and io_cancel() syscalls. This patch corrects this by >> adding the two missing asynchronous I/O syscalls. >> >> Signed-off-by: Paul Moore <pmoore@redhat.com> > > A gentle nudge so this fix doesn't get forgotten. Reviewed and tested. Reviewed-by: Eduardo Otubo <otubo@linux.vnet.ibm.com> > >> --- >> qemu-seccomp.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/qemu-seccomp.c b/qemu-seccomp.c >> index ca123bf..173d185 100644 >> --- a/qemu-seccomp.c >> +++ b/qemu-seccomp.c >> @@ -33,6 +33,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] >> = { { SCMP_SYS(socketcall), 250 }, >> #endif >> { SCMP_SYS(read), 249 }, >> + { SCMP_SYS(io_submit), 249 }, >> { SCMP_SYS(brk), 248 }, >> { SCMP_SYS(clone), 247 }, >> { SCMP_SYS(mmap), 247 }, >> @@ -231,6 +232,7 @@ static const struct QemuSeccompSyscall >> seccomp_whitelist[] = { { SCMP_SYS(recvmmsg), 241 }, >> { SCMP_SYS(prlimit64), 241 }, >> { SCMP_SYS(waitid), 241 }, >> + { SCMP_SYS(io_cancel), 241 }, >> { SCMP_SYS(io_setup), 241 }, >> { SCMP_SYS(io_destroy), 241 } >> };
On Wednesday, July 24, 2013 03:02:23 PM Eduardo Otubo wrote: > On 07/23/2013 10:57 AM, Paul Moore wrote: > > On Monday, July 15, 2013 03:32:01 PM Paul Moore wrote: > >> A previous commit, "seccomp: add the asynchronous I/O syscalls to the > >> whitelist", added several asynchronous I/O syscalls but left out the > >> io_submit() and io_cancel() syscalls. This patch corrects this by > >> adding the two missing asynchronous I/O syscalls. > >> > >> Signed-off-by: Paul Moore <pmoore@redhat.com> > > > > A gentle nudge so this fix doesn't get forgotten. > > Reviewed and tested. > > Reviewed-by: Eduardo Otubo <otubo@linux.vnet.ibm.com> Any chance of merging this patch? > >> --- > >> > >> qemu-seccomp.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/qemu-seccomp.c b/qemu-seccomp.c > >> index ca123bf..173d185 100644 > >> --- a/qemu-seccomp.c > >> +++ b/qemu-seccomp.c > >> @@ -33,6 +33,7 @@ static const struct QemuSeccompSyscall > >> seccomp_whitelist[] = { { SCMP_SYS(socketcall), 250 }, > >> > >> #endif > >> > >> { SCMP_SYS(read), 249 }, > >> > >> + { SCMP_SYS(io_submit), 249 }, > >> > >> { SCMP_SYS(brk), 248 }, > >> { SCMP_SYS(clone), 247 }, > >> { SCMP_SYS(mmap), 247 }, > >> > >> @@ -231,6 +232,7 @@ static const struct QemuSeccompSyscall > >> seccomp_whitelist[] = { { SCMP_SYS(recvmmsg), 241 }, > >> > >> { SCMP_SYS(prlimit64), 241 }, > >> { SCMP_SYS(waitid), 241 }, > >> > >> + { SCMP_SYS(io_cancel), 241 }, > >> > >> { SCMP_SYS(io_setup), 241 }, > >> { SCMP_SYS(io_destroy), 241 } > >> > >> };
Applied. Thanks. Regards, Anthony Liguori
diff --git a/qemu-seccomp.c b/qemu-seccomp.c index ca123bf..173d185 100644 --- a/qemu-seccomp.c +++ b/qemu-seccomp.c @@ -33,6 +33,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = { { SCMP_SYS(socketcall), 250 }, #endif { SCMP_SYS(read), 249 }, + { SCMP_SYS(io_submit), 249 }, { SCMP_SYS(brk), 248 }, { SCMP_SYS(clone), 247 }, { SCMP_SYS(mmap), 247 }, @@ -231,6 +232,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = { { SCMP_SYS(recvmmsg), 241 }, { SCMP_SYS(prlimit64), 241 }, { SCMP_SYS(waitid), 241 }, + { SCMP_SYS(io_cancel), 241 }, { SCMP_SYS(io_setup), 241 }, { SCMP_SYS(io_destroy), 241 } };
A previous commit, "seccomp: add the asynchronous I/O syscalls to the whitelist", added several asynchronous I/O syscalls but left out the io_submit() and io_cancel() syscalls. This patch corrects this by adding the two missing asynchronous I/O syscalls. Signed-off-by: Paul Moore <pmoore@redhat.com> --- qemu-seccomp.c | 2 ++ 1 file changed, 2 insertions(+)