diff mbox

seccomp: add arch_prctl() to the syscall whitelist

Message ID 20130718135703.8247.19213.stgit@localhost
State New
Headers show

Commit Message

Paul Moore July 18, 2013, 1:57 p.m. UTC
It appears that even a very simple /etc/qemu-ifup configuration can
require the arch_prctl() syscall, see the example below:

	#!/bin/sh
	/sbin/ifconfig $1 0.0.0.0 up
	/usr/sbin/brctl addif <switch> $1

Signed-off-by: Paul Moore <pmoore@redhat.com>
---
 qemu-seccomp.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Paul Moore July 23, 2013, 1:57 p.m. UTC | #1
On Thursday, July 18, 2013 09:57:03 AM Paul Moore wrote:
> It appears that even a very simple /etc/qemu-ifup configuration can
> require the arch_prctl() syscall, see the example below:
> 
> 	#!/bin/sh
> 	/sbin/ifconfig $1 0.0.0.0 up
> 	/usr/sbin/brctl addif <switch> $1
> 
> Signed-off-by: Paul Moore <pmoore@redhat.com>

As with the other fix, a gentle nudge so this isn't forgotten.

> ---
>  qemu-seccomp.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 173d185..9e91c73 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -234,7 +234,8 @@ static const struct QemuSeccompSyscall
> seccomp_whitelist[] = { { SCMP_SYS(waitid), 241 },
>      { SCMP_SYS(io_cancel), 241 },
>      { SCMP_SYS(io_setup), 241 },
> -    { SCMP_SYS(io_destroy), 241 }
> +    { SCMP_SYS(io_destroy), 241 },
> +    { SCMP_SYS(arch_prctl), 240 }
>  };
> 
>  int seccomp_start(void)
Eduardo Otubo July 24, 2013, 6:01 p.m. UTC | #2
On 07/23/2013 10:57 AM, Paul Moore wrote:
> On Thursday, July 18, 2013 09:57:03 AM Paul Moore wrote:
>> It appears that even a very simple /etc/qemu-ifup configuration can
>> require the arch_prctl() syscall, see the example below:
>>
>> 	#!/bin/sh
>> 	/sbin/ifconfig $1 0.0.0.0 up
>> 	/usr/sbin/brctl addif <switch> $1
>>
>> Signed-off-by: Paul Moore <pmoore@redhat.com>
>
> As with the other fix, a gentle nudge so this isn't forgotten.

Reviewed and tested.

Reviewed-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>

>
>> ---
>>   qemu-seccomp.c |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>> index 173d185..9e91c73 100644
>> --- a/qemu-seccomp.c
>> +++ b/qemu-seccomp.c
>> @@ -234,7 +234,8 @@ static const struct QemuSeccompSyscall
>> seccomp_whitelist[] = { { SCMP_SYS(waitid), 241 },
>>       { SCMP_SYS(io_cancel), 241 },
>>       { SCMP_SYS(io_setup), 241 },
>> -    { SCMP_SYS(io_destroy), 241 }
>> +    { SCMP_SYS(io_destroy), 241 },
>> +    { SCMP_SYS(arch_prctl), 240 }
>>   };
>>
>>   int seccomp_start(void)
Paul Moore July 29, 2013, 10:12 p.m. UTC | #3
On Wednesday, July 24, 2013 03:01:57 PM Eduardo Otubo wrote:
> On 07/23/2013 10:57 AM, Paul Moore wrote:
> > On Thursday, July 18, 2013 09:57:03 AM Paul Moore wrote:
> >> It appears that even a very simple /etc/qemu-ifup configuration can
> >> 
> >> require the arch_prctl() syscall, see the example below:
> >> 	#!/bin/sh
> >> 	/sbin/ifconfig $1 0.0.0.0 up
> >> 	/usr/sbin/brctl addif <switch> $1
> >> 
> >> Signed-off-by: Paul Moore <pmoore@redhat.com>
> > 
> > As with the other fix, a gentle nudge so this isn't forgotten.
> 
> Reviewed and tested.
> 
> Reviewed-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>

Any chance of merging this patch?

> >> ---
> >> 
> >>   qemu-seccomp.c |    3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> >> index 173d185..9e91c73 100644
> >> --- a/qemu-seccomp.c
> >> +++ b/qemu-seccomp.c
> >> @@ -234,7 +234,8 @@ static const struct QemuSeccompSyscall
> >> seccomp_whitelist[] = { { SCMP_SYS(waitid), 241 },
> >> 
> >>       { SCMP_SYS(io_cancel), 241 },
> >>       { SCMP_SYS(io_setup), 241 },
> >> 
> >> -    { SCMP_SYS(io_destroy), 241 }
> >> +    { SCMP_SYS(io_destroy), 241 },
> >> +    { SCMP_SYS(arch_prctl), 240 }
> >> 
> >>   };
> >>   
> >>   int seccomp_start(void)
Anthony Liguori Aug. 2, 2013, 12:35 p.m. UTC | #4
Applied.  Thanks.

Regards,

Anthony Liguori
diff mbox

Patch

diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index 173d185..9e91c73 100644
--- a/qemu-seccomp.c
+++ b/qemu-seccomp.c
@@ -234,7 +234,8 @@  static const struct QemuSeccompSyscall seccomp_whitelist[] = {
     { SCMP_SYS(waitid), 241 },
     { SCMP_SYS(io_cancel), 241 },
     { SCMP_SYS(io_setup), 241 },
-    { SCMP_SYS(io_destroy), 241 }
+    { SCMP_SYS(io_destroy), 241 },
+    { SCMP_SYS(arch_prctl), 240 }
 };
 
 int seccomp_start(void)