Message ID | 1365632901-15470-8-git-send-email-mrhines@linux.vnet.ibm.com |
---|---|
State | New |
Headers | show |
On 04/10/2013 04:28 PM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" <mrhines@us.ibm.com> > > This capability allows you to disable dynamic chunk registration > for better throughput on high-performance links. > > It is enabled by default. Actually, it isn't enabled until 8/13 - I'd squash 7 and 8 together, to make this statement true. > +++ b/qapi-schema.json > @@ -602,7 +602,7 @@ > # Since: 1.2 Missing documentation of the new capability. Should look something like: # @chunk-register-destination: Migration does XYZ on the destination. # Enabled by default (since 1.5) > ## > { 'enum': 'MigrationCapability', > - 'data': ['xbzrle'] } > + 'data': ['xbzrle', 'chunk_register_destination'] } QMP prefers '-' over '_'/
Acknowledged. On 04/10/2013 10:24 PM, Eric Blake wrote: > On 04/10/2013 04:28 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" <mrhines@us.ibm.com> >> >> This capability allows you to disable dynamic chunk registration >> for better throughput on high-performance links. >> >> It is enabled by default. > Actually, it isn't enabled until 8/13 - I'd squash 7 and 8 together, to > make this statement true. > >> +++ b/qapi-schema.json >> @@ -602,7 +602,7 @@ >> # Since: 1.2 > Missing documentation of the new capability. Should look something like: > > # @chunk-register-destination: Migration does XYZ on the destination. > # Enabled by default (since 1.5) > >> ## >> { 'enum': 'MigrationCapability', >> - 'data': ['xbzrle'] } >> + 'data': ['xbzrle', 'chunk_register_destination'] } > QMP prefers '-' over '_'/ >
diff --git a/migration.c b/migration.c index 3439629..404c19a 100644 --- a/migration.c +++ b/migration.c @@ -477,6 +477,15 @@ void qmp_migrate_set_downtime(double value, Error **errp) max_downtime = (uint64_t)value; } +bool migrate_chunk_register_destination(void) +{ + MigrationState *s; + + s = migrate_get_current(); + + return s->enabled_capabilities[MIGRATION_CAPABILITY_CHUNK_REGISTER_DESTINATION]; +} + int migrate_use_xbzrle(void) { MigrationState *s; diff --git a/qapi-schema.json b/qapi-schema.json index db542f6..7fe7e5c 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -602,7 +602,7 @@ # Since: 1.2 ## { 'enum': 'MigrationCapability', - 'data': ['xbzrle'] } + 'data': ['xbzrle', 'chunk_register_destination'] } ## # @MigrationCapabilityStatus