diff mbox

[1/2] powerpc/mpc8572ds: Fix eTSEC is not available on core1 of AMP boot issue

Message ID 1341900506-23401-1-git-send-email-B38951@freescale.com (mailing list archive)
State Accepted, archived
Commit a2ec009b7544fdbf1c6b6d624ce0167556247370
Delegated to: Kumar Gala
Headers show

Commit Message

Hongtao Jia July 10, 2012, 6:08 a.m. UTC
The issue log on core1 is:
root@mpc8572ds:~# ifconfig eth0 10.192.208.244
net eth0: could not attach to PHY
SIOCSIFFLAGS: No such device

To attach PHY node mdio@24520 should not be disabled in dts of core1.
Because all PHYs are controlled through this node as follows:

mdio@24520 {
	phy0: ethernet-phy@0 {
		interrupts = <10 1 0 0>;
		reg = <0x0>;
	};
	phy1: ethernet-phy@1 {
		interrupts = <10 1 0 0>;
		reg = <0x1>;
	};
	phy2: ethernet-phy@2 {
		interrupts = <10 1 0 0>;
		reg = <0x2>;
	};
	phy3: ethernet-phy@3 {
		interrupts = <10 1 0 0>;
		reg = <0x3>;
	};

	tbi0: tbi-phy@11 {
		reg = <0x11>;
		device_type = "tbi-phy";
	};
};

Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Jia Hongtao <B38951@freescale.com>
---
 arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

Comments

Kumar Gala July 10, 2012, 12:24 p.m. UTC | #1
On Jul 10, 2012, at 1:08 AM, Jia Hongtao wrote:

> The issue log on core1 is:
> root@mpc8572ds:~# ifconfig eth0 10.192.208.244
> net eth0: could not attach to PHY
> SIOCSIFFLAGS: No such device
> 
> To attach PHY node mdio@24520 should not be disabled in dts of core1.
> Because all PHYs are controlled through this node as follows:
> 
> mdio@24520 {
> 	phy0: ethernet-phy@0 {
> 		interrupts = <10 1 0 0>;
> 		reg = <0x0>;
> 	};
> 	phy1: ethernet-phy@1 {
> 		interrupts = <10 1 0 0>;
> 		reg = <0x1>;
> 	};
> 	phy2: ethernet-phy@2 {
> 		interrupts = <10 1 0 0>;
> 		reg = <0x2>;
> 	};
> 	phy3: ethernet-phy@3 {
> 		interrupts = <10 1 0 0>;
> 		reg = <0x3>;
> 	};
> 
> 	tbi0: tbi-phy@11 {
> 		reg = <0x11>;
> 		device_type = "tbi-phy";
> 	};
> };
> 
> Signed-off-by: Li Yang <leoli@freescale.com>
> Signed-off-by: Jia Hongtao <B38951@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts |    3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)

applied to next

- k
Scott Wood July 10, 2012, 6:15 p.m. UTC | #2
On 07/10/2012 01:08 AM, Jia Hongtao wrote:
> The issue log on core1 is:
> root@mpc8572ds:~# ifconfig eth0 10.192.208.244
> net eth0: could not attach to PHY
> SIOCSIFFLAGS: No such device
> 
> To attach PHY node mdio@24520 should not be disabled in dts of core1.
> Because all PHYs are controlled through this node as follows:

So you grant it to both partitions?  How do you deal with synchronization?

-Scott
Hongtao Jia July 11, 2012, 2:07 a.m. UTC | #3
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, July 11, 2012 2:15 AM
> To: Jia Hongtao-B38951
> Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org
> Subject: Re: [PATCH 1/2] powerpc/mpc8572ds: Fix eTSEC is not available on
> core1 of AMP boot issue
> 
> On 07/10/2012 01:08 AM, Jia Hongtao wrote:
> > The issue log on core1 is:
> > root@mpc8572ds:~# ifconfig eth0 10.192.208.244
> > net eth0: could not attach to PHY
> > SIOCSIFFLAGS: No such device
> >
> > To attach PHY node mdio@24520 should not be disabled in dts of core1.
> > Because all PHYs are controlled through this node as follows:
> 
> So you grant it to both partitions?  How do you deal with synchronization?
> 
> -Scott

PHY nodes are only used by ethernet. Each ethernet is used by only one partition
(disabled in the other partition). So I think there is no synchronization issue.

Thanks.
-Jia Hongtao.
Scott Wood July 11, 2012, 5:35 p.m. UTC | #4
On 07/10/2012 09:07 PM, Jia Hongtao-B38951 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Wednesday, July 11, 2012 2:15 AM
>> To: Jia Hongtao-B38951
>> Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org
>> Subject: Re: [PATCH 1/2] powerpc/mpc8572ds: Fix eTSEC is not available on
>> core1 of AMP boot issue
>>
>> On 07/10/2012 01:08 AM, Jia Hongtao wrote:
>>> The issue log on core1 is:
>>> root@mpc8572ds:~# ifconfig eth0 10.192.208.244
>>> net eth0: could not attach to PHY
>>> SIOCSIFFLAGS: No such device
>>>
>>> To attach PHY node mdio@24520 should not be disabled in dts of core1.
>>> Because all PHYs are controlled through this node as follows:
>>
>> So you grant it to both partitions?  How do you deal with synchronization?
>>
>> -Scott
> 
> PHY nodes are only used by ethernet. Each ethernet is used by only one partition
> (disabled in the other partition). So I think there is no synchronization issue.

I mean for accessing the MDIO bus.

-Scott
diff mbox

Patch

diff --git a/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts b/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts
index d6a8faf..1932396 100644
--- a/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts
+++ b/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts
@@ -67,9 +67,6 @@ 
 		ethernet@24000 {
 			status = "disabled";
 		};
-		mdio@24520 {
-			status = "disabled";
-		};
 		ptp_clock@24e00 {
 			status = "disabled";
 		};