diff mbox series

[13/13] global_data.h: remove unnecesary include of cyclic.h

Message ID 20241003212802.3810-14-ravi@prevas.dk
State New
Delegated to: Stefan Roese
Headers show
Series disentangling cyclic API from schedule() | expand

Commit Message

Rasmus Villemoes Oct. 3, 2024, 9:28 p.m. UTC 
Nothing in cyclic.h is needed to define struct global_data, so do not
include that header.

If any .c file relies on getting cyclic.h through asm/global_data.h,
it needs to include it itself.

Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
---
 include/asm-generic/global_data.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Tom Rini Oct. 4, 2024, 5:15 p.m. UTC | #1 
On Thu, Oct 03, 2024 at 11:28:02PM +0200, Rasmus Villemoes wrote:

> Nothing in cyclic.h is needed to define struct global_data, so do not
> include that header.
> 
> If any .c file relies on getting cyclic.h through asm/global_data.h,
> it needs to include it itself.
> 
> Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>

Reviewed-by: Tom Rini <trini@konsulko.com>
diff mbox series

Patch

diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h
index 27aa75e7036..1570ad8f0c0 100644
--- a/include/asm-generic/global_data.h
+++ b/include/asm-generic/global_data.h
@@ -20,7 +20,6 @@ 
  */
 
 #ifndef __ASSEMBLY__
-#include <cyclic.h>
 #include <event_internal.h>
 #include <fdtdec.h>
 #include <membuff.h>