Message ID | 20241003143103.1476805-1-edgar.iglesias@gmail.com |
---|---|
State | New |
Headers | show |
On Thu, 3 Oct 2024 at 15:31, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote: > > From: "Edgar E. Iglesias" <edgar.iglesias@amd.com> > > The following changes since commit 423be09ab9492735924e73a2d36069784441ebc6: > > Merge tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2024-10-03 10:32:54 +0100) > > are available in the Git repository at: > > https://gitlab.com/edgar.iglesias/qemu.git tags/edgar/xen-queue-2024-10-03.for-upstream > > for you to fetch changes up to 507118c2a066b70e8069702c120461ad8c98ccd5: > > hw/arm: xenpvh: Enable PCI for ARM PVH (2024-10-03 15:24:42 +0200) > > ---------------------------------------------------------------- > Edgars Xen Queue. > > ---------------------------------------------------------------- > Dr. David Alan Gilbert (1): > hw/xen: Remove deadcode > > Edgar E. Iglesias (4): > hw/xen: Expose handle_bufioreq in xen_register_ioreq > hw/xen: xenpvh: Disable buffered IOREQs for ARM > hw/xen: xenpvh: Add pci-intx-irq-base property > hw/arm: xenpvh: Enable PCI for ARM PVH Hi; this failed the tsan-build CI job: https://gitlab.com/qemu-project/qemu/-/jobs/7986783747 ../hw/xen/xen-hvm-common.c:711:48: error: variable 'ioreq_pfn' is uninitialized when used here [-Werror,-Wuninitialized] trace_xen_map_ioreq_server_shared_page(ioreq_pfn); ^~~~~~~~~ ../hw/xen/xen-hvm-common.c:667:24: note: initialize the variable 'ioreq_pfn' to silence this warning xen_pfn_t ioreq_pfn; ^ = 0 thanks -- PMM
On Thu, Oct 03, 2024 at 06:07:00PM +0100, Peter Maydell wrote: > On Thu, 3 Oct 2024 at 15:31, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote: > > > > From: "Edgar E. Iglesias" <edgar.iglesias@amd.com> > > > > The following changes since commit 423be09ab9492735924e73a2d36069784441ebc6: > > > > Merge tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2024-10-03 10:32:54 +0100) > > > > are available in the Git repository at: > > > > https://gitlab.com/edgar.iglesias/qemu.git tags/edgar/xen-queue-2024-10-03.for-upstream > > > > for you to fetch changes up to 507118c2a066b70e8069702c120461ad8c98ccd5: > > > > hw/arm: xenpvh: Enable PCI for ARM PVH (2024-10-03 15:24:42 +0200) > > > > ---------------------------------------------------------------- > > Edgars Xen Queue. > > > > ---------------------------------------------------------------- > > Dr. David Alan Gilbert (1): > > hw/xen: Remove deadcode > > > > Edgar E. Iglesias (4): > > hw/xen: Expose handle_bufioreq in xen_register_ioreq > > hw/xen: xenpvh: Disable buffered IOREQs for ARM > > hw/xen: xenpvh: Add pci-intx-irq-base property > > hw/arm: xenpvh: Enable PCI for ARM PVH > > Hi; this failed the tsan-build CI job: > > https://gitlab.com/qemu-project/qemu/-/jobs/7986783747 > > ../hw/xen/xen-hvm-common.c:711:48: error: variable 'ioreq_pfn' is > uninitialized when used here [-Werror,-Wuninitialized] > trace_xen_map_ioreq_server_shared_page(ioreq_pfn); > ^~~~~~~~~ > ../hw/xen/xen-hvm-common.c:667:24: note: initialize the variable > 'ioreq_pfn' to silence this warning > xen_pfn_t ioreq_pfn; > ^ > = 0 > Thanks Peter, I had moved that trace call but forgot to remove the original line. Will send a v2 PR. Cheers, Edgar
From: "Edgar E. Iglesias" <edgar.iglesias@amd.com> The following changes since commit 423be09ab9492735924e73a2d36069784441ebc6: Merge tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2024-10-03 10:32:54 +0100) are available in the Git repository at: https://gitlab.com/edgar.iglesias/qemu.git tags/edgar/xen-queue-2024-10-03.for-upstream for you to fetch changes up to 507118c2a066b70e8069702c120461ad8c98ccd5: hw/arm: xenpvh: Enable PCI for ARM PVH (2024-10-03 15:24:42 +0200) ---------------------------------------------------------------- Edgars Xen Queue. ---------------------------------------------------------------- Dr. David Alan Gilbert (1): hw/xen: Remove deadcode Edgar E. Iglesias (4): hw/xen: Expose handle_bufioreq in xen_register_ioreq hw/xen: xenpvh: Disable buffered IOREQs for ARM hw/xen: xenpvh: Add pci-intx-irq-base property hw/arm: xenpvh: Enable PCI for ARM PVH hw/arm/xen-pvh.c | 17 ++++++ hw/i386/xen/xen-hvm.c | 4 +- hw/i386/xen/xen-pvh.c | 3 ++ hw/xen/xen-hvm-common.c | 101 ++++++++++++++++++++++-------------- hw/xen/xen-legacy-backend.c | 18 ------- hw/xen/xen-pvh-common.c | 40 +++++++++++++- hw/xen/xen_devconfig.c | 8 --- include/hw/xen/xen-hvm-common.h | 3 ++ include/hw/xen/xen-legacy-backend.h | 5 -- include/hw/xen/xen-pvh-common.h | 3 ++ include/hw/xen/xen_native.h | 3 +- 11 files changed, 133 insertions(+), 72 deletions(-)