| Message ID | 20240930132344.3001876-3-andrei.stefanescu@oss.nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: s32: add missing pins and an S32G3 compatible | expand |
On 30/09/2024 15:23, Andrei Stefanescu wrote: > The SIUL2 hardware module is also integrated into the S32G3 SoC. Add > another compatible for it. > > Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> > --- > .../bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml > index a24286e4def6..454773e7aa07 100644 > --- a/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml > @@ -25,8 +25,14 @@ description: | > > properties: > compatible: > - enum: > - - nxp,s32g2-siul2-pinctrl > + oneOf: > + - description: for S32G2 SoCs Drop > + items: That's jus tenum > + - const: nxp,s32g2-siul2-pinctrl Drop > + - description: for S32G3 SoCs > + items: Best regards, Krzysztof
Hi Krzysztof, Thank you for the quick review! On 30/09/2024 16:40, Krzysztof Kozlowski wrote: > On 30/09/2024 15:23, Andrei Stefanescu wrote: >> The SIUL2 hardware module is also integrated into the S32G3 SoC. Add >> another compatible for it. >> >> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> >> --- >> .../bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml >> index a24286e4def6..454773e7aa07 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml >> @@ -25,8 +25,14 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - nxp,s32g2-siul2-pinctrl >> + oneOf: >> + - description: for S32G2 SoCs > > Drop > >> + items: > > That's jus tenum > >> + - const: nxp,s32g2-siul2-pinctrl > > Drop > >> + - description: for S32G3 SoCs >> + items: Just to make sure I understood correctly, it should look something like this, right? oneOf: - enum: - const: nxp,s32g2-siul2-pinctrl - items: - const: nxp,s32g3-siul2-pinctrl - const: nxp,s32g2-siul2-pinctrl > Best regards, > Krzysztof > Best regards, Andrei
On 30/09/2024 16:46, Andrei Stefanescu wrote: > > Just to make sure I understood correctly, it should > look something like this, right? > > oneOf: > - enum: > - const: nxp,s32g2-siul2-pinctrl > - items: > - const: nxp,s32g3-siul2-pinctrl > - const: nxp,s32g2-siul2-pinctrl Yes. Just like we do in other files... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml index a24286e4def6..454773e7aa07 100644 --- a/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml @@ -25,8 +25,14 @@ description: | properties: compatible: - enum: - - nxp,s32g2-siul2-pinctrl + oneOf: + - description: for S32G2 SoCs + items: + - const: nxp,s32g2-siul2-pinctrl + - description: for S32G3 SoCs + items: + - const: nxp,s32g3-siul2-pinctrl + - const: nxp,s32g2-siul2-pinctrl reg: description: |
The SIUL2 hardware module is also integrated into the S32G3 SoC. Add another compatible for it. Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> --- .../bindings/pinctrl/nxp,s32g2-siul2-pinctrl.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)