| Message ID | 20240930025517.3895411-1-acelan.kao@canonical.com |
|---|---|
| Headers | show |
| Series | The system hangs after resume with thunderbolt monitor(AMD GPU [1002:1900]) | expand |
Acked-by: Guoqing Jiang <guoqing.jiang@canonical.com> On 9/30/24 10:55, Chia-Lin Kao (AceLan) wrote: > BugLink: https://bugs.launchpad.net/bugs/2083182 > > [Impact] > The system hangs on blackscreen with thunderbolt monitor while resume from suspend state. > > [Fix] > The TBT monitor HPD will be triggered during the resume procedure > and call the drm_client_modeset_probe() while > struct drm_connector connector->dev->master is NULL. > > It will mess up the pipe topology after resume. > > AMD submitted a patch to fix this issue. > https://lore.kernel.org/all/20240927170103.102180-3-Jerry.Zuo@amd.com/T/#e868f6b967ec79ae85c5a8a446be9b5d5c97e5427 > > [Test case] > 1. Boot to OS > 2. Plug thunderbolt monitor to the system. > 3. Enter suspend > 4. Press the power button to resume from suspend > 5. Should not hang > > [Where problems could occur] > Pretty low chance to introduce any regressions. > The patch won't do anything bad to the system while resuming, > the probing will be done after resumed. > > Tom Chung (1): > UBUNTU: SAUCE: drm/amd/display: Fix system hang while resume with TBT > monitor > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++++++ > 1 file changed, 6 insertions(+) >
Acked-by: Ivan Hu <ivan.hu@canonical.com> On 9/30/24 10:55, Chia-Lin Kao (AceLan) wrote: > BugLink: https://bugs.launchpad.net/bugs/2083182 > > [Impact] > The system hangs on blackscreen with thunderbolt monitor while resume from suspend state. > > [Fix] > The TBT monitor HPD will be triggered during the resume procedure > and call the drm_client_modeset_probe() while > struct drm_connector connector->dev->master is NULL. > > It will mess up the pipe topology after resume. > > AMD submitted a patch to fix this issue. > https://lore.kernel.org/all/20240927170103.102180-3-Jerry.Zuo@amd.com/T/#e868f6b967ec79ae85c5a8a446be9b5d5c97e5427 > > [Test case] > 1. Boot to OS > 2. Plug thunderbolt monitor to the system. > 3. Enter suspend > 4. Press the power button to resume from suspend > 5. Should not hang > > [Where problems could occur] > Pretty low chance to introduce any regressions. > The patch won't do anything bad to the system while resuming, > the probing will be done after resumed. > > Tom Chung (1): > UBUNTU: SAUCE: drm/amd/display: Fix system hang while resume with TBT > monitor > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++++++ > 1 file changed, 6 insertions(+) >
Acked-by: Ivan Hu <ivan.hu@canonical.com> On 9/30/24 10:55, Chia-Lin Kao (AceLan) wrote: > BugLink: https://bugs.launchpad.net/bugs/2083182 > > [Impact] > The system hangs on blackscreen with thunderbolt monitor while resume from suspend state. > > [Fix] > The TBT monitor HPD will be triggered during the resume procedure > and call the drm_client_modeset_probe() while > struct drm_connector connector->dev->master is NULL. > > It will mess up the pipe topology after resume. > > AMD submitted a patch to fix this issue. > https://lore.kernel.org/all/20240927170103.102180-3-Jerry.Zuo@amd.com/T/#e868f6b967ec79ae85c5a8a446be9b5d5c97e5427 > > [Test case] > 1. Boot to OS > 2. Plug thunderbolt monitor to the system. > 3. Enter suspend > 4. Press the power button to resume from suspend > 5. Should not hang > > [Where problems could occur] > Pretty low chance to introduce any regressions. > The patch won't do anything bad to the system while resuming, > the probing will be done after resumed. > > Tom Chung (1): > UBUNTU: SAUCE: drm/amd/display: Fix system hang while resume with TBT > monitor > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++++++ > 1 file changed, 6 insertions(+) >
Chia-Lin Kao (AceLan) kirjoitti 30.9.2024 klo 5.55: > BugLink: https://bugs.launchpad.net/bugs/2083182 > > [Impact] > The system hangs on blackscreen with thunderbolt monitor while resume from suspend state. > > [Fix] > The TBT monitor HPD will be triggered during the resume procedure > and call the drm_client_modeset_probe() while > struct drm_connector connector->dev->master is NULL. > > It will mess up the pipe topology after resume. > > AMD submitted a patch to fix this issue. > https://lore.kernel.org/all/20240927170103.102180-3-Jerry.Zuo@amd.com/T/#e868f6b967ec79ae85c5a8a446be9b5d5c97e5427 > > [Test case] > 1. Boot to OS > 2. Plug thunderbolt monitor to the system. > 3. Enter suspend > 4. Press the power button to resume from suspend > 5. Should not hang > > [Where problems could occur] > Pretty low chance to introduce any regressions. > The patch won't do anything bad to the system while resuming, > the probing will be done after resumed. > > Tom Chung (1): > UBUNTU: SAUCE: drm/amd/display: Fix system hang while resume with TBT > monitor > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > applied to oracular, thanks
BugLink: https://bugs.launchpad.net/bugs/2083182 [Impact] The system hangs on blackscreen with thunderbolt monitor while resume from suspend state. [Fix] The TBT monitor HPD will be triggered during the resume procedure and call the drm_client_modeset_probe() while struct drm_connector connector->dev->master is NULL. It will mess up the pipe topology after resume. AMD submitted a patch to fix this issue. https://lore.kernel.org/all/20240927170103.102180-3-Jerry.Zuo@amd.com/T/#e868f6b967ec79ae85c5a8a446be9b5d5c97e5427 [Test case] 1. Boot to OS 2. Plug thunderbolt monitor to the system. 3. Enter suspend 4. Press the power button to resume from suspend 5. Should not hang [Where problems could occur] Pretty low chance to introduce any regressions. The patch won't do anything bad to the system while resuming, the probing will be done after resumed. Tom Chung (1): UBUNTU: SAUCE: drm/amd/display: Fix system hang while resume with TBT monitor drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++++++ 1 file changed, 6 insertions(+)