diff mbox series

dt-bindings: gpio: st,nomadik-gpio: Add missing "#interrupt-cells" to example

Message ID 20240925173504.1906872-1-robh@kernel.org
State New
Headers show
Series dt-bindings: gpio: st,nomadik-gpio: Add missing "#interrupt-cells" to example | expand

Commit Message

Rob Herring Sept. 25, 2024, 5:35 p.m. UTC 
Enabling dtc interrupt_provider check reveals the example is missing the
"#interrupt-cells" property as it is a dependency of
"interrupt-controller".

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley Sept. 26, 2024, 4:55 p.m. UTC | #1 
On Wed, Sep 25, 2024 at 12:35:03PM -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing the
> "#interrupt-cells" property as it is a dependency of
> "interrupt-controller".
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Linus Walleij Oct. 2, 2024, 1:04 p.m. UTC | #2 
On Wed, Sep 25, 2024 at 7:35 PM Rob Herring (Arm) <robh@kernel.org> wrote:

> Enabling dtc interrupt_provider check reveals the example is missing the
> "#interrupt-cells" property as it is a dependency of
> "interrupt-controller".
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Can you please merge this into the DT git tree?

Yours,
Linus Walleij
Bartosz Golaszewski Oct. 2, 2024, 1:32 p.m. UTC | #3 
On Wed, Oct 2, 2024 at 3:04 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Wed, Sep 25, 2024 at 7:35 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> > Enabling dtc interrupt_provider check reveals the example is missing the
> > "#interrupt-cells" property as it is a dependency of
> > "interrupt-controller".
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Can you please merge this into the DT git tree?
>
> Yours,
> Linus Walleij

It's already upstream. I learned it when I tried picking it up. Rob:
any chance you could send b4 notifications when applying patches to
your tree?

Bartosz
Rob Herring Oct. 2, 2024, 2:22 p.m. UTC | #4 
On Wed, Oct 2, 2024 at 8:32 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Wed, Oct 2, 2024 at 3:04 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > On Wed, Sep 25, 2024 at 7:35 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> >
> > > Enabling dtc interrupt_provider check reveals the example is missing the
> > > "#interrupt-cells" property as it is a dependency of
> > > "interrupt-controller".
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Can you please merge this into the DT git tree?
> >
> > Yours,
> > Linus Walleij
>
> It's already upstream. I learned it when I tried picking it up. Rob:
> any chance you could send b4 notifications when applying patches to
> your tree?

It's not upstream. The ep9301 one is because Arnd applied it.

I do send notifications when applying things. Not using b4 though
because I haven't converted my scripts to it for that yet.

Rob
Bartosz Golaszewski Oct. 2, 2024, 2:28 p.m. UTC | #5 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 25 Sep 2024 12:35:03 -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing the
> "#interrupt-cells" property as it is a dependency of
> "interrupt-controller".
> 
> 

Applied, thanks!

[1/1] dt-bindings: gpio: st,nomadik-gpio: Add missing "#interrupt-cells" to example
      commit: 35c013ac7362a5470d5f30f3da0af50215095121

Best regards,
Bartosz Golaszewski Oct. 2, 2024, 2:29 p.m. UTC | #6 
On Wed, Oct 2, 2024 at 4:22 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Oct 2, 2024 at 8:32 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > On Wed, Oct 2, 2024 at 3:04 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > >
> > > On Wed, Sep 25, 2024 at 7:35 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> > >
> > > > Enabling dtc interrupt_provider check reveals the example is missing the
> > > > "#interrupt-cells" property as it is a dependency of
> > > > "interrupt-controller".
> > > >
> > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > >
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > >
> > > Can you please merge this into the DT git tree?
> > >
> > > Yours,
> > > Linus Walleij
> >
> > It's already upstream. I learned it when I tried picking it up. Rob:
> > any chance you could send b4 notifications when applying patches to
> > your tree?
>
> It's not upstream. The ep9301 one is because Arnd applied it.
>
> I do send notifications when applying things. Not using b4 though
> because I haven't converted my scripts to it for that yet.
>
> Rob

Indeed, I confused the patches. I picked it up into the GPIO tree.

Bartosz
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml b/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml
index 38d37d8f7201..b3e8951959b5 100644
--- a/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml
@@ -89,6 +89,7 @@  examples:
         interrupts = <0 120 0x4>;
         #gpio-cells = <2>;
         gpio-controller;
+        #interrupt-cells = <2>;
         interrupt-controller;
         st,supports-sleepmode;
         gpio-bank = <1>;