mbox series

[SRU,N,0/2] Fix alsa scarlett2 driver in 6.8

Message ID 20240924133157.15168-1-roxana.nicolescu@canonical.com
Headers show
Series Fix alsa scarlett2 driver in 6.8 | expand

Message

Roxana Nicolescu Sept. 24, 2024, 1:31 p.m. UTC
https://bugs.launchpad.net/bugs/2076402

SRU Justification:

[Impact]
Coming from the author of the ALSA scarlett2 driver.
Users have been reporting issues where the driver sometimes fails to
initialize or fails later when being used.
https://github.com/geoffreybennett/scarlett-gen2/issues/15
https://github.com/geoffreybennett/scarlett-gen2/issues/19

[Fix]
Cherry pick these commits:
- 4074f8d23278 ALSA: scarlett2: Move initialisation code lower in the
  source
- 1b65088958ca ALSA: scarlett2: Implement handling of the ACK
    notification
They are clean cherry-picks.

[Test plan]
Not much done here apart from a build test.

[Where problems could occur]
It's been in 6.10 for a while and no problem has been reported.

Geoffrey D. Bennett (2):
  ALSA: scarlett2: Move initialisation code lower in the source
  ALSA: scarlett2: Implement handling of the ACK notification

 sound/usb/mixer_scarlett2.c | 1243 ++++++++++++++++++-----------------
 1 file changed, 649 insertions(+), 594 deletions(-)

Comments

Koichiro Den Sept. 25, 2024, 2:18 a.m. UTC | #1
Acked-by: Koichiro Den <koichiro.den at canonical.com>

On Tue, Sep 24, 2024 at 03:31:55PM +0200, Roxana Nicolescu wrote:
> https://bugs.launchpad.net/bugs/2076402
> 
> SRU Justification:
> 
> [Impact]
> Coming from the author of the ALSA scarlett2 driver.
> Users have been reporting issues where the driver sometimes fails to
> initialize or fails later when being used.
> https://github.com/geoffreybennett/scarlett-gen2/issues/15
> https://github.com/geoffreybennett/scarlett-gen2/issues/19
> 
> [Fix]
> Cherry pick these commits:
> - 4074f8d23278 ALSA: scarlett2: Move initialisation code lower in the
>   source
> - 1b65088958ca ALSA: scarlett2: Implement handling of the ACK
>     notification
> They are clean cherry-picks.
> 
> [Test plan]
> Not much done here apart from a build test.
> 
> [Where problems could occur]
> It's been in 6.10 for a while and no problem has been reported.
> 
> Geoffrey D. Bennett (2):
>   ALSA: scarlett2: Move initialisation code lower in the source
>   ALSA: scarlett2: Implement handling of the ACK notification
> 
>  sound/usb/mixer_scarlett2.c | 1243 ++++++++++++++++++-----------------
>  1 file changed, 649 insertions(+), 594 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Hui Wang Sept. 25, 2024, 7:03 a.m. UTC | #2
Acked-by: Hui Wang <hui.wang@canonical.com>

On 9/24/24 21:31, Roxana Nicolescu wrote:
> https://bugs.launchpad.net/bugs/2076402
>
> SRU Justification:
>
> [Impact]
> Coming from the author of the ALSA scarlett2 driver.
> Users have been reporting issues where the driver sometimes fails to
> initialize or fails later when being used.
> https://github.com/geoffreybennett/scarlett-gen2/issues/15
> https://github.com/geoffreybennett/scarlett-gen2/issues/19
>
> [Fix]
> Cherry pick these commits:
> - 4074f8d23278 ALSA: scarlett2: Move initialisation code lower in the
>    source
> - 1b65088958ca ALSA: scarlett2: Implement handling of the ACK
>      notification
> They are clean cherry-picks.
>
> [Test plan]
> Not much done here apart from a build test.
>
> [Where problems could occur]
> It's been in 6.10 for a while and no problem has been reported.
>
> Geoffrey D. Bennett (2):
>    ALSA: scarlett2: Move initialisation code lower in the source
>    ALSA: scarlett2: Implement handling of the ACK notification
>
>   sound/usb/mixer_scarlett2.c | 1243 ++++++++++++++++++-----------------
>   1 file changed, 649 insertions(+), 594 deletions(-)
>
Stefan Bader Sept. 25, 2024, 12:19 p.m. UTC | #3
On 24.09.24 15:31, Roxana Nicolescu wrote:
> https://bugs.launchpad.net/bugs/2076402
> 
> SRU Justification:
> 
> [Impact]
> Coming from the author of the ALSA scarlett2 driver.
> Users have been reporting issues where the driver sometimes fails to
> initialize or fails later when being used.
> https://github.com/geoffreybennett/scarlett-gen2/issues/15
> https://github.com/geoffreybennett/scarlett-gen2/issues/19
> 
> [Fix]
> Cherry pick these commits:
> - 4074f8d23278 ALSA: scarlett2: Move initialisation code lower in the
>    source
> - 1b65088958ca ALSA: scarlett2: Implement handling of the ACK
>      notification
> They are clean cherry-picks.
> 
> [Test plan]
> Not much done here apart from a build test.
> 
> [Where problems could occur]
> It's been in 6.10 for a while and no problem has been reported.
> 
> Geoffrey D. Bennett (2):
>    ALSA: scarlett2: Move initialisation code lower in the source
>    ALSA: scarlett2: Implement handling of the ACK notification
> 
>   sound/usb/mixer_scarlett2.c | 1243 ++++++++++++++++++-----------------
>   1 file changed, 649 insertions(+), 594 deletions(-)
> 

Applied to noble:linux/master-next. Thanks.

-Stefan