diff mbox series

[RFC] Makefile: trigger re-configure on updated pythondeps

Message ID 20240731140232.22193-1-alex.bennee@linaro.org
State New
Headers show
Series [RFC] Makefile: trigger re-configure on updated pythondeps | expand

Commit Message

Alex Bennée July 31, 2024, 2:02 p.m. UTC
If we add additional deps for meson we need to ensure we trigger a
reconfigure to make sure everything is set up.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson July 31, 2024, 10:13 p.m. UTC | #1
On 8/1/24 00:02, Alex Bennée wrote:
> If we add additional deps for meson we need to ensure we trigger a
> reconfigure to make sure everything is set up.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 02a257584b..0281a883a1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,7 +78,7 @@ x := $(shell rm -rf meson-private meson-info meson-logs)
>   endif
>   
>   # 1. ensure config-host.mak is up-to-date
> -config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/VERSION
> +config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/pythondeps.toml $(SRC_PATH)/VERSION
>   	@echo config-host.mak is out-of-date, running configure
>   	@if test -f meson-private/coredata.dat; then \
>   	  ./config.status --skip-meson; \

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Philippe Mathieu-Daudé Aug. 1, 2024, 5:19 a.m. UTC | #2
On 31/7/24 16:02, Alex Bennée wrote:
> If we add additional deps for meson we need to ensure we trigger a
> reconfigure to make sure everything is set up.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 02a257584b..0281a883a1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,7 +78,7 @@ x := $(shell rm -rf meson-private meson-info meson-logs)
>   endif
>   
>   # 1. ensure config-host.mak is up-to-date
> -config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/VERSION
> +config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/pythondeps.toml $(SRC_PATH)/VERSION

This long line could be split with \, otherwise:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>   	@echo config-host.mak is out-of-date, running configure
>   	@if test -f meson-private/coredata.dat; then \
>   	  ./config.status --skip-meson; \
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 02a257584b..0281a883a1 100644
--- a/Makefile
+++ b/Makefile
@@ -78,7 +78,7 @@  x := $(shell rm -rf meson-private meson-info meson-logs)
 endif
 
 # 1. ensure config-host.mak is up-to-date
-config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/VERSION
+config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/pythondeps.toml $(SRC_PATH)/VERSION
 	@echo config-host.mak is out-of-date, running configure
 	@if test -f meson-private/coredata.dat; then \
 	  ./config.status --skip-meson; \