mbox series

[v5,00/19] Reconstruct loongson ipi driver

Message ID 20240718133312.10324-1-philmd@linaro.org
Headers show
Series Reconstruct loongson ipi driver | expand

Message

Philippe Mathieu-Daudé July 18, 2024, 1:32 p.m. UTC
Since v4:
- Fix build failure due to rebase (Song)
- Loongarch -> LoongArch (Song)
- Added Song's tags

Since v3:
- Use DEFINE_TYPES() macro (unreviewed patch #1)
- Update MAINTAINERS
- Added Bibo's tags

Thanks,

Phil.

Bibo Mao (16):
  hw/intc/loongson_ipi: Access memory in little endian
  hw/intc/loongson_ipi: Rename LoongsonIPI -> LoongsonIPIState
  hw/intc/loongson_ipi: Extract loongson_ipi_common_finalize()
  hw/intc/loongson_ipi: Extract loongson_ipi_common_realize()
  hw/intc/loongson_ipi: Add TYPE_LOONGSON_IPI_COMMON stub
  hw/intc/loongson_ipi: Move common definitions to loongson_ipi_common.h
  hw/intc/loongson_ipi: Move IPICore::mmio_mem to LoongsonIPIState
  hw/intc/loongson_ipi: Move IPICore structure to loongson_ipi_common.h
  hw/intc/loongson_ipi: Pass LoongsonIPICommonState to send_ipi_data()
  hw/intc/loongson_ipi: Add LoongsonIPICommonClass::get_iocsr_as handler
  hw/intc/loongson_ipi: Add LoongsonIPICommonClass::cpu_by_arch_id
    handler
  hw/intc/loongson_ipi: Expose loongson_ipi_core_read/write helpers
  hw/intc/loongson_ipi: Move common code to loongson_ipi_common.c
  hw/intc/loongarch_ipi: Add loongarch IPI support
  hw/loongarch/virt: Replace Loongson IPI with LoongArch IPI
  hw/intc/loongson_ipi: Restrict to MIPS

Philippe Mathieu-Daudé (3):
  hw/intc/loongson_ipi: Declare QOM types using DEFINE_TYPES() macro
  hw/intc/loongson_ipi: Remove unused headers
  docs: Correct Loongarch -> LoongArch

 MAINTAINERS                           |   6 +-
 docs/about/emulation.rst              |   2 +-
 include/hw/intc/loongarch_ipi.h       |  25 ++
 include/hw/intc/loongson_ipi.h        |  50 +---
 include/hw/intc/loongson_ipi_common.h |  72 ++++++
 include/hw/loongarch/virt.h           |   1 -
 hw/intc/loongarch_ipi.c               |  68 +++++
 hw/intc/loongson_ipi.c                | 355 +++-----------------------
 hw/intc/loongson_ipi_common.c         | 344 +++++++++++++++++++++++++
 hw/loongarch/virt.c                   |   4 +-
 hw/rtc/ls7a_rtc.c                     |   2 +-
 hw/intc/Kconfig                       |   8 +
 hw/intc/meson.build                   |   2 +
 hw/loongarch/Kconfig                  |   2 +-
 14 files changed, 570 insertions(+), 371 deletions(-)
 create mode 100644 include/hw/intc/loongarch_ipi.h
 create mode 100644 include/hw/intc/loongson_ipi_common.h
 create mode 100644 hw/intc/loongarch_ipi.c
 create mode 100644 hw/intc/loongson_ipi_common.c

Comments

Richard Henderson July 18, 2024, 10:54 p.m. UTC | #1
On 7/18/24 23:32, Philippe Mathieu-Daudé wrote:
> Since v4:
> - Fix build failure due to rebase (Song)
> - Loongarch -> LoongArch (Song)
> - Added Song's tags
> 
> Since v3:
> - Use DEFINE_TYPES() macro (unreviewed patch #1)
> - Update MAINTAINERS
> - Added Bibo's tags

Ho hum, I didn't notice v5 when I just reviewed v4.

For the series:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Jiaxun Yang July 19, 2024, 12:56 p.m. UTC | #2
在2024年7月18日七月 下午9:32,Philippe Mathieu-Daudé写道:
> Since v4:
> - Fix build failure due to rebase (Song)
> - Loongarch -> LoongArch (Song)
> - Added Song's tags
>
> Since v3:
> - Use DEFINE_TYPES() macro (unreviewed patch #1)
> - Update MAINTAINERS
> - Added Bibo's tags

For the whole series:

Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks! Tested on MIPS loongson3-virt with 2, 4 CPUs, all working fine.

I'll get this covered by CI later.
- Jiaxun

>
> Thanks,
>
> Phil.
>
> Bibo Mao (16):
>   hw/intc/loongson_ipi: Access memory in little endian
>   hw/intc/loongson_ipi: Rename LoongsonIPI -> LoongsonIPIState
>   hw/intc/loongson_ipi: Extract loongson_ipi_common_finalize()
>   hw/intc/loongson_ipi: Extract loongson_ipi_common_realize()
>   hw/intc/loongson_ipi: Add TYPE_LOONGSON_IPI_COMMON stub
>   hw/intc/loongson_ipi: Move common definitions to loongson_ipi_common.h
>   hw/intc/loongson_ipi: Move IPICore::mmio_mem to LoongsonIPIState
>   hw/intc/loongson_ipi: Move IPICore structure to loongson_ipi_common.h
>   hw/intc/loongson_ipi: Pass LoongsonIPICommonState to send_ipi_data()
>   hw/intc/loongson_ipi: Add LoongsonIPICommonClass::get_iocsr_as handler
>   hw/intc/loongson_ipi: Add LoongsonIPICommonClass::cpu_by_arch_id
>     handler
>   hw/intc/loongson_ipi: Expose loongson_ipi_core_read/write helpers
>   hw/intc/loongson_ipi: Move common code to loongson_ipi_common.c
>   hw/intc/loongarch_ipi: Add loongarch IPI support
>   hw/loongarch/virt: Replace Loongson IPI with LoongArch IPI
>   hw/intc/loongson_ipi: Restrict to MIPS
>
> Philippe Mathieu-Daudé (3):
>   hw/intc/loongson_ipi: Declare QOM types using DEFINE_TYPES() macro
>   hw/intc/loongson_ipi: Remove unused headers
>   docs: Correct Loongarch -> LoongArch
>
>  MAINTAINERS                           |   6 +-
>  docs/about/emulation.rst              |   2 +-
>  include/hw/intc/loongarch_ipi.h       |  25 ++
>  include/hw/intc/loongson_ipi.h        |  50 +---
>  include/hw/intc/loongson_ipi_common.h |  72 ++++++
>  include/hw/loongarch/virt.h           |   1 -
>  hw/intc/loongarch_ipi.c               |  68 +++++
>  hw/intc/loongson_ipi.c                | 355 +++-----------------------
>  hw/intc/loongson_ipi_common.c         | 344 +++++++++++++++++++++++++
>  hw/loongarch/virt.c                   |   4 +-
>  hw/rtc/ls7a_rtc.c                     |   2 +-
>  hw/intc/Kconfig                       |   8 +
>  hw/intc/meson.build                   |   2 +
>  hw/loongarch/Kconfig                  |   2 +-
>  14 files changed, 570 insertions(+), 371 deletions(-)
>  create mode 100644 include/hw/intc/loongarch_ipi.h
>  create mode 100644 include/hw/intc/loongson_ipi_common.h
>  create mode 100644 hw/intc/loongarch_ipi.c
>  create mode 100644 hw/intc/loongson_ipi_common.c
>
> -- 
> 2.41.0
Philippe Mathieu-Daudé July 19, 2024, 1:04 p.m. UTC | #3
On 19/7/24 14:56, Jiaxun Yang wrote:
> 
> 
> 在2024年7月18日七月 下午9:32,Philippe Mathieu-Daudé写道:
>> Since v4:
>> - Fix build failure due to rebase (Song)
>> - Loongarch -> LoongArch (Song)
>> - Added Song's tags
>>
>> Since v3:
>> - Use DEFINE_TYPES() macro (unreviewed patch #1)
>> - Update MAINTAINERS
>> - Added Bibo's tags
> 
> For the whole series:
> 
> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Yeah!

> Thanks! Tested on MIPS loongson3-virt with 2, 4 CPUs, all working fine.
> 
> I'll get this covered by CI later.

Thanks,

I'm queuing this series.
Philippe Mathieu-Daudé July 23, 2024, 10:19 a.m. UTC | #4
On 19/7/24 15:04, Philippe Mathieu-Daudé wrote:
> On 19/7/24 14:56, Jiaxun Yang wrote:
>>
>>
>> 在2024年7月18日七月 下午9:32,Philippe Mathieu-Daudé写道:
>>> Since v4:
>>> - Fix build failure due to rebase (Song)
>>> - Loongarch -> LoongArch (Song)
>>> - Added Song's tags
>>>
>>> Since v3:
>>> - Use DEFINE_TYPES() macro (unreviewed patch #1)
>>> - Update MAINTAINERS
>>> - Added Bibo's tags
>>
>> For the whole series:
>>
>> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> 
> Yeah!
> 
>> Thanks! Tested on MIPS loongson3-virt with 2, 4 CPUs, all working fine.
>>
>> I'll get this covered by CI later.
> 
> Thanks,
> 
> I'm queuing this series.

Due to pre-existing bug I have to drop this series :(

See 
https://lore.kernel.org/qemu-devel/492e9968-a05d-44b2-b374-1d839e49b6e3@linaro.org/.
Song Gao Aug. 2, 2024, 3:07 a.m. UTC | #5
在 2024/7/23 下午6:19, Philippe Mathieu-Daudé 写道:
> On 19/7/24 15:04, Philippe Mathieu-Daudé wrote:
>> On 19/7/24 14:56, Jiaxun Yang wrote:
>>>
>>>
>>> 在2024年7月18日七月 下午9:32,Philippe Mathieu-Daudé写道:
>>>> Since v4:
>>>> - Fix build failure due to rebase (Song)
>>>> - Loongarch -> LoongArch (Song)
>>>> - Added Song's tags
>>>>
>>>> Since v3:
>>>> - Use DEFINE_TYPES() macro (unreviewed patch #1)
>>>> - Update MAINTAINERS
>>>> - Added Bibo's tags
>>>
>>> For the whole series:
>>>
>>> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>> Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>
>> Yeah!
>>
>>> Thanks! Tested on MIPS loongson3-virt with 2, 4 CPUs, all working fine.
>>>
>>> I'll get this covered by CI later.
>>
>> Thanks,
>>
>> I'm queuing this series.
>
> Due to pre-existing bug I have to drop this series :(
>
> See 
> https://lore.kernel.org/qemu-devel/492e9968-a05d-44b2-b374-1d839e49b6e3@linaro.org/.
Hi,  Philippe

This series is not merged, the bug still exists, if you don't want to 
merge this series for 9.1, can you fix this bug first?

Thanks.
Song Gao
Philippe Mathieu-Daudé Aug. 2, 2024, 4:30 p.m. UTC | #6
On 2/8/24 05:07, gaosong wrote:
> 在 2024/7/23 下午6:19, Philippe Mathieu-Daudé 写道:
>> On 19/7/24 15:04, Philippe Mathieu-Daudé wrote:
>>> On 19/7/24 14:56, Jiaxun Yang wrote:

>>>> For the whole series:
>>>>
>>>> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>>> Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>>
>>> Yeah!
>>>
>>>> Thanks! Tested on MIPS loongson3-virt with 2, 4 CPUs, all working fine.
>>>>
>>>> I'll get this covered by CI later.
>>>
>>> Thanks,
>>>
>>> I'm queuing this series.
>>
>> Due to pre-existing bug I have to drop this series :(
>>
>> See 
>> https://lore.kernel.org/qemu-devel/492e9968-a05d-44b2-b374-1d839e49b6e3@linaro.org/.
> Hi,  Philippe
> 
> This series is not merged, the bug still exists, if you don't want to 
> merge this series for 9.1, can you fix this bug first?

I haven't forgotten, I tried but I'm still getting a failure when
testing. Since I'm probably too tired to spot the mistake, I'll
post and let someone else help finding it.