mbox series

[v7,0/4] VT-d minor fixes

Message ID 20240709142557.317271-1-clement.mathieu--drif@eviden.com
Headers show
Series VT-d minor fixes | expand

Message

CLEMENT MATHIEU--DRIF July 9, 2024, 2:26 p.m. UTC 
From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>

Various fixes for VT-d

This series contains fixes that will be necessary
when adding in-guest (fully emulated) SVM support.

v7
    intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
    	- Edit commit message

v6
    intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
    	- Add 'Fixes' tag

v5
    intel_iommu: fix FRCD construction macro:
    	- Remove empty line after 'Fixes'
    
    intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
    	- Edit commit message after comment from Yi
    
    intel_iommu: make types match:
    	- Edit commit message (s/"make types match"/"make type match"/)

v4
    - Move declarations of VTD_FRCD_PV and VTD_FRCD_PP
    - intel_iommu: make types match:
    	- edit commit message to explain that we are not fixing a bug
    - intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
    	- edit commit message

v3
    FRCD construction macro :
    	- Longer sha1 for the 'Fixes' tag
    	- Add '.' at the end of the sentence
    
    Make types match :
    	- Split into 2 patches (one for the fix and one for type matching)
    
    Remove patch for wait descriptor handling (will be in the PRI series)

v2
    Make commit author consistent



Clément Mathieu--Drif (4):
  intel_iommu: fix FRCD construction macro
  intel_iommu: move VTD_FRCD_PV and VTD_FRCD_PP declarations
  intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
  intel_iommu: make type match

 hw/i386/intel_iommu.c          | 2 +-
 hw/i386/intel_iommu_internal.h | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

CLEMENT MATHIEU--DRIF July 15, 2024, 8:48 a.m. UTC | #1 
Hi Michael, Yi and Jason

Thanks for your feedback on the previous versions.
If you agree with the series, do you think we can move forward?

Thanks!
 >cmd

On 09/07/2024 16:26, CLEMENT MATHIEU--DRIF wrote:
> From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
>
> Various fixes for VT-d
>
> This series contains fixes that will be necessary
> when adding in-guest (fully emulated) SVM support.
>
> v7
>      intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
>      	- Edit commit message
>
> v6
>      intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
>      	- Add 'Fixes' tag
>
> v5
>      intel_iommu: fix FRCD construction macro:
>      	- Remove empty line after 'Fixes'
>      
>      intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
>      	- Edit commit message after comment from Yi
>      
>      intel_iommu: make types match:
>      	- Edit commit message (s/"make types match"/"make type match"/)
>
> v4
>      - Move declarations of VTD_FRCD_PV and VTD_FRCD_PP
>      - intel_iommu: make types match:
>      	- edit commit message to explain that we are not fixing a bug
>      - intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
>      	- edit commit message
>
> v3
>      FRCD construction macro :
>      	- Longer sha1 for the 'Fixes' tag
>      	- Add '.' at the end of the sentence
>      
>      Make types match :
>      	- Split into 2 patches (one for the fix and one for type matching)
>      
>      Remove patch for wait descriptor handling (will be in the PRI series)
>
> v2
>      Make commit author consistent
>
>
>
> Clément Mathieu--Drif (4):
>    intel_iommu: fix FRCD construction macro
>    intel_iommu: move VTD_FRCD_PV and VTD_FRCD_PP declarations
>    intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
>    intel_iommu: make type match
>
>   hw/i386/intel_iommu.c          | 2 +-
>   hw/i386/intel_iommu_internal.h | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
Michael S. Tsirkin July 15, 2024, 8:51 a.m. UTC | #2 
On Mon, Jul 15, 2024 at 08:48:52AM +0000, CLEMENT MATHIEU--DRIF wrote:
> Hi Michael, Yi and Jason
> 
> Thanks for your feedback on the previous versions.
> If you agree with the series, do you think we can move forward?


Yes, tagged, thanks!

> Thanks!
>  >cmd
> 
> On 09/07/2024 16:26, CLEMENT MATHIEU--DRIF wrote:
> > From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
> >
> > Various fixes for VT-d
> >
> > This series contains fixes that will be necessary
> > when adding in-guest (fully emulated) SVM support.
> >
> > v7
> >      intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
> >      	- Edit commit message
> >
> > v6
> >      intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
> >      	- Add 'Fixes' tag
> >
> > v5
> >      intel_iommu: fix FRCD construction macro:
> >      	- Remove empty line after 'Fixes'
> >      
> >      intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo:
> >      	- Edit commit message after comment from Yi
> >      
> >      intel_iommu: make types match:
> >      	- Edit commit message (s/"make types match"/"make type match"/)
> >
> > v4
> >      - Move declarations of VTD_FRCD_PV and VTD_FRCD_PP
> >      - intel_iommu: make types match:
> >      	- edit commit message to explain that we are not fixing a bug
> >      - intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
> >      	- edit commit message
> >
> > v3
> >      FRCD construction macro :
> >      	- Longer sha1 for the 'Fixes' tag
> >      	- Add '.' at the end of the sentence
> >      
> >      Make types match :
> >      	- Split into 2 patches (one for the fix and one for type matching)
> >      
> >      Remove patch for wait descriptor handling (will be in the PRI series)
> >
> > v2
> >      Make commit author consistent
> >
> >
> >
> > Clément Mathieu--Drif (4):
> >    intel_iommu: fix FRCD construction macro
> >    intel_iommu: move VTD_FRCD_PV and VTD_FRCD_PP declarations
> >    intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
> >    intel_iommu: make type match
> >
> >   hw/i386/intel_iommu.c          | 2 +-
> >   hw/i386/intel_iommu_internal.h | 6 +++---
> >   2 files changed, 4 insertions(+), 4 deletions(-)
> >