mbox series

[v46,0/5] hw/sd/sdcard: Cleanups before adding eMMC support

Message ID 20240703134356.85972-1-philmd@linaro.org
Headers show
Series hw/sd/sdcard: Cleanups before adding eMMC support | expand

Message

Philippe Mathieu-Daudé July 3, 2024, 1:43 p.m. UTC 
(patches from v42 already reviewed not reposted)

Since v45:
- RAZ/WI on GEN_CMD (Luc & Manos)
- Rename sd_cmd_SEND_OP_COND
- Introduce TYPE_SDMMC_COMMON

Philippe Mathieu-Daudé (5):
  hw/sd/sdcard: Use spec v3.01 by default
  hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56)
  hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler
  hw/sd/sdcard: Introduce set_csd/set_cid handlers
  hw/sd/sdcard: Extract TYPE_SDMMC_COMMON from TYPE_SD_CARD

 hw/sd/sdmmc-internal.h |   3 ++
 include/hw/sd/sd.h     |   2 +
 hw/core/machine.c      |   1 +
 hw/sd/core.c           |  29 ++++++-----
 hw/sd/sd.c             | 113 ++++++++++++++++++++++-------------------
 5 files changed, 81 insertions(+), 67 deletions(-)

Comments

Philippe Mathieu-Daudé July 5, 2024, 1:30 p.m. UTC | #1 
On 3/7/24 15:43, Philippe Mathieu-Daudé wrote:
> (patches from v42 already reviewed not reposted)
> 
> Since v45:
> - RAZ/WI on GEN_CMD (Luc & Manos)
> - Rename sd_cmd_SEND_OP_COND
> - Introduce TYPE_SDMMC_COMMON
> 
> Philippe Mathieu-Daudé (5):
>    hw/sd/sdcard: Use spec v3.01 by default
>    hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56)
>    hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler
>    hw/sd/sdcard: Introduce set_csd/set_cid handlers
>    hw/sd/sdcard: Extract TYPE_SDMMC_COMMON from TYPE_SD_CARD

Per 
https://lore.kernel.org/qemu-devel/c434c7e88153a134bc6ba2dc202595211702398c.camel@codeconstruct.com.au/
Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au>

:)
Cédric Le Goater July 5, 2024, 2:18 p.m. UTC | #2 
On 7/3/24 3:43 PM, Philippe Mathieu-Daudé wrote:
> (patches from v42 already reviewed not reposted)
> 
> Since v45:
> - RAZ/WI on GEN_CMD (Luc & Manos)
> - Rename sd_cmd_SEND_OP_COND
> - Introduce TYPE_SDMMC_COMMON
> 
> Philippe Mathieu-Daudé (5):
>    hw/sd/sdcard: Use spec v3.01 by default
>    hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56)
>    hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler
>    hw/sd/sdcard: Introduce set_csd/set_cid handlers
>    hw/sd/sdcard: Extract TYPE_SDMMC_COMMON from TYPE_SD_CARD
> 
>   hw/sd/sdmmc-internal.h |   3 ++
>   include/hw/sd/sd.h     |   2 +
>   hw/core/machine.c      |   1 +
>   hw/sd/core.c           |  29 ++++++-----
>   hw/sd/sd.c             | 113 ++++++++++++++++++++++-------------------
>   5 files changed, 81 insertions(+), 67 deletions(-)
> 


Tested-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.
Philippe Mathieu-Daudé July 5, 2024, 10:02 p.m. UTC | #3 
On 3/7/24 15:43, Philippe Mathieu-Daudé wrote:

> Philippe Mathieu-Daudé (5):
>    hw/sd/sdcard: Use spec v3.01 by default
>    hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56)
>    hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler
>    hw/sd/sdcard: Introduce set_csd/set_cid handlers
>    hw/sd/sdcard: Extract TYPE_SDMMC_COMMON from TYPE_SD_CARD

Series queued, thanks.