diff mbox series

[v3,2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

Message ID 20240530-fsl-ifc-config-v3-2-1fd2c3d233dd@geanix.com (mailing list archive)
State Accepted
Commit 45547a0a93d85f704b49788cde2e1d9ab9cd363b
Headers show
Series memory: fsl_ifc: Make FSL_IFC config visible and selectable | expand

Commit Message

Esben Haabendal May 30, 2024, 2:46 p.m. UTC
With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
selected in defconfigs.

Signed-off-by: Esben Haabendal <esben@geanix.com>
---
 arch/powerpc/configs/85xx-hw.config | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski July 2, 2024, 7 a.m. UTC | #1
On 30/05/2024 16:46, Esben Haabendal wrote:
> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
> selected in defconfigs.
> 
> Signed-off-by: Esben Haabendal <esben@geanix.com>

Anyone is going to pick this up?

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Michael Ellerman July 2, 2024, 12:01 p.m. UTC | #2
Krzysztof Kozlowski <krzk@kernel.org> writes:
> On 30/05/2024 16:46, Esben Haabendal wrote:
>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
>> selected in defconfigs.
>> 
>> Signed-off-by: Esben Haabendal <esben@geanix.com>
>
> Anyone is going to pick this up?

Doesn't it need to be merged along with patch 1?

cheers
Krzysztof Kozlowski July 2, 2024, 12:33 p.m. UTC | #3
On 02/07/2024 14:01, Michael Ellerman wrote:
> Krzysztof Kozlowski <krzk@kernel.org> writes:
>> On 30/05/2024 16:46, Esben Haabendal wrote:
>>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
>>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
>>> selected in defconfigs.
>>>
>>> Signed-off-by: Esben Haabendal <esben@geanix.com>
>>
>> Anyone is going to pick this up?
> 
> Doesn't it need to be merged along with patch 1?

Well, it's late to talk about this... I replied 3 weeks ago, when taking
the first patch, that I don't consider defconfig as a guaranteed feature
thus no hard-bisectability requirement. Three weeks and no comments on
that, so no, this does not have to be merged with patch 1.

The best if it goes the same cycle, though. So for v6.11.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx-hw.config
index 524db76f47b7..8aff83217397 100644
--- a/arch/powerpc/configs/85xx-hw.config
+++ b/arch/powerpc/configs/85xx-hw.config
@@ -24,6 +24,7 @@  CONFIG_FS_ENET=y
 CONFIG_FSL_CORENET_CF=y
 CONFIG_FSL_DMA=y
 CONFIG_FSL_HV_MANAGER=y
+CONFIG_FSL_IFC=y
 CONFIG_FSL_PQ_MDIO=y
 CONFIG_FSL_RIO=y
 CONFIG_FSL_XGMAC_MDIO=y
@@ -58,6 +59,7 @@  CONFIG_INPUT_FF_MEMLESS=m
 CONFIG_MARVELL_PHY=y
 CONFIG_MDIO_BUS_MUX_GPIO=y
 CONFIG_MDIO_BUS_MUX_MMIOREG=y
+CONFIG_MEMORY=y
 CONFIG_MMC_SDHCI_OF_ESDHC=y
 CONFIG_MMC_SDHCI_PLTFM=y
 CONFIG_MMC_SDHCI=y