Message ID | 20240617204302.12323-5-kowal@linux.vnet.ibm.com |
---|---|
State | New |
Headers | show |
Series | XIVE changes for Cache Watch, VSTs, STT and info pic | expand |
On 6/17/24 10:43 PM, Michael Kowal wrote: > From: Frederic Barrat <fbarrat@linux.ibm.com> > > Fail VST entry address computatio if firmware doesn't define a descriptor computation > for one of the Virtualization Structure Tables (VST), there's no point in > trying to compute the address of its entry. Abort the operation and log > an error. > > Signed-off-by: Michael Kowal <kowal@linux.vnet.ibm.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > hw/intc/pnv_xive2.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c > index a1146311a3..e473109196 100644 > --- a/hw/intc/pnv_xive2.c > +++ b/hw/intc/pnv_xive2.c > @@ -244,6 +244,11 @@ static uint64_t pnv_xive2_vst_addr(PnvXive2 *xive, uint32_t type, uint8_t blk, > } > > vsd = xive->vsds[type][blk]; > + if (vsd == 0) { > + xive2_error(xive, "VST: vsd == 0 block id %d for VST %s %d !?", > + blk, info->name, idx); > + return 0; > + } > > /* Remote VST access */ > if (GETFIELD(VSD_MODE, vsd) == VSD_MODE_FORWARD) {
diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c index a1146311a3..e473109196 100644 --- a/hw/intc/pnv_xive2.c +++ b/hw/intc/pnv_xive2.c @@ -244,6 +244,11 @@ static uint64_t pnv_xive2_vst_addr(PnvXive2 *xive, uint32_t type, uint8_t blk, } vsd = xive->vsds[type][blk]; + if (vsd == 0) { + xive2_error(xive, "VST: vsd == 0 block id %d for VST %s %d !?", + blk, info->name, idx); + return 0; + } /* Remote VST access */ if (GETFIELD(VSD_MODE, vsd) == VSD_MODE_FORWARD) {