mbox

[PULL,00/19] aspeed queue

Message ID 20240614072620.1262053-1-clg@redhat.com
State New
Headers show

Pull-request

https://github.com/legoater/qemu/ tags/pull-aspeed-20240614

Message

Cédric Le Goater June 14, 2024, 7:26 a.m. UTC 
The following changes since commit 046a64b9801343e2e89eef10c7a48eec8d8c0d4f:

  Merge tag 'pull-request-2024-06-12' of https://gitlab.com/thuth/qemu into staging (2024-06-13 07:51:58 -0700)

are available in the Git repository at:

  https://github.com/legoater/qemu/ tags/pull-aspeed-20240614

for you to fetch changes up to d9f6311f5393da897e73be8a29c261125d0c1ac2:

  MAINTAINERS: Add reviewers for ASPEED BMCs (2024-06-14 07:36:09 +0200)

----------------------------------------------------------------
aspeed queue:

* Add AST2700 support

----------------------------------------------------------------
Cédric Le Goater (1):
      aspeed/smc: Reintroduce "dram-base" property for AST2700

Jamin Lin (18):
      aspeed/wdt: Add AST2700 support
      aspeed/sli: Add AST2700 support
      aspeed/sdmc: remove redundant macros
      aspeed/sdmc: fix coding style
      aspeed/sdmc: Add AST2700 support
      aspeed/smc: correct device description
      aspeed/smc: support dma start length and 1 byte length unit
      aspeed/smc: support 64 bits dma dram address
      aspeed/smc: support different memory region ops for SMC flash region
      aspeed/smc: Add AST2700 support
      aspeed/scu: Add AST2700 support
      aspeed/intc: Add AST2700 support
      aspeed/soc: Add AST2700 support
      aspeed: Add an AST2700 eval board
      aspeed/soc: fix incorrect dram size for AST2700
      test/avocado/machine_aspeed.py: Add AST2700 test case
      docs:aspeed: Add AST2700 Evaluation board
      MAINTAINERS: Add reviewers for ASPEED BMCs

 MAINTAINERS                      |   3 +
 docs/system/arm/aspeed.rst       |  39 ++-
 include/hw/arm/aspeed_soc.h      |  30 +-
 include/hw/intc/aspeed_intc.h    |  44 +++
 include/hw/misc/aspeed_scu.h     |  47 ++-
 include/hw/misc/aspeed_sdmc.h    |   5 +-
 include/hw/misc/aspeed_sli.h     |  27 ++
 include/hw/ssi/aspeed_smc.h      |   3 +
 include/hw/watchdog/wdt_aspeed.h |   3 +-
 hw/arm/aspeed.c                  |  32 ++
 hw/arm/aspeed_ast27x0.c          | 648 +++++++++++++++++++++++++++++++++++++++
 hw/intc/aspeed_intc.c            | 360 ++++++++++++++++++++++
 hw/misc/aspeed_scu.c             | 306 +++++++++++++++++-
 hw/misc/aspeed_sdmc.c            | 220 +++++++++++--
 hw/misc/aspeed_sli.c             | 177 +++++++++++
 hw/ssi/aspeed_smc.c              | 347 +++++++++++++++++++--
 hw/watchdog/wdt_aspeed.c         |  24 ++
 hw/arm/meson.build               |   1 +
 hw/intc/meson.build              |   1 +
 hw/intc/trace-events             |  13 +
 hw/misc/meson.build              |   3 +-
 hw/misc/trace-events             |  11 +
 hw/ssi/trace-events              |   2 +-
 tests/avocado/machine_aspeed.py  |  62 ++++
 24 files changed, 2350 insertions(+), 58 deletions(-)
 create mode 100644 include/hw/intc/aspeed_intc.h
 create mode 100644 include/hw/misc/aspeed_sli.h
 create mode 100644 hw/arm/aspeed_ast27x0.c
 create mode 100644 hw/intc/aspeed_intc.c
 create mode 100644 hw/misc/aspeed_sli.c

Comments

Richard Henderson June 15, 2024, 4:14 p.m. UTC | #1 
On 6/14/24 00:26, Cédric Le Goater wrote:
> The following changes since commit 046a64b9801343e2e89eef10c7a48eec8d8c0d4f:
> 
>    Merge tag 'pull-request-2024-06-12' of https://gitlab.com/thuth/qemu into staging (2024-06-13 07:51:58 -0700)
> 
> are available in the Git repository at:
> 
>    https://github.com/legoater/qemu/ tags/pull-aspeed-20240614
> 
> for you to fetch changes up to d9f6311f5393da897e73be8a29c261125d0c1ac2:
> 
>    MAINTAINERS: Add reviewers for ASPEED BMCs (2024-06-14 07:36:09 +0200)
> 
> ----------------------------------------------------------------
> aspeed queue:
> 
> * Add AST2700 support

Fails freebsd testing:

https://gitlab.com/qemu-project/qemu/-/jobs/7106081732

I'm not sure off hand why this wouldn't also fail on Linux...


r~
Cédric Le Goater June 15, 2024, 9:56 p.m. UTC | #2 
On 6/15/24 6:14 PM, Richard Henderson wrote:
> On 6/14/24 00:26, Cédric Le Goater wrote:
>> The following changes since commit 046a64b9801343e2e89eef10c7a48eec8d8c0d4f:
>>
>>    Merge tag 'pull-request-2024-06-12' of https://gitlab.com/thuth/qemu into staging (2024-06-13 07:51:58 -0700)
>>
>> are available in the Git repository at:
>>
>>    https://github.com/legoater/qemu/ tags/pull-aspeed-20240614
>>
>> for you to fetch changes up to d9f6311f5393da897e73be8a29c261125d0c1ac2:
>>
>>    MAINTAINERS: Add reviewers for ASPEED BMCs (2024-06-14 07:36:09 +0200)
>>
>> ----------------------------------------------------------------
>> aspeed queue:
>>
>> * Add AST2700 support
> 
> Fails freebsd testing:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/7106081732
> 
> I'm not sure off hand why this wouldn't also fail on Linux...

Yep. It should have :

@@ -332,6 +332,7 @@ static const TypeInfo aspeed_intc_info =
      .instance_init = aspeed_intc_instance_init,
      .instance_size = sizeof(AspeedINTCState),
      .class_init = aspeed_intc_class_init,
+    .class_size    = sizeof(AspeedINTCClass),
      .abstract = true,
  };


I will resend a v2 next week.

C.