mbox series

[v1,0/3] util/readline.c: Add common but missing shortcuts

Message ID readline-shortcuts-v1.1718265822.manos.pitsidianakis@linaro.org
Headers show
Series util/readline.c: Add common but missing shortcuts | expand

Message

Manos Pitsidianakis June 13, 2024, 8:06 a.m. UTC 
Some commonly used readline shortcuts are missing from our 
implementation. This series adds:

- Control-n next line, same as Down arrow key
- Control-p previous line, same as Up arrow key
- Control-u erase line starting from cursor

Manos Pitsidianakis (3):
  util/readline.c:fix lints for readline_handle_byte
  util/readline.c: add C-n, C-p shortcuts
  util/readline.c: add C-u shortcut

 util/readline.c | 35 +++++++++++++++++++++++++++++++----
 1 file changed, 31 insertions(+), 4 deletions(-)


base-commit: f3e8cc47de2bc537d4991e883a85208e4e1c0f98

Comments

Marc-André Lureau June 13, 2024, 1:08 p.m. UTC | #1 
Hi

On Thu, Jun 13, 2024 at 12:07 PM Manos Pitsidianakis <
manos.pitsidianakis@linaro.org> wrote:

> Some commonly used readline shortcuts are missing from our
> implementation. This series adds:
>
> - Control-n next line, same as Down arrow key
> - Control-p previous line, same as Up arrow key
> - Control-u erase line starting from cursor
>
> Manos Pitsidianakis (3):
>   util/readline.c:fix lints for readline_handle_byte
>   util/readline.c: add C-n, C-p shortcuts
>   util/readline.c: add C-u shortcut
>
>  util/readline.c | 35 +++++++++++++++++++++++++++++++----
>  1 file changed, 31 insertions(+), 4 deletions(-)
>
>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Philippe Mathieu-Daudé June 18, 2024, 10:40 a.m. UTC | #2 
On 13/6/24 10:06, Manos Pitsidianakis wrote:
> Some commonly used readline shortcuts are missing from our
> implementation. This series adds:
> 
> - Control-n next line, same as Down arrow key
> - Control-p previous line, same as Up arrow key
> - Control-u erase line starting from cursor
> 
> Manos Pitsidianakis (3):
>    util/readline.c:fix lints for readline_handle_byte
>    util/readline.c: add C-n, C-p shortcuts
>    util/readline.c: add C-u shortcut

Series queued, thanks.