mbox

[PULL] Zynq-7000 EPP platform model

Message ID CAEgOgz4xLcw603BCGrORQp3WcsDu8KepE49a3g91kiheRrNkyw@mail.gmail.com
State New
Headers show

Pull-request

git://developer.petalogix.com/private/peterc/qemu.git zynq-initial.6

Message

Peter A. G. Crosthwaite Feb. 20, 2012, 6:25 a.m. UTC
Pull Request for Zynq-7000 platform model initial support.

The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9:

  input: send kbd+mouse events only to running guests. (2012-02-17
11:02:55 -0600)

are available in the git repository at:
  git://developer.petalogix.com/private/peterc/qemu.git zynq-initial.6

Peter A. G. Crosthwaite (4):
      cadence_uart: initial version of device model
      cadence_ttc: initial version of device model
      cadence_gem: initial version of device model
      xilinx_zynq: machine model initial version

 MAINTAINERS          |    5 +
 Makefile.target      |    4 +
 hw/cadence_gem.c     | 1229 ++++++++++++++++++++++++++++++++++++++++++++++++++
 hw/cadence_ttc.c     |  439 ++++++++++++++++++
 hw/cadence_uart.c    |  559 +++++++++++++++++++++++
 hw/xilinx_zynq.c     |  173 +++++++
 hw/zynq_arm_sysctl.c |  532 ++++++++++++++++++++++


On Mon, Feb 20, 2012 at 11:45 AM, Peter A. G. Crosthwaite
<peter.crosthwaite@petalogix.com> wrote:
> This is a suite of Device models and a machine model for the Xilinx Zynq-7000 Extensible Processing Platform:
>
> http://www.xilinx.com/products/silicon-devices/epp/zynq-7000/index.htm
>
> This is an ARM based platform featuring embedded SoC peripherals. This patch series includes a minimal set of device models and a a machine model capable of emulating zynq platforms booting linux.
>
> This first 3 patches in this series are device models for IP provided by cadence for the Zynq platform. The final patch is the initial revision of the zynq machine model.
>
> Most of this work was originally authored by Xilinx, as indicated by (c) notices in added files.
>
> Tree is available from:
> git://developer.petalogix.com/private/peterc/qemu.git
> branch: zynq-initial.5
>
> ---
> changed from v5:
> removed usages of arm_boot_info->bootsmp_priv_base (4/4)
> changed from v4:
> fixed FSF addess (1/4) (2/4) (4/4)
> changed device_init -> type_init (all)
> changed from v3:
> fixed timer race condition issue (2/4)
> changed from v2:
> fixed timer prescision issue (2/4)
> fixed compile warnings in zynq_arm_sysctl (4/4)
> changes from v1:
> formatting and style fixes
> updated for QOM
> removed former patch 3 (cadence WDT device model) - not required
> removed former patch 5 (dtb argument) - this is currently under discussion in other patch series'
> removed former patch 6 (initrd parameterisation) - not required for minimal boot
>
>
>
> Peter A. G. Crosthwaite (4):
>  cadence_uart: initial version of device model
>  cadence_ttc: initial version of device model
>  cadence_gem: initial version of device model
>  xilinx_zynq: machine model initial version
>
>  MAINTAINERS          |    5 +
>  Makefile.target      |    4 +
>  hw/cadence_gem.c     | 1229 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/cadence_ttc.c     |  439 ++++++++++++++++++
>  hw/cadence_uart.c    |  559 +++++++++++++++++++++++
>  hw/xilinx_zynq.c     |  173 +++++++
>  hw/zynq_arm_sysctl.c |  532 ++++++++++++++++++++++
>  7 files changed, 2941 insertions(+), 0 deletions(-)
>  create mode 100644 hw/cadence_gem.c
>  create mode 100644 hw/cadence_ttc.c
>  create mode 100644 hw/cadence_uart.c
>  create mode 100644 hw/xilinx_zynq.c
>  create mode 100644 hw/zynq_arm_sysctl.c
>
> --
> 1.7.3.2
>

Comments

Andreas Färber Feb. 20, 2012, 7:24 a.m. UTC | #1
Am 20.02.2012 07:25, schrieb Peter Crosthwaite:
> Pull Request for Zynq-7000 platform model initial support.
> 
> The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9:
> 
>   input: send kbd+mouse events only to running guests. (2012-02-17
> 11:02:55 -0600)
> 
> are available in the git repository at:
>   git://developer.petalogix.com/private/peterc/qemu.git zynq-initial.6

Five hours between v6 and PULL are not really much for review,
especially when Europe is sleeping. There's no Acked-by or Reviewed-by
tag at all, not even Edgar's from v5.
Usually the ARM patches get picked up by Peter Maydell and then he sends
the PULL.

Me, I'm still missing a MAINTAINERS entry for hw/zynq_arm_sysctl.c and
hw/cadence_*. But that could be added as a follow-up patch.

/-F

> 
> Peter A. G. Crosthwaite (4):
>       cadence_uart: initial version of device model
>       cadence_ttc: initial version of device model
>       cadence_gem: initial version of device model
>       xilinx_zynq: machine model initial version
> 
>  MAINTAINERS          |    5 +
>  Makefile.target      |    4 +
>  hw/cadence_gem.c     | 1229 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/cadence_ttc.c     |  439 ++++++++++++++++++
>  hw/cadence_uart.c    |  559 +++++++++++++++++++++++
>  hw/xilinx_zynq.c     |  173 +++++++
>  hw/zynq_arm_sysctl.c |  532 ++++++++++++++++++++++
Anthony Liguori Feb. 24, 2012, 4:37 p.m. UTC | #2
On 02/20/2012 12:25 AM, Peter Crosthwaite wrote:
> Pull Request for Zynq-7000 platform model initial support.
>
> The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9:
>
>    input: send kbd+mouse events only to running guests. (2012-02-17
> 11:02:55 -0600)
>
> are available in the git repository at:
>    git://developer.petalogix.com/private/peterc/qemu.git zynq-initial.6
>
> Peter A. G. Crosthwaite (4):
>        cadence_uart: initial version of device model
>        cadence_ttc: initial version of device model
>        cadence_gem: initial version of device model
>        xilinx_zynq: machine model initial version
>
>   MAINTAINERS          |    5 +
>   Makefile.target      |    4 +
>   hw/cadence_gem.c     | 1229 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   hw/cadence_ttc.c     |  439 ++++++++++++++++++
>   hw/cadence_uart.c    |  559 +++++++++++++++++++++++
>   hw/xilinx_zynq.c     |  173 +++++++
>   hw/zynq_arm_sysctl.c |  532 ++++++++++++++++++++++

I'd prefer this comes through Peter's tree for now.  If Peter wants to pull from 
you into his tree, I'm okay with that.

Regards,

Anthony Liguori
Peter A. G. Crosthwaite Feb. 27, 2012, 4:31 a.m. UTC | #3
On Sat, Feb 25, 2012 at 2:37 AM, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 02/20/2012 12:25 AM, Peter Crosthwaite wrote:
>>
>> Pull Request for Zynq-7000 platform model initial support.
>>
>> The following changes since commit
>> 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9:
>>
>>   input: send kbd+mouse events only to running guests. (2012-02-17
>> 11:02:55 -0600)
>>
>> are available in the git repository at:
>>   git://developer.petalogix.com/private/peterc/qemu.git zynq-initial.6
>>
>> Peter A. G. Crosthwaite (4):
>>       cadence_uart: initial version of device model
>>       cadence_ttc: initial version of device model
>>       cadence_gem: initial version of device model
>>       xilinx_zynq: machine model initial version
>>
>>  MAINTAINERS          |    5 +
>>  Makefile.target      |    4 +
>>  hw/cadence_gem.c     | 1229
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  hw/cadence_ttc.c     |  439 ++++++++++++++++++
>>  hw/cadence_uart.c    |  559 +++++++++++++++++++++++
>>  hw/xilinx_zynq.c     |  173 +++++++
>>  hw/zynq_arm_sysctl.c |  532 ++++++++++++++++++++++
>
>
> I'd prefer this comes through Peter's tree for now.  If Peter wants to pull
> from you into his tree, I'm okay with that.
>

Ok. v7 is up on the mailing list and addresses the bulk of Peters
comments re v6. Awaiting further review.

> Regards,
>
> Anthony Liguori

Regards,
Peter