| Message ID | 20240417112325.728010-2-bgray@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d7228a58d9438d6f219dc7f33eab0d1980b3bd2f |
| Headers | show |
| Series | Add dynamic DEXCR support | expand |
On Wed, 2024-04-17 at 21:23 +1000, Benjamin Gray wrote: > The hashchk tests want to verify that the hash key is changed over > exec. > It does so by calculating hashes at the same address across an exec. > This is made simpler by disabling PIE functionality, so we can > re-execute ourselves and be using the same addresses in the child. > > While -fno-pie is already added, -no-pie is also required. > > Fixes: ca64da7574f8 ("selftests/powerpc/dexcr: Add hashst/hashchk > test") > Signed-off-by: Benjamin Gray <bgray@linux.ibm.com> This matches the gcc documentation. Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com> Tested-by: Andrew Donnellan <ajd@linux.ibm.com> > > --- > > This is not related to features introduced in this series, just fixes > the test added in the static DEXCR series. > --- > tools/testing/selftests/powerpc/dexcr/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/powerpc/dexcr/Makefile > b/tools/testing/selftests/powerpc/dexcr/Makefile > index 76210f2bcec3..829ad075b4a4 100644 > --- a/tools/testing/selftests/powerpc/dexcr/Makefile > +++ b/tools/testing/selftests/powerpc/dexcr/Makefile > @@ -3,7 +3,7 @@ TEST_GEN_FILES := lsdexcr > > include ../../lib.mk > > -$(OUTPUT)/hashchk_test: CFLAGS += -fno-pie $(call cc-option,-mno- > rop-protect) > +$(OUTPUT)/hashchk_test: CFLAGS += -fno-pie -no-pie $(call cc- > option,-mno-rop-protect) > > $(TEST_GEN_PROGS): ../harness.c ../utils.c ./dexcr.c > $(TEST_GEN_FILES): ../utils.c ./dexcr.c
diff --git a/tools/testing/selftests/powerpc/dexcr/Makefile b/tools/testing/selftests/powerpc/dexcr/Makefile index 76210f2bcec3..829ad075b4a4 100644 --- a/tools/testing/selftests/powerpc/dexcr/Makefile +++ b/tools/testing/selftests/powerpc/dexcr/Makefile @@ -3,7 +3,7 @@ TEST_GEN_FILES := lsdexcr include ../../lib.mk -$(OUTPUT)/hashchk_test: CFLAGS += -fno-pie $(call cc-option,-mno-rop-protect) +$(OUTPUT)/hashchk_test: CFLAGS += -fno-pie -no-pie $(call cc-option,-mno-rop-protect) $(TEST_GEN_PROGS): ../harness.c ../utils.c ./dexcr.c $(TEST_GEN_FILES): ../utils.c ./dexcr.c
The hashchk tests want to verify that the hash key is changed over exec. It does so by calculating hashes at the same address across an exec. This is made simpler by disabling PIE functionality, so we can re-execute ourselves and be using the same addresses in the child. While -fno-pie is already added, -no-pie is also required. Fixes: ca64da7574f8 ("selftests/powerpc/dexcr: Add hashst/hashchk test") Signed-off-by: Benjamin Gray <bgray@linux.ibm.com> --- This is not related to features introduced in this series, just fixes the test added in the static DEXCR series. --- tools/testing/selftests/powerpc/dexcr/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)