Message ID | 20240404-papr-vpd-test-uninit-lc-v2-1-37bff46c65a5@linux.ibm.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 210cfef579260ed6c3b700e7baeae51a5e183f43 |
Headers | show |
Series | [v2] selftests/powerpc/papr-vpd: Fix missing variable initialization | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
On Thu, 04 Apr 2024 17:02:09 -0500, Nathan Lynch wrote: > The "close handle without consuming VPD" testcase has inconsistent > results because it fails to initialize the location code object it > passes to ioctl() to create a VPD handle. Initialize the location code > to the empty string as intended. > > Applied to powerpc/fixes. [1/1] selftests/powerpc/papr-vpd: Fix missing variable initialization https://git.kernel.org/powerpc/c/210cfef579260ed6c3b700e7baeae51a5e183f43 cheers
diff --git a/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c b/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c index 505294da1b9f..d6f99eb9be65 100644 --- a/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c +++ b/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c @@ -154,7 +154,7 @@ static int dev_papr_vpd_null_handle(void) static int papr_vpd_close_handle_without_reading(void) { const int devfd = open(DEVPATH, O_RDONLY); - struct papr_location_code lc; + struct papr_location_code lc = { .str = "", }; int fd; SKIP_IF_MSG(devfd < 0 && errno == ENOENT,