| Message ID | 20240407063952.36270-3-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [-next,1/3] powerpc: boot: Fix a typo in partial_decompress() comment | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_ppctests | fail | ppctests (ubuntu-22.04, ppc64le) failed at step Build. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
On 4/6/24 11:39 PM, Yang Li wrote: > This commit adds kernel-doc style comments with complete parameter > descriptions for the function smp_startup_cpu(). > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > arch/powerpc/platforms/cell/smp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/platforms/cell/smp.c b/arch/powerpc/platforms/cell/smp.c > index 30394c6f8894..bdb7adde798d 100644 > --- a/arch/powerpc/platforms/cell/smp.c > +++ b/arch/powerpc/platforms/cell/smp.c > @@ -55,6 +55,8 @@ static cpumask_t of_spin_map; > /** > * smp_startup_cpu() - start the given cpu > * > + * @lcpu: Logical CPU ID of the CPU to be started. Does this work with the blank line between the function and parameter? (i.e., no kernel-doc warnings?) Usually it's done without the extra line. Otherwise the additional line for @lcpu: looks good to me. Thanks. > + * > * At boot time, there is nothing to do for primary threads which were > * started from Open Firmware. For anything else, call RTAS with the > * appropriate start location.
diff --git a/arch/powerpc/platforms/cell/smp.c b/arch/powerpc/platforms/cell/smp.c index 30394c6f8894..bdb7adde798d 100644 --- a/arch/powerpc/platforms/cell/smp.c +++ b/arch/powerpc/platforms/cell/smp.c @@ -55,6 +55,8 @@ static cpumask_t of_spin_map; /** * smp_startup_cpu() - start the given cpu * + * @lcpu: Logical CPU ID of the CPU to be started. + * * At boot time, there is nothing to do for primary threads which were * started from Open Firmware. For anything else, call RTAS with the * appropriate start location.
This commit adds kernel-doc style comments with complete parameter descriptions for the function smp_startup_cpu(). Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- arch/powerpc/platforms/cell/smp.c | 2 ++ 1 file changed, 2 insertions(+)