Message ID | 20240305233931.283629-2-richard.henderson@linaro.org |
---|---|
State | New |
Headers | show |
Series | linux-user/elfload: Two Coverity fixes | expand |
On 6/3/24 00:39, Richard Henderson wrote: > Fixes Coverity CID: 1534964 > Fixes: 106f8da664 ("linux-user/elfload: Open core file after vma_init") > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > linux-user/elfload.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 0c299a7c15..8565b9520a 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -4522,7 +4522,9 @@ static int elf_core_dump(int signr, const CPUArchState *env) ret = -errno; mmap_unlock(); cpu_list_unlock(); - close(fd); + if (fd >= 0) { + close(fd); + } return ret; } #endif /* USE_ELF_CORE_DUMP */
Fixes Coverity CID: 1534964 Fixes: 106f8da664 ("linux-user/elfload: Open core file after vma_init") Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- linux-user/elfload.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)