diff mbox series

dmicheck: Fix mistake in previous update to 3.7

Message ID 20240229010509.368-1-mario.limonciello@amd.com
State Rejected
Headers show
Series dmicheck: Fix mistake in previous update to 3.7 | expand

Commit Message

Mario Limonciello Feb. 29, 2024, 1:05 a.m. UTC
For type 17 version 3.7 the length is still 0x5c.  It shouldn't
have been updated to 0x64.

Fixes: dfc5729b ("dmicheck: update supported DMI version to 3.7")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 src/dmi/dmicheck/dmicheck.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

ivanhu March 5, 2024, 10:17 a.m. UTC | #1
Hi Mario,

Could you help me to confirm?
https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf
on page 102, section 7.18, I saw,
5Ch 3.7+ PMIC0 Manufacturer ID WORD Varies The two-byte PMIC0 manufacturer ID found in the SPD of this memory device; LSB first. See 7.18.15 for definitions.
5Eh 3.7+ PMIC0 Revision Number WORD Varies The PMIC 0 Revision Number found in the SPD of this memory device.
See 7.18.16 for definitions.
60h 3.7+ RCD Manufacturer ID WORD Varies The two-byte RCD manufacturer ID found in the SPD of this memory device; LSB first. See 7.18.17 for definitions.
62h 3.7+ RCD Revision Number WORD Varies The RCD 0 Revision Number found in the SPD of this memory device. See 7.18.18 for definitions.

Do I miss something?

Cheers,
Ivan

On 2/29/24 09:05, Mario Limonciello wrote:
> For type 17 version 3.7 the length is still 0x5c.  It shouldn't
> have been updated to 0x64.
> 
> Fixes: dfc5729b ("dmicheck: update supported DMI version to 3.7")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   src/dmi/dmicheck/dmicheck.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index b7cca5e4..904c0356 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -299,8 +299,7 @@ static const fwts_dmi_type_length type_info[] = {
>   	{ 17, 0x208, 0x207, 0x22 },
>   	{ 17, 0x302, 0x208, 0x28 },
>   	{ 17, 0x303, 0x302, 0x54 },
> -	{ 17, 0x307, 0x303, 0x5c },
> -	{ 17, MAX_VERSION, 0x307, 0x64 },
> +	{ 17, MAX_VERSION, 0x303, 0x5c },
>   	{ 19, 0x207, 0x201, 0xf },
>   	{ 19, MAX_VERSION, 0x207, 0x1f },
>   	{ 20, 0x207, 0x201, 0x13 },
Mario Limonciello March 5, 2024, 11:07 p.m. UTC | #2
On 3/5/2024 04:17, ivanhu wrote:
> Hi Mario,
> 
> Could you help me to confirm?
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf
> on page 102, section 7.18, I saw,
> 5Ch 3.7+ PMIC0 Manufacturer ID WORD Varies The two-byte PMIC0 
> manufacturer ID found in the SPD of this memory device; LSB first. See 
> 7.18.15 for definitions.
> 5Eh 3.7+ PMIC0 Revision Number WORD Varies The PMIC 0 Revision Number 
> found in the SPD of this memory device.
> See 7.18.16 for definitions.
> 60h 3.7+ RCD Manufacturer ID WORD Varies The two-byte RCD manufacturer 
> ID found in the SPD of this memory device; LSB first. See 7.18.17 for 
> definitions.
> 62h 3.7+ RCD Revision Number WORD Varies The RCD 0 Revision Number found 
> in the SPD of this memory device. See 7.18.18 for definitions.
> 
> Do I miss something?
> 

I was going off of a failure reported and cross referencing page 99

01h 2.1+ Length BYTE Varies Length of the structure, 15h for version 
2.1, 1Bh for
version 2.3, 1Ch for version 2.6, 22h for version
2.7, 28h for version 2.8, 54h for version 3.2, 5Ch
for version 3.3 and later

Let me check with internal guys on this to see if it's a mistake on 
their side.

> Cheers,
> Ivan
> 
> On 2/29/24 09:05, Mario Limonciello wrote:
>> For type 17 version 3.7 the length is still 0x5c.  It shouldn't
>> have been updated to 0x64.
>>
>> Fixes: dfc5729b ("dmicheck: update supported DMI version to 3.7")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   src/dmi/dmicheck/dmicheck.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
>> index b7cca5e4..904c0356 100644
>> --- a/src/dmi/dmicheck/dmicheck.c
>> +++ b/src/dmi/dmicheck/dmicheck.c
>> @@ -299,8 +299,7 @@ static const fwts_dmi_type_length type_info[] = {
>>       { 17, 0x208, 0x207, 0x22 },
>>       { 17, 0x302, 0x208, 0x28 },
>>       { 17, 0x303, 0x302, 0x54 },
>> -    { 17, 0x307, 0x303, 0x5c },
>> -    { 17, MAX_VERSION, 0x307, 0x64 },
>> +    { 17, MAX_VERSION, 0x303, 0x5c },
>>       { 19, 0x207, 0x201, 0xf },
>>       { 19, MAX_VERSION, 0x207, 0x1f },
>>       { 20, 0x207, 0x201, 0x13 },
diff mbox series

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index b7cca5e4..904c0356 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -299,8 +299,7 @@  static const fwts_dmi_type_length type_info[] = {
 	{ 17, 0x208, 0x207, 0x22 },
 	{ 17, 0x302, 0x208, 0x28 },
 	{ 17, 0x303, 0x302, 0x54 },
-	{ 17, 0x307, 0x303, 0x5c },
-	{ 17, MAX_VERSION, 0x307, 0x64 },
+	{ 17, MAX_VERSION, 0x303, 0x5c },
 	{ 19, 0x207, 0x201, 0xf },
 	{ 19, MAX_VERSION, 0x207, 0x1f },
 	{ 20, 0x207, 0x201, 0x13 },