| Message ID | 2402f44309e1c9705501bdc9b798e8fe6d73f905.1706470223.git.agordeev@linux.ibm.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | sched/vtime: vtime.h headers cleanup | expand |
On Sun, Jan 28, 2024 at 08:58:54PM +0100, Alexander Gordeev wrote: > There is no architecture-specific code or data left > that generic <linux/vtime.h> needs to know about. > Thus, avoid the inclusion of <asm/vtime.h> header. > > Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com> > --- > include/asm-generic/vtime.h | 1 - > include/linux/vtime.h | 4 ---- > 2 files changed, 5 deletions(-) > delete mode 100644 include/asm-generic/vtime.h I guess you need to get rid of this as well: arch/powerpc/include/asm/Kbuild:generic-y += vtime.h
Le Sun, Jan 28, 2024 at 08:58:54PM +0100, Alexander Gordeev a écrit : > There is no architecture-specific code or data left > that generic <linux/vtime.h> needs to know about. > Thus, avoid the inclusion of <asm/vtime.h> header. > > Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com> Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
On Wed, Feb 07, 2024 at 12:30:08AM +0100, Frederic Weisbecker wrote:
> Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Thank you for the review, Frederic!
The Heiko comment is valid and I would add this chunk in v2:
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -6,5 +6,4 @@ generic-y += agp.h
generic-y += kvm_types.h
generic-y += mcs_spinlock.h
generic-y += qrwlock.h
-generic-y += vtime.h
generic-y += early_ioremap.h
Would you keep your Reviewed-by?
Le Wed, Feb 07, 2024 at 03:12:57PM +0100, Alexander Gordeev a écrit : > On Wed, Feb 07, 2024 at 12:30:08AM +0100, Frederic Weisbecker wrote: > > Reviewed-by: Frederic Weisbecker <frederic@kernel.org> > > Thank you for the review, Frederic! > > The Heiko comment is valid and I would add this chunk in v2: > > --- a/arch/powerpc/include/asm/Kbuild > +++ b/arch/powerpc/include/asm/Kbuild > @@ -6,5 +6,4 @@ generic-y += agp.h > generic-y += kvm_types.h > generic-y += mcs_spinlock.h > generic-y += qrwlock.h > -generic-y += vtime.h > generic-y += early_ioremap.h > > Would you keep your Reviewed-by? Sure!
diff --git a/include/asm-generic/vtime.h b/include/asm-generic/vtime.h deleted file mode 100644 index b1a49677fe25..000000000000 --- a/include/asm-generic/vtime.h +++ /dev/null @@ -1 +0,0 @@ -/* no content, but patch(1) dislikes empty files */ diff --git a/include/linux/vtime.h b/include/linux/vtime.h index 593466ceebed..29dd5b91dd7d 100644 --- a/include/linux/vtime.h +++ b/include/linux/vtime.h @@ -5,10 +5,6 @@ #include <linux/context_tracking_state.h> #include <linux/sched.h> -#ifdef CONFIG_VIRT_CPU_ACCOUNTING_NATIVE -#include <asm/vtime.h> -#endif - /* * Common vtime APIs */
There is no architecture-specific code or data left that generic <linux/vtime.h> needs to know about. Thus, avoid the inclusion of <asm/vtime.h> header. Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com> --- include/asm-generic/vtime.h | 1 - include/linux/vtime.h | 4 ---- 2 files changed, 5 deletions(-) delete mode 100644 include/asm-generic/vtime.h