| Message ID | 20240115092216.30798-1-abelova@astralinux.ru |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] load_elf: fix iterator's type for elf file processing | expand |
On Mon, 15 Jan 2024 at 09:22, Anastasia Belova <abelova@astralinux.ru> wrote: > > j is used while loading an ELF file to byteswap segments' > data. If data is larger than 2GB an overflow may happen. > So j should be elf_word. > > This commit fixes a minor bug, maybe even a typo. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 7ef295ea5b ("loader: Add data swap option to load-elf") > Signed-off-by: Anastasia Belova <abelova@astralinux.ru> > --- > v2: fix type of j > v3: remove changes for i, size and another j > Thanks for your patience. > include/hw/elf_ops.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to target-arm.next, with a minor tweak to the commit message. Thanks for your contribution! -- PMM
diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index 0a5c258fe6..9c35d1b9da 100644 --- a/include/hw/elf_ops.h +++ b/include/hw/elf_ops.h @@ -500,7 +500,7 @@ static ssize_t glue(load_elf, SZ)(const char *name, int fd, } if (data_swab) { - int j; + elf_word j; for (j = 0; j < file_size; j += (1 << data_swab)) { uint8_t *dp = data + j; switch (data_swab) {
j is used while loading an ELF file to byteswap segments' data. If data is larger than 2GB an overflow may happen. So j should be elf_word. This commit fixes a minor bug, maybe even a typo. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 7ef295ea5b ("loader: Add data swap option to load-elf") Signed-off-by: Anastasia Belova <abelova@astralinux.ru> --- v2: fix type of j v3: remove changes for i, size and another j Thanks for your patience. include/hw/elf_ops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)