| Message ID | 20231219143829.8961-1-heinrich.schuchardt@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] docs/system/riscv: document acpi parameter of virt machine | expand |
On 12/19/23 11:38, Heinrich Schuchardt wrote: > Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI > table generation. Add it to the documentation. > > Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > docs/system/riscv/virt.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst > index f5fa7b8b29..4e134ff2ac 100644 > --- a/docs/system/riscv/virt.rst > +++ b/docs/system/riscv/virt.rst > @@ -95,6 +95,11 @@ The following machine-specific options are supported: > SiFive CLINT. When not specified, this option is assumed to be "off". > This option is restricted to the TCG accelerator. > > +- acpi=[on|off|auto] > + > + When this option is "on", ACPI tables are generated and exposed as firmware > + tables etc/acpi/rsdp and etc/acpi/tables. > + > - aia=[none|aplic|aplic-imsic] > > This option allows selecting interrupt controller defined by the AIA
On Tue, Dec 19, 2023 at 03:38:29PM +0100, Heinrich Schuchardt wrote: > Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI > table generation. Add it to the documentation. > > Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > docs/system/riscv/virt.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst > index f5fa7b8b29..4e134ff2ac 100644 > --- a/docs/system/riscv/virt.rst > +++ b/docs/system/riscv/virt.rst > @@ -95,6 +95,11 @@ The following machine-specific options are supported: > SiFive CLINT. When not specified, this option is assumed to be "off". > This option is restricted to the TCG accelerator. > > +- acpi=[on|off|auto] > + > + When this option is "on", ACPI tables are generated and exposed as firmware > + tables etc/acpi/rsdp and etc/acpi/tables. > + Hi Heinrich, Should we add, When not specified or set to auto, this option is assumed to be "on"? Thanks, Sunil
On 20.12.23 07:57, Sunil V L wrote: > On Tue, Dec 19, 2023 at 03:38:29PM +0100, Heinrich Schuchardt wrote: >> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI >> table generation. Add it to the documentation. >> >> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") >> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> >> --- >> docs/system/riscv/virt.rst | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst >> index f5fa7b8b29..4e134ff2ac 100644 >> --- a/docs/system/riscv/virt.rst >> +++ b/docs/system/riscv/virt.rst >> @@ -95,6 +95,11 @@ The following machine-specific options are supported: >> SiFive CLINT. When not specified, this option is assumed to be "off". >> This option is restricted to the TCG accelerator. >> >> +- acpi=[on|off|auto] >> + >> + When this option is "on", ACPI tables are generated and exposed as firmware >> + tables etc/acpi/rsdp and etc/acpi/tables. >> + > Hi Heinrich, > > Should we add, When not specified or set to auto, this option is assumed > to be "on"? Sure. Best regards Heinrich
diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst index f5fa7b8b29..4e134ff2ac 100644 --- a/docs/system/riscv/virt.rst +++ b/docs/system/riscv/virt.rst @@ -95,6 +95,11 @@ The following machine-specific options are supported: SiFive CLINT. When not specified, this option is assumed to be "off". This option is restricted to the TCG accelerator. +- acpi=[on|off|auto] + + When this option is "on", ACPI tables are generated and exposed as firmware + tables etc/acpi/rsdp and etc/acpi/tables. + - aia=[none|aplic|aplic-imsic] This option allows selecting interrupt controller defined by the AIA
Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI table generation. Add it to the documentation. Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- docs/system/riscv/virt.rst | 5 +++++ 1 file changed, 5 insertions(+)