| Message ID | 20231109124326.21106-1-gmanning@rapitasystems.com |
|---|---|
| Headers | show |
| Series | plugins: fix win plugin tests on cross compile | expand |
Greg Manning <gmanning@rapitasystems.com> writes: > v1-v2: Added the signed-off-by line. > v2-v3: Fixed the issue reference. > > Greg Manning (1): > plugins: fix win plugin tests on cross compile > > .gitlab-ci.d/crossbuilds.yml | 2 +- > contrib/plugins/Makefile | 2 +- > plugins/meson.build | 2 +- > tests/plugin/meson.build | 3 ++- > 4 files changed, 5 insertions(+), 4 deletions(-) Queued to for-8.2/random-fixes, thanks.
Greg Manning <gmanning@rapitasystems.com> writes: > v1-v2: Added the signed-off-by line. > v2-v3: Fixed the issue reference. > > Greg Manning (1): > plugins: fix win plugin tests on cross compile > > .gitlab-ci.d/crossbuilds.yml | 2 +- > contrib/plugins/Makefile | 2 +- > plugins/meson.build | 2 +- > tests/plugin/meson.build | 3 ++- > 4 files changed, 5 insertions(+), 4 deletions(-) Actually I'm still seeing failures: FAILED: qemu-system-aarch64.exe x86_64-w64-mingw32-gcc -m64 -mcx16 @qemu-system-aarch64.exe.rsp /usr/lib/gcc/x86_64-w64-mingw32/12.2.1/../../../../x86_64-w64-mingw32/bin/ld: libcommon.fa.p/os-win32.c.obj: in function `set_dll_delaylink_hook': /builds/stsquad/qemu/build/../os-win32.c:83: undefined reference to `g_module_symbol' /usr/lib/gcc/x86_64-w64-mingw32/12.2.1/../../../../x86_64-w64-mingw32/bin/ld: /builds/stsquad/qemu/build/../os-win32.c:89: undefined reference to `g_module_symbol' collect2: error: ld returned 1 exit status [2104/3331] Linking target qemu-system-aarch64w.exe FAILED: qemu-system-aarch64w.exe x86_64-w64-mingw32-gcc -m64 -mcx16 @qemu-system-aarch64w.exe.rsp /usr/lib/gcc/x86_64-w64-mingw32/12.2.1/../../../../x86_64-w64-mingw32/bin/ld: libcommon.fa.p/os-win32.c.obj: in function `set_dll_delaylink_hook': /builds/stsquad/qemu/build/../os-win32.c:83: undefined reference to `g_module_symbol' /usr/lib/gcc/x86_64-w64-mingw32/12.2.1/../../../../x86_64-w64-mingw32/bin/ld: /builds/stsquad/qemu/build/../os-win32.c:89: undefined reference to `g_module_symbol' collect2: error: ld returned 1 exit status [2105/3331] Compiling C object libqemu-loongarch64-softmmu.fa.p/hw_loongarch_virt.c.obj ninja: build stopped: subcommand failed. make: *** [Makefile:162: run-ninja] Error 1 Should I drop the other patch I grabbed: plugins: Move the windows linking function to qemu ?
Il gio 9 nov 2023, 17:04 Alex Bennée <alex.bennee@linaro.org> ha scritto: > Should I drop the other patch I grabbed: > > plugins: Move the windows linking function to qemu > Yes, go ahead and drop it. Paolo > ? > > -- > Alex Bennée > Virtualisation Tech Lead @ Linaro > >
Alex Bennée <alex.bennee@linaro.org> writes: > Greg Manning <gmanning@rapitasystems.com> writes: > > v1-v2: Added the signed-off-by line. > > v2-v3: Fixed the issue reference. > > > > Greg Manning (1): > > plugins: fix win plugin tests on cross compile > > > > .gitlab-ci.d/crossbuilds.yml | 2 +- > > contrib/plugins/Makefile | 2 +- > > plugins/meson.build | 2 +- > > tests/plugin/meson.build | 3 ++- > > 4 files changed, 5 insertions(+), 4 deletions(-) > Actually I'm still seeing failures: > FAILED: qemu-system-aarch64.exe > x86_64-w64-mingw32-gcc -m64 -mcx16 @qemu-system-aarch64.exe.rsp > /usr/lib/gcc/x86_64-w64-mingw32/12.2.1/../../../../x86_64-w64-mingw32/bin/ld: libcommon.fa.p/os-win32.c.obj: in function `set_dll_delaylink_hook': > /builds/stsquad/qemu/build/../os-win32.c:83: undefined reference to `g_module_symbol' > /usr/lib/gcc/x86_64-w64-mingw32/12.2.1/../../../../x86_64-w64-mingw32/bin/ld: /builds/stsquad/qemu/build/../os-win32.c:89: undefined reference to `g_module_symbol' > collect2: error: ld returned 1 exit status > [2104/3331] Linking target qemu-system-aarch64w.exe > FAILED: qemu-system-aarch64w.exe > x86_64-w64-mingw32-gcc -m64 -mcx16 @qemu-system-aarch64w.exe.rsp > /usr/lib/gcc/x86_64-w64-mingw32/12.2.1/../../../../x86_64-w64-mingw32/bin/ld: libcommon.fa.p/os-win32.c.obj: in function `set_dll_delaylink_hook': > /builds/stsquad/qemu/build/../os-win32.c:83: undefined reference to `g_module_symbol' > /usr/lib/gcc/x86_64-w64-mingw32/12.2.1/../../../../x86_64-w64-mingw32/bin/ld: /builds/stsquad/qemu/build/../os-win32.c:89: undefined reference to `g_module_symbol' > collect2: error: ld returned 1 exit status > [2105/3331] Compiling C object libqemu-loongarch64-softmmu.fa.p/hw_loongarch_virt.c.obj > ninja: build stopped: subcommand failed. > make: *** [Makefile:162: run-ninja] Error 1 Oh, that's weird. I can't immediately repro it on WSL. It reminds me of the thing I had to do to get the plugins to compile - they needed glib passing to the linker explicitly (in contrib/plugins/Makefile): LDLIBS += $(shell $(PKG_CONFIG) --libs glib-2.0) Greg.