Message ID | 20231031111059.3407803-3-armbru@redhat.com |
---|---|
State | New |
Headers | show |
Series | Miscellaneous error message improvements | expand |
On 31/10/23 12:10, Markus Armbruster wrote: > Improve > > (qemu) sync-profile of > Error: Invalid parameter 'of' > > to > > Error: invalid parameter 'of', expecting 'on', 'off', or 'reset' > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > monitor/hmp-cmds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
* Markus Armbruster (armbru@redhat.com) wrote: > Improve > > (qemu) sync-profile of > Error: Invalid parameter 'of' > > to > > Error: invalid parameter 'of', expecting 'on', 'off', or 'reset' > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org> > --- > monitor/hmp-cmds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 6c559b48c8..871898ac46 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -24,7 +24,6 @@ > #include "qapi/qapi-commands-control.h" > #include "qapi/qapi-commands-misc.h" > #include "qapi/qmp/qdict.h" > -#include "qapi/qmp/qerror.h" > #include "qemu/cutils.h" > #include "hw/intc/intc.h" > #include "qemu/log.h" > @@ -138,7 +137,8 @@ void hmp_sync_profile(Monitor *mon, const QDict *qdict) > } else { > Error *err = NULL; > > - error_setg(&err, QERR_INVALID_PARAMETER, op); > + error_setg(&err, "invalid parameter '%s'," > + " expecting 'on', 'off', or 'reset'", op); > hmp_handle_error(mon, err); > } > } > -- > 2.41.0 >
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 6c559b48c8..871898ac46 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -24,7 +24,6 @@ #include "qapi/qapi-commands-control.h" #include "qapi/qapi-commands-misc.h" #include "qapi/qmp/qdict.h" -#include "qapi/qmp/qerror.h" #include "qemu/cutils.h" #include "hw/intc/intc.h" #include "qemu/log.h" @@ -138,7 +137,8 @@ void hmp_sync_profile(Monitor *mon, const QDict *qdict) } else { Error *err = NULL; - error_setg(&err, QERR_INVALID_PARAMETER, op); + error_setg(&err, "invalid parameter '%s'," + " expecting 'on', 'off', or 'reset'", op); hmp_handle_error(mon, err); } }
Improve (qemu) sync-profile of Error: Invalid parameter 'of' to Error: invalid parameter 'of', expecting 'on', 'off', or 'reset' Signed-off-by: Markus Armbruster <armbru@redhat.com> --- monitor/hmp-cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)