Message ID | 20231031111059.3407803-4-armbru@redhat.com |
---|---|
State | New |
Headers | show |
Series | Miscellaneous error message improvements | expand |
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com> On Tue, Oct 31, 2023 at 1:11 PM Markus Armbruster <armbru@redhat.com> wrote: > When the PID passed to guest-exec-status does not exist, we report > > "Invalid parameter 'pid'" > > Improve this to > > "PID 1234 does not exist" > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > qga/commands.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/commands.c b/qga/commands.c > index ce172edd2d..88c1c99fe5 100644 > --- a/qga/commands.c > +++ b/qga/commands.c > @@ -154,7 +154,7 @@ GuestExecStatus *qmp_guest_exec_status(int64_t pid, > Error **errp) > > gei = guest_exec_info_find(pid); > if (gei == NULL) { > - error_setg(errp, QERR_INVALID_PARAMETER, "pid"); > + error_setg(errp, "PID " PRId64 " does not exist"); > return NULL; > } > > -- > 2.41.0 > >
On 31/10/23 12:10, Markus Armbruster wrote: > When the PID passed to guest-exec-status does not exist, we report > > "Invalid parameter 'pid'" > > Improve this to > > "PID 1234 does not exist" > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > qga/commands.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/qga/commands.c b/qga/commands.c index ce172edd2d..88c1c99fe5 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -154,7 +154,7 @@ GuestExecStatus *qmp_guest_exec_status(int64_t pid, Error **errp) gei = guest_exec_info_find(pid); if (gei == NULL) { - error_setg(errp, QERR_INVALID_PARAMETER, "pid"); + error_setg(errp, "PID " PRId64 " does not exist"); return NULL; }
When the PID passed to guest-exec-status does not exist, we report "Invalid parameter 'pid'" Improve this to "PID 1234 does not exist" Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qga/commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)