diff mbox series

util/uuid: Define UUID_STR_LEN from UUID_NONE string

Message ID 20231027065443.1305431-1-clg@redhat.com
State New
Headers show
Series util/uuid: Define UUID_STR_LEN from UUID_NONE string | expand

Commit Message

Cédric Le Goater Oct. 27, 2023, 6:54 a.m. UTC 
Cc: Fam Zheng <fam@euphon.net>
Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---

 Follow up on :
 
 https://lore.kernel.org/qemu-devel/20231026070636.1165037-1-clg@redhat.com/

 include/qemu/uuid.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Philippe Mathieu-Daudé Oct. 27, 2023, 7:18 a.m. UTC | #1 
On 27/10/23 08:54, Cédric Le Goater wrote:
> Cc: Fam Zheng <fam@euphon.net>
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> 
>   Follow up on :
>   
>   https://lore.kernel.org/qemu-devel/20231026070636.1165037-1-clg@redhat.com/
> 
>   include/qemu/uuid.h | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!
Cédric Le Goater Oct. 30, 2023, 8:59 a.m. UTC | #2 
On 10/27/23 08:54, Cédric Le Goater wrote:
> Cc: Fam Zheng <fam@euphon.net>
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> 
>   Follow up on :
>   
>   https://lore.kernel.org/qemu-devel/20231026070636.1165037-1-clg@redhat.com/
> 
>   include/qemu/uuid.h | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/qemu/uuid.h b/include/qemu/uuid.h
> index 356efe7b5797911640ed347fc08f4ef5ebbd0476..869f84af09ddc4aa80d53e133c323781ade4d190 100644
> --- a/include/qemu/uuid.h
> +++ b/include/qemu/uuid.h
> @@ -78,9 +78,10 @@ typedef struct {
>                    "%02hhx%02hhx-" \
>                    "%02hhx%02hhx%02hhx%02hhx%02hhx%02hhx"
>   
> -#define UUID_STR_LEN (36 + 1)
> -
>   #define UUID_NONE "00000000-0000-0000-0000-000000000000"
> +QEMU_BUILD_BUG_ON(sizeof(UUID_NONE) - 1 != 36);
> +
> +#define UUID_STR_LEN sizeof(UUID_NONE)
>   
>   void qemu_uuid_generate(QemuUUID *out);
>   

Applied to vfio-next.

Thanks,

C.
diff mbox series

Patch

diff --git a/include/qemu/uuid.h b/include/qemu/uuid.h
index 356efe7b5797911640ed347fc08f4ef5ebbd0476..869f84af09ddc4aa80d53e133c323781ade4d190 100644
--- a/include/qemu/uuid.h
+++ b/include/qemu/uuid.h
@@ -78,9 +78,10 @@  typedef struct {
                  "%02hhx%02hhx-" \
                  "%02hhx%02hhx%02hhx%02hhx%02hhx%02hhx"
 
-#define UUID_STR_LEN (36 + 1)
-
 #define UUID_NONE "00000000-0000-0000-0000-000000000000"
+QEMU_BUILD_BUG_ON(sizeof(UUID_NONE) - 1 != 36);
+
+#define UUID_STR_LEN sizeof(UUID_NONE)
 
 void qemu_uuid_generate(QemuUUID *out);